Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <37feb67d-854c-e76e-1de9-256b7394ab09@amd.com>
Date:   Thu, 6 Oct 2022 17:04:10 +0530
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.9.1
Subject: Re: [PATCH v5] perf test: Introduce script for data symbol testing
Content-Language: en-US
To:     Leo Yan <leo.yan@linaro.org>,
        Arnaldo Carvalho de Melo <acme@kernel.org>,
        Namhyung Kim <namhyung@kernel.org>,
        Peter Zijlstra <peterz@infradead.org>,
        Ingo Molnar <mingo@redhat.com>,
        Mark Rutland <mark.rutland@arm.com>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Jiri Olsa <jolsa@kernel.org>, linux-kernel@vger.kernel.org,
        linux-perf-users@vger.kernel.org
References: <20221006101039.47870-1-leo.yan@linaro.org>
Cc:     Ravi Bangoria <ravi.bangoria@amd.com>
From:   Ravi Bangoria <ravi.bangoria@amd.com>
In-Reply-To: <20221006101039.47870-1-leo.yan@linaro.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Uk5nSExMcDMzWG1lWWk4emI2Y0VKSWZ1MnU4ZjBNM0hYMHJSMnJLbWxOSVNW?=
 =?utf-8?B?M05FRk5iYnlTZExUdmcrZWx4Q2JpMEJFalkvT0VZVmFNZG55bHQrODZKUGZ2?=
 =?utf-8?B?dGxXSXVmZGs0c2V5TmRjK1dQcEV3ZGJIZG1CNGdpQk5iNUx2a3lpaVlXRWYr?=
 =?utf-8?B?ZEE4YXR2NERtTDlEN3k5cXh0YkNoYnArSFdBeUhPTVhSWUhpb1Z0L3VhTDEz?=
 =?utf-8?B?blI4TFppeXpPMXo2S3ZHYldWbjNHYUZ2SEVwUjZzbjhGVitFNll1QTlhR1NN?=
 =?utf-8?B?a29LVHJmQnR6K09OMm10aXRsTkxGdEhSRks1UDNtdUFJNTdCRUt1UGV4WUJY?=
 =?utf-8?B?Z25WdzgvNFdvczU5UGNTN1ZDZW8wOWluNWlSdW1HSGIydHdSVEN5VkNTcW1a?=
 =?utf-8?B?K1pyZkphRTRnOFU5WTlsVjNvQk1mbFdlU3ovblVQdFZCS3J5Y1ZrN1BMYUJB?=
 =?utf-8?B?S0pkdC9vejcvVjJFSEMrZjJqd1hiMUJvVWZORWJnNjRUWHZLRXVSQWMvV3VY?=
 =?utf-8?B?R2QvYVJSelFqbE9HQzN6V3dhQ01ZMmVOYk9Bd2hQQVhWM1RpY01XUHRydEtE?=
 =?utf-8?B?YTYyZzhCaHQvTlNxb3RvNXA1MXdndE1GSXEwckV1REczd2FiSTd4aWIzVitS?=
 =?utf-8?B?cThxc0dFd1VOdmR0UEViQXptdFNJamRscTdubUo5VjB3TiswdE1NOWJrMnFs?=
 =?utf-8?B?eXU5NmFmSzdGNXhNZGFqenVqV2hWR2tYZERxYXdrUjd4empINkx0TjF3bU54?=
 =?utf-8?B?aXNnbHprbzZ6UGE0Vy9KQWxhKzQxUXZ4WEZtNGlYMkJTR2tlanIySVZRcVIv?=
 =?utf-8?B?V09UYzBieFVrd2VNQlhCU2NRd3hiM3dEWElNRlAvelpJTjU0ejcvMFRxMjRG?=
 =?utf-8?B?Zzc0WG91RWlSRkdFRk81akhKL3JNelNRSWZYMkhZcmx2ZjFoVUQ4MWxQZkJE?=
 =?utf-8?B?ajFPa2JGMVJES1J1aW1vNERzdHE4WDB0L3ZCc1V3QVIydTZPNkJ4Y3FxY2JP?=
 =?utf-8?B?eC9Ha0FHdTNXa2thWm94RUZGVDFTOWtuaFlJS3hmdVVPMi83M1N3VkxtNlFs?=
 =?utf-8?B?TktJdVB6THZqTjVZRnJkQWdGOEpaYmNXTDJydUx2RnhFRTBNM09aa0lEaVRx?=
 =?utf-8?B?VjVFd2R1dVVNRjFLRGp2UlJkV2VJT3B5N041OTFEQTAvUGpIRzFDV2pzMkdS?=
 =?utf-8?B?OGZZUDNWVzA5QUgvcHExVE1ieHNOalpWVlJFa2JzN0NEdmhoekpNZ3ZDcnp2?=
 =?utf-8?B?UzVITDUyaEdwdGhTQ05rWGhSaUdsNE8vRXBRTXpkSVJ1bE9WK2dDTENoNnN6?=
 =?utf-8?B?dlBMeHk0WlExQndtK2VaM09KZTgxajFFcDNXK3FvTlcxd3ZyaVlGeno0TTd6?=
 =?utf-8?B?UDFlT2xpM1J6RXNsYlFWSmNKb1hwdldybTZNVGUva3pTQThmcUNCMmUydlZv?=
 =?utf-8?B?cXA4WjFFZ3VLb2lmdTFrQ2lrYnRkVXZYYU1DUiswSzlmdExXYmMrS05ORCtq?=
 =?utf-8?B?WUtGQkZ3RFBucjhxQktvdm05VGtLRVQ5VmtIdDAwUUVKQ0d0MFZJS2FBK0h2?=
 =?utf-8?B?MWpELzIrUllVVWkvOG42QVc3aHpKbnR4QVRXbUU5NVlmRThFSkNHcndmK2Nh?=
 =?utf-8?B?ZVJ4MDBOeXhUajdmY1QxZGZ4NnVERnZlMDVXVTNrOHV5b2hGRHhsSEdoenBw?=
 =?utf-8?B?dEFUL3c4ZXd3dGxTeHh0WFhpWjFKN0xiTUhSd2VWemEvRm41aU8zbzYyK2pC?=
 =?utf-8?B?UHBPbnJWNVRxMHRYemdGdXozN1g3Ulc2M0puSnA4VzR0Z04yeHBRWWowblJS?=
 =?utf-8?B?RGM3THBQRENzaHVpbXJlaTJWbEFBL1B1K00ydVNEZUcwRUduU3VyNGdtazFz?=
 =?utf-8?B?c3kvVlk4MUxFeEN4TDZmL0cwY0VER2FqQ2REYlJOVGlpTlRIZnpKQjRmRXlR?=
 =?utf-8?B?YVNrYTBDenJlcVA1Y2dPOXJlTHJSeVJ6N013U2dsaUNCZFEzWkZDRVpNUE1w?=
 =?utf-8?B?MXdFSy9jbTNTSS85Qk1OT2xGTlE0NTFMQzY2Qmd1RHBwVXgvOEdSQi81NG9a?=
 =?utf-8?B?eGp6YURLakhoczJNWFVoZWFqWWduN0dzOFEwaFArSWxPSXMzRUJ6NWN2c3A1?=
 =?utf-8?Q?oyW6ARMeEVAHsOPxLVVXWUXlr?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 08a71160-5525-43b4-bcc3-08daa78eb778
X-MS-Exchange-CrossTenant-AuthSource: PH7PR12MB6588.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Oct 2022 11:34:23.5277
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: gpRKZ4Wn4WWqRTyW8OTeMyUDLXRYiOhtGPQ26pk7nhm54ZYDrEmzH57A63VQqy2HWxU2hrgjSORTIkcJbqoSMQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR12MB7372
X-Spam-Status: No, score=-3.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 06-Oct-22 3:40 PM, Leo Yan wrote:
> This commit introduces a shell script for data symbol testing.
> 
> The testing is designed a data structure with 64-byte alignment, it has
> two fields "data1" and "data2", and other fields are reserved.
> 
> Using "perf mem" command, we can record and report memory samples for a
> self-contained workload with 1 second duration.  If have no any memory
> sample for the data structure "buf1", it reports failure;  and by
> checking the offset in structure "buf1", if any memory accessing is not
> for "data1" and "data2" fields, it means wrong data symbol parsing and
> returns failure.
> 
> Signed-off-by: Leo Yan <leo.yan@linaro.org>
> ---
> 
> Changes from v4:
> - Remove the redundant argument "--" before CPU list (Namhyung).
>   This patch is dependent on the fixing:
>   https://lore.kernel.org/lkml/20221004200211.1444521-1-namhyung@kernel.org/

Thanks Leo.
Test passes on my AMD machine (with AMD perf mem/c2c patches applied):

$ sudo ./perf test -v 103
103: Test data symbol                                                :
--- start ---
test child forked, pid 18048
Compiling test program...
Recording workload...
[ perf record: Woken up 1 times to write data ]
[ perf record: Captured and wrote 1.569 MB /tmp/__perf_test.perf.data.1bDdJ (3064 samples) ]
Cleaning up files...
test child finished with 0
---- end ----
Test data symbol: Ok