Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 6 Oct 2022 09:21:24 -0400
From:   Brent Pappas <pappasbrent@knights.ucf.edu>
To:     Nam Cao <namcaov@gmail.com>
Cc:     "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
        "cai.huoqing@linux.dev" <cai.huoqing@linux.dev>,
        "kuba@kernel.org" <kuba@kernel.org>,
        "linux-staging@lists.linux.dev" <linux-staging@lists.linux.dev>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] staging: most: net: Replace macros HB and LB with static
 inline functions
Message-ID: <Yz7WVCzAviUYstX9@knights.ucf.edu>
References: <BN7PR07MB419563C5B405ED4082D7841DF65D9@BN7PR07MB4195.namprd07.prod.outlook.com>
 <20221005235728.GA118549@nam-dell>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20221005235728.GA118549@nam-dell>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WXIweDN3eW00ZjA4Ry9tRk4rMFQ5UnFwdEhZMVdkWVM1MHZJNWtLUlQzMkZj?=
 =?utf-8?B?S3ZrK1EvKy9QbUhvSHJCODhYa1ZWUE9JSmhNVnN1ZjYyd2poS0J4TDJnSHZs?=
 =?utf-8?B?WGtOVnJPZ0pQNVlRSkZVaWVkUFNCUDVobnA5NFc4WTJ1U3FwYnpRSTB0djBN?=
 =?utf-8?B?Z0RteDZ0SmgwWWloZktLMzZ2aE4xN0pJeHFFb2xGMmtSdnQrZjFwVTBVZ2lT?=
 =?utf-8?B?VUhmazIyRy9nV2RVZG5obDVwa3hWWFRTMWw4UXMweHJuQkdNTUNCU1E2VDNs?=
 =?utf-8?B?V1RSaGN2eHJqVkN1N1d5MUNQTU5Da24rRjZ2QUp6VTg1TTlUVGo0TkxSaDhv?=
 =?utf-8?B?MVNuRlU2MDlXVWZTMWE5VHB2UTJEc0VLdU1KUXp2WnVEdXB0aXZORGtORjBV?=
 =?utf-8?B?eEZQdGY3bWNjeFQyZTJSQm95ZUpjK3VTTmxFYUpSUFY4am50L2dOaEhxY0FF?=
 =?utf-8?B?N005dXlqbnpHcDIwbWhHQ0dGMHhkRGgvaUhXdkxUZ2lhQW5XdUZ0bEtwbjNB?=
 =?utf-8?B?c2lCdHQ3SG54RWI3TUFQY2kxTmo5VVN3YzFMK0Z1ODQ1N3l4cnhnL2xxc2xY?=
 =?utf-8?B?TUk2N1dtR0NOcWZObDZ2UDQxTzhua05yL0V4bTdsbE15ZFF5QjcyRmVrSG5S?=
 =?utf-8?B?SWxSWVVkUXprc3VVSDhjT3lQaWRxd1ZjR0kwTGFKZE9acUlDdi9TUmwvRDQ1?=
 =?utf-8?B?TEdFQ0IzbUp3ZWlpZEtMTkd6WE02Zi9vUjFLSCtyMWJmUVltdXFTKzEwbjZW?=
 =?utf-8?B?TlhUMENoem02bW9sNTZ2VGFLa1lPV25rV0xzMm1RV1V3N0JTQi9lSXBEY241?=
 =?utf-8?B?TGFaQzlNU1pIenhWc0tjTEM1NndJcmFMV0VzczVBdU1BKzVYaWNjNk12ekpG?=
 =?utf-8?B?U081b1ZhVzVvMWkybXJPQ3d4TURoazNXVHRtaHVDRlBZd2t4Q05xN0xjWFcz?=
 =?utf-8?B?Q2swZCtSZ2Z5WHBGejluVFFIMm5Cb2JUNGkrVm52R3NQV0lFL09ESVI3c0Va?=
 =?utf-8?B?VzRZVGpveHpGVWlVb1hsOWZGMXRxakhHMEVDMmtONC9XMnVnOFFCUTYyR0hv?=
 =?utf-8?B?c1Y4amtIYnp2anI1SFh4bk1ESG5iZzd6RnFDcHE4TDQ1enhWMURIVC9wbWZR?=
 =?utf-8?B?OTM2Uk9FRVNNVm9hVHhKVlNJSm44NXRpMUt1amkwTUxFYVBHYm94ejkrR1Zj?=
 =?utf-8?B?dklYVkkrUzBOT3FhaFFEYkk0RmdhZ21PZkFDV1hIbjFvK0FJQlM4UkRjSno2?=
 =?utf-8?B?c1FJNUQrL0cvUGw5RDQwQWdJd2VvaUMrTmUzSTdFQ2lZaW5zRHJQdkNTQUNu?=
 =?utf-8?B?Q1MvSHVsVER6b1lqSmFMWUZLb2M3ZUJzdjhMUENsTVk4ZmVjR1g0aVBSRy9M?=
 =?utf-8?B?V2R6UzdMQkZtcUM5VTc2UzIyL3I3T1BhcThCSFcwd0hzL2JUMk1BRkRoWUoy?=
 =?utf-8?B?KzZvRXRMQ25zVWpYWk9GZFVSU0kvbnM4M3VQWVNKSkFDTmtEUzZiSWFUL3Fw?=
 =?utf-8?B?MEtuVXZnQlNEVnBGR3pRcmdPRVc2QzU0VzBuMHUwRUpCUWZ0NE9QNEd2aDFw?=
 =?utf-8?B?eVRyYzI4WktscWwxMWJmTUdKbU9xNit3Q2hMU0FMWElHUkI1Rnk3cUtzendQ?=
 =?utf-8?B?NFllTS8vTXlyWVVvQUF5K3ViUkFIay9QOXdEbjI5Z2ZNenJWc3VCclFYSkhm?=
 =?utf-8?B?dysxTnBqVUYzd240aUdVTDNYUDMzZTJ3dU0rV2QzVE5qZ2diMjhCZTZkb0hT?=
 =?utf-8?B?TjhuWGhPVjdrNDNOeUpzdUhDZ0VSVVhKWCtkMXhSSDRpaWpEZHVzbnNlSDFt?=
 =?utf-8?B?bG1yWHBzd3o1REtTRWJuRDM2SGVsSlJ6VDFVOEN0MlNyMXFreFFwemYyZWlt?=
 =?utf-8?B?OEM3QTNqQmJZNzRJYUVpemc0dmtFM0RkeGU1ajBDU0RIMkxyeWU5NU9iVkQy?=
 =?utf-8?B?ZnVLdngxL0c4d3FSRkwrNlRaa2cvU3hwczdJRXBYSGI0eHFrNFZtSUpmL1pN?=
 =?utf-8?B?Y1NCbER5dUQ1VUZjK0VkeG4rMDZ6UFhhNUtUYlIxTGNCc3Z2aDFGVnV3eTBx?=
 =?utf-8?B?SUpxTlU3VWZ5ZDhibm9OQWdmMklNS3lVVU9yRzNrMXk0WmVGN2Y2bkR1RUx5?=
 =?utf-8?B?T1RHYitnNUJSVXU5SFFRc1FpRnJiWktmQUp1bnJpaHVpcjZtL2tSVEpaSndr?=
 =?utf-8?B?b3c9PQ==?=
X-OriginatorOrg: knights.ucf.edu
X-MS-Exchange-CrossTenant-Network-Message-Id: af991d3f-3f3b-4ef8-bf29-08daa79dac28
X-MS-Exchange-CrossTenant-AuthSource: BN7PR07MB4195.namprd07.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Oct 2022 13:21:26.9526
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 5b16e182-78b3-412c-9196-68342689eeb7
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: G7ePqmwzCEP32gc46N2aGlcaegqZS6UmFleuToKsTl1t1qEiwfvAI0v6gIROqjqo/VHg9Eofs2dZz+R1gd/2Lexn5jksOhUltcY0wjs5Zg0=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR07MB5606
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

The 10/05/2022 19:57, Nam Cao wrote:
> On Wed, Oct 05, 2022 at 04:10:44PM +0000, Brent Pappas wrote:
> > Replace function-like macros "HB" and "LB" with static inline functions
> > to comply with preferred Linux coding style standards.
> > 
> > Signed-off-by: Brent Pappas <pappasbrent@knights.ucf.edu>
> > ---
> > diff --git a/drivers/staging/most/net/net.c b/drivers/staging/most/net/net.c
> > index 1d1fe8bff7ee..8a8fbc274b73 100644
> > --- a/drivers/staging/most/net/net.c
> > +++ b/drivers/staging/most/net/net.c
> > @@ -36,8 +36,8 @@
> >  #define PMS_TELID_MASK         0x0F
> >  #define PMS_TELID_SHIFT                4
> >  
> > -#define HB(value)              ((u8)((u16)(value) >> 8))
> > -#define LB(value)              ((u8)(value))
> > +static inline u8 HB(unsigned int value)                { return ((u8)((u16)(value) >> 8)); }
> > +static inline u8 LB(unsigned int value)                { return ((u8)(value)); }
> >  
> >  #define EXTRACT_BIT_SET(bitset_name, value) \
> >         (((value) >> bitset_name##_SHIFT) & bitset_name##_MASK)
> 
> I cannot apply your patch. I think your email client modified some
> whitespace characters.
> 
> Check this for more information:
> https://nam02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.kernel.org%2Fdoc%2Fhtml%2Fv4.10%2Fprocess%2Femail-clients.html&amp;data=05%7C01%7Cpappasbrent%40knights.ucf.edu%7C3748a695ff1e438ecd0b08daa72d66bf%7C5b16e18278b3412c919668342689eeb7%7C0%7C0%7C638006110693613730%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&amp;sdata=rq2pgVr1dqT2k9hC21LXueqMeIcVyk2Qjvjl1KtkhsU%3D&amp;reserved=0
> 
> Best regards,
> Nam

I have followed your advice Nam and am now using an email cient that
leaves whitespace intact.

Should I reply to this post with the corrected diff, or would it
be better to submit a new patch with it?

Thank you again for taking the time to review.

Brent