Received: by 2002:a05:6359:c8b:b0:c7:702f:21d4 with SMTP id go11csp999637rwb; Thu, 6 Oct 2022 07:17:16 -0700 (PDT) X-Google-Smtp-Source: AMsMyM4kZtK8aIJZp3QbeiY5o7yl6K+uzvAh7ez7tQlUPOa0XUgE+X7oUdGHBVo8/30xEOBr6kNP X-Received: by 2002:a05:6a00:1ace:b0:546:94a3:b235 with SMTP id f14-20020a056a001ace00b0054694a3b235mr174723pfv.50.1665065835050; Thu, 06 Oct 2022 07:17:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1665065835; cv=none; d=google.com; s=arc-20160816; b=UKVlPENMVAt4Lj4GqLdyCXQfFRANMgos4ruXqgOAimnn4cBRJ/OtEN49MGX8X3V2mg 3ume5bf7PwwLJikR7KlU+nTNyjvff6q7ac7HhjHtI93Udscwu3ucLzTj+weoC6yhXoyn bA9aPbY9HvOI9MFDDgXjwPgvuSIiluMxdtD8WZgHnSlcpP7/4JIYt7qp9sXG8OV50iJS 6fvuwPBozOp1zVk9VS4z5RIZaabSEJR36ECaiutOeSdJj77B9sLd2T+U58ngVT6ox0du 3Bs9ohhEDayCpAcz5BL98y974uxsU94dp6rbHqyFAk7T2oRnSfOk+jfQKhjzaLGxu4Wg U4+A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=i9xV8IIhwnJwJ0EmJTzDn9e/52c+s9ftFvAegYJDNcA=; b=zwTTD1mVxL54Pd3SbtA4Q64rWqqMi0JC5UN7PBZvLrBd8mCz63bvpNUXTILex1e+0J 0J8a34R85BVhv6G7ZlK7Nr62HwfB1ODAG9oruP9EWz2p/sXurgCDCBvCbtcws2LhpR0W bWOTkZc0XnAMdC57Wj4ZqJNsjrkqvVBssRPmSXIbNswx4Aaf9XfBV5ekkmc05tg1qWhI PB2z53QyEQu/C8iUM9LYL9AwsGBI4mTRhdQlNdfwxOT9O/OmA3N6f5UL/my4cJGkinDL gOFihHZ4TQ0Byx+GXrfVRdEYN38nlxNZOJM4AbQ7GEiAeobFVmV9tovMK2mmS3L1Bi+W yPaA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id p6-20020a634206000000b0043ca0a1f7dasi20497470pga.674.2022.10.06.07.16.54; Thu, 06 Oct 2022 07:17:15 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230469AbiJFNya (ORCPT + 99 others); Thu, 6 Oct 2022 09:54:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56974 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230325AbiJFNx7 (ORCPT ); Thu, 6 Oct 2022 09:53:59 -0400 Received: from netrider.rowland.org (netrider.rowland.org [192.131.102.5]) by lindbergh.monkeyblade.net (Postfix) with SMTP id D4F8214D2F for ; Thu, 6 Oct 2022 06:53:58 -0700 (PDT) Received: (qmail 785392 invoked by uid 1000); 6 Oct 2022 09:53:58 -0400 Date: Thu, 6 Oct 2022 09:53:58 -0400 From: Alan Stern To: Vadym Kochan Cc: Greg Kroah-Hartman , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Elad Nachman , Yuval Shaia Subject: Re: [PATCH] usb: ehci-orion: Extend DMA mask to 64 bit for AC5 platform Message-ID: References: <20221006095257.6934-1-vadym.kochan@plvision.eu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221006095257.6934-1-vadym.kochan@plvision.eu> X-Spam-Status: No, score=-1.7 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,SPF_HELO_PASS,SPF_PASS autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Oct 06, 2022 at 12:52:57PM +0300, Vadym Kochan wrote: > From: Elad Nachman > > Signed-off-by: Elad Nachman > Signed-off-by: Vadym Kochan > --- > drivers/usb/host/ehci-orion.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/usb/host/ehci-orion.c b/drivers/usb/host/ehci-orion.c > index a3454a3ea4e0..c6205abebbdf 100644 > --- a/drivers/usb/host/ehci-orion.c > +++ b/drivers/usb/host/ehci-orion.c > @@ -230,7 +230,7 @@ static int ehci_orion_drv_probe(struct platform_device *pdev) > * set. Since shared usb code relies on it, set it here for > * now. Once we have dma capability bindings this can go away. > */ > - err = dma_coerce_mask_and_coherent(&pdev->dev, DMA_BIT_MASK(32)); > + err = dma_coerce_mask_and_coherent(&pdev->dev, DMA_BIT_MASK(64)); > if (err) > goto err; Apart from the fact that you didn't include a patch description, how come the Subject: line says this applies to the AC5 platform when the actual code change applies to all platforms? Do you know that this change is safe for all those other platforms? Alan Stern