Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <1664331299-4976-1-git-send-email-wangyufen@huawei.com>
In-Reply-To: <1664331299-4976-1-git-send-email-wangyufen@huawei.com>
From:   Akinobu Mita <akinobu.mita@gmail.com>
Date:   Thu, 6 Oct 2022 23:41:12 +0900
Message-ID: <CAC5umygFSZ1ho4nDn_8sjU4_tsi8Hu4bkw0m4g=n6UO0+=cz4A@mail.gmail.com>
Subject: Re: [-next RESEND] fault-injection: using debugfs_create_xul()
 instead of debugfs_create_xl()
To:     Wang Yufen <wangyufen@huawei.com>,
        Andrew Morton <akpm@linux-foundation.org>
Cc:     linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Andrew, could you consider picking up this patch?

2022=E5=B9=B49=E6=9C=8828=E6=97=A5(=E6=B0=B4) 10:54 Wang Yufen <wangyufen@h=
uawei.com>:
>
> Using debugfs_create_xul() instead of debugfs_create_xl(), and del the
> local define debugfs_create_xl().
>
> Suggested-by: Akinobu Mita <akinobu.mita@gmail.com>
> Signed-off-by: Wang Yufen <wangyufen@huawei.com>
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>

Reviewed-by: Akinobu Mita <akinobu.mita@gmail.com>

> ---
>  lib/fault-inject.c | 16 ++++------------
>  1 file changed, 4 insertions(+), 12 deletions(-)
>
> diff --git a/lib/fault-inject.c b/lib/fault-inject.c
> index 9dd1dd1..dbb5409 100644
> --- a/lib/fault-inject.c
> +++ b/lib/fault-inject.c
> @@ -185,14 +185,6 @@ static void debugfs_create_ul(const char *name, umod=
e_t mode,
>
>  #ifdef CONFIG_FAULT_INJECTION_STACKTRACE_FILTER
>
> -DEFINE_SIMPLE_ATTRIBUTE(fops_xl, debugfs_ul_get, debugfs_ul_set, "0x%llx=
\n");
> -
> -static void debugfs_create_xl(const char *name, umode_t mode,
> -                             struct dentry *parent, unsigned long *value=
)
> -{
> -       debugfs_create_file(name, mode, parent, value, &fops_xl);
> -}
> -
>  static int debugfs_stacktrace_depth_set(void *data, u64 val)
>  {
>         *(unsigned long *)data =3D
> @@ -237,10 +229,10 @@ struct dentry *fault_create_debugfs_attr(const char=
 *name,
>  #ifdef CONFIG_FAULT_INJECTION_STACKTRACE_FILTER
>         debugfs_create_stacktrace_depth("stacktrace-depth", mode, dir,
>                                         &attr->stacktrace_depth);
> -       debugfs_create_xl("require-start", mode, dir, &attr->require_star=
t);
> -       debugfs_create_xl("require-end", mode, dir, &attr->require_end);
> -       debugfs_create_xl("reject-start", mode, dir, &attr->reject_start)=
;
> -       debugfs_create_xl("reject-end", mode, dir, &attr->reject_end);
> +       debugfs_create_xul("require-start", mode, dir, &attr->require_sta=
rt);
> +       debugfs_create_xul("require-end", mode, dir, &attr->require_end);
> +       debugfs_create_xul("reject-start", mode, dir, &attr->reject_start=
);
> +       debugfs_create_xul("reject-end", mode, dir, &attr->reject_end);
>  #endif /* CONFIG_FAULT_INJECTION_STACKTRACE_FILTER */
>
>         attr->dname =3D dget(dir);
> --
> 1.8.3.1
>