Received: by 2002:a05:6359:c8b:b0:c7:702f:21d4 with SMTP id go11csp1088153rwb; Thu, 6 Oct 2022 08:18:31 -0700 (PDT) X-Google-Smtp-Source: AMsMyM6arulk2Ij4iF91+V4UEy4Iw5efzwOoWAyMydoS/bnIPEsvJ5ds5omIaFJFlAQvAOhvJSX0 X-Received: by 2002:a17:907:8a04:b0:782:5277:2bac with SMTP id sc4-20020a1709078a0400b0078252772bacmr335422ejc.128.1665069511106; Thu, 06 Oct 2022 08:18:31 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1665069511; cv=none; d=google.com; s=arc-20160816; b=vnJ8dGcPjbnDL+5J7umpQF2dq03FIAQX6CHd8ya+7A+QQgCSJok/tsGKmuFJpX2pRw yL2iJA2Lpe9G316YpUpdm8315iLX4VhQ7ZJUJd+hU/8gLymY29c0M93fuwE8IAT4HPfB DM+1Jq7yURgwSTUwUicYdBAnYJgyDlDisQ7lg3wFhCuMm9mfqTyFF0xVEjDHIEG7AQuI seNj05g7A6UrpwerCF7FFmjkWXFEi/ZrUeZc+WhKH2mg672wlbOfLWJ49gknbvWAc1+J zibP3UXy0BTaLyEeqPCxk/PrbNPFLXI9Klf1HFXInyZqwdKysEGOBoj3VtAp8DiBY8jY MkxQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=MDzPc+gslB3lFJVHCDL7oB438br41NbH0vrN2nPdfp8=; b=0VEycD9VzBsO0iVewtt/bHUR47V6kXinQCjO/ohz0+vwDuNXp6NDu3s/MptKeognmP 9/0u2d2t1Vv5BYRP9cc397mh3ulENvddGV9nkEEEHp9lwDMDR4iHnUvdaVISTWBsCqR/ jSMz5v2vrNV2DVhCcXCpGTewlG+/UlXJQcyoZ9gAwYcz+et1SqJnXAtLTL5r1oOMBZJd +dJG09nOk5A7gFJsyTIqPbQo1TOS/CMCG0Zts42+Ln93bNDq7AfeDCzzfelzXvXeIZY4 Nz8u20zcIBpZfhyKrm6gd1mKeEPJONnSOn1+zwE6+q3OzLw2rd0KlAyvo2q0gWnsa6L3 JMAQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=RTvYqVsG; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id i10-20020a1709064fca00b006fe95bb93b3si18680947ejw.861.2022.10.06.08.18.04; Thu, 06 Oct 2022 08:18:31 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=RTvYqVsG; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231612AbiJFPGz (ORCPT + 99 others); Thu, 6 Oct 2022 11:06:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33060 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229912AbiJFPGx (ORCPT ); Thu, 6 Oct 2022 11:06:53 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 42F6C88DE2; Thu, 6 Oct 2022 08:06:53 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id D20FD619EC; Thu, 6 Oct 2022 15:06:52 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id F3666C433D6; Thu, 6 Oct 2022 15:06:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1665068812; bh=MDzPc+gslB3lFJVHCDL7oB438br41NbH0vrN2nPdfp8=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=RTvYqVsGUc+07tdnYX2as73+3v0myn5rZPOURR3R+8XEUkkzASdWujqgKKRwU4ojj +65u3fWZBADWcaT0PnHEylFcSEHivWSKmb2UyYeoDDd0TRNF7wXaQdj+A0Mv6fSqai a+UqEY9NbI0LWQzU0/cVI5Sl5eO0MIyfJtO+jOTUl6EkruQ2ZLzF3lhbeywhiqBhZ/ FojeGJ0s+bSYIpKDx3fGtIb8CbJPivs7dcz/w8Gvor9cZPCkEyiNu5PTi/wCqU6Akj MhN/lb29PDB2ES+KV6f3+2fn5hdRhxTP1mlYxSSY/5nC4k2zXnWvfSbkhMbv9ZJWQw JrglYw4Xe0ogw== Date: Thu, 6 Oct 2022 08:06:51 -0700 From: Jakub Kicinski To: LABBE Corentin Cc: davem@davemloft.net, edumazet@google.com, khalasa@piap.pl, pabeni@redhat.com, linux-kernel@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [PATCH 1/4] net: ethernet: xscale: fix space style issues Message-ID: <20221006080651.6cc91dd7@kernel.org> In-Reply-To: References: <20221005120501.3527435-1-clabbe@baylibre.com> <20221005203545.48531d8e@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 6 Oct 2022 06:40:31 +0200 LABBE Corentin wrote: > The difference with classic checkpatch is that I have tested it. If you make some material changes to the driver I'd reconsider, otherwise I'd strongly prefer to stick to the general policy. > And the patch #2 fixes the bad netdev_debug(). Please isolate that from the noise and send it separately (after net-next opens).