Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 6 Oct 2022 11:07:41 -0500
From:   Bjorn Helgaas <helgaas@kernel.org>
To:     Lorenzo Pieralisi <lpieralisi@kernel.org>
Cc:     Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>,
        kw@linux.com, bhelgaas@google.com, linux-pci@vger.kernel.org,
        robh@kernel.org, linux-arm-msm@vger.kernel.org,
        linux-kernel@vger.kernel.org, kernel test robot <lkp@intel.com>
Subject: Re: [PATCH] PCI: qcom-ep: Fix disabling global_irq in error path
Message-ID: <20221006160741.GA2470032@bhelgaas>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <Yz53NnxEkS7hg8Vc@lpieralisi>
Precedence: bulk

On Thu, Oct 06, 2022 at 08:35:34AM +0200, Lorenzo Pieralisi wrote:
> On Wed, Oct 05, 2022 at 12:35:29PM -0500, Bjorn Helgaas wrote:
> > On Wed, Oct 05, 2022 at 07:28:52PM +0530, Manivannan Sadhasivam wrote:
> > > After commit 6a534df3da88 ("PCI: qcom-ep: Disable IRQs during driver
> > > remove"), the global irq is stored in the "global_irq" member of pcie_ep
> > > structure. This eliminates the need of local "irq" variable but that
> > > commit didn't remove the "irq" variable usage completely and it is still
> > > used for disable_irq() in error path which is wrong since the variable is
> > > uninitialized.
> > > 
> > > Fix this by removing the local "irq" variable and using
> > > "pcie_ep->global_irq" for disable_irq() in error path.
> > > 
> > > Reported-by: kernel test robot <lkp@intel.com>
> > > Fixes: 6a534df3da88 ("PCI: qcom-ep: Disable IRQs during driver remove")
> > > Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
> > 
> > For today's "next" branch, I dropped 6a534df3da88 and the subsequent
> > patches.  Hopefully Lorenzo can squash this fix into 6a534df3da88.
> 
> Done - the pci/qcom branch successfully passed kbot's tests as well.

Thanks, picked this up yesterday :)

Bjorn