Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Received-SPF: Pass (protection.outlook.com: domain of amd.com designates
 165.204.84.17 as permitted sender) receiver=protection.outlook.com;
 client-ip=165.204.84.17; helo=SATLEXMB03.amd.com; pr=C
Message-ID: <e04c498e-c3f5-9b0f-14cf-56057dd77d4e@amd.com>
Date:   Thu, 6 Oct 2022 10:42:44 -0700
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.11.0
Subject: Re: [PATCH V6 XDMA 0/2] xilinx XDMA driver
Content-Language: en-US
To:     =?UTF-8?Q?Martin_T=c5=afma?= <tumic@gpxsee.org>,
        <vkoul@kernel.org>, <dmaengine@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <trix@redhat.com>
CC:     <max.zhen@amd.com>, <sonal.santan@amd.com>, <larry.liu@amd.com>,
        <brian.xu@amd.com>
References: <1664919839-27149-1-git-send-email-lizhi.hou@amd.com>
 <4e4481e9-0eb9-ac28-b9ff-348adb4dc866@gpxsee.org>
From:   Lizhi Hou <lizhi.hou@amd.com>
In-Reply-To: <4e4481e9-0eb9-ac28-b9ff-348adb4dc866@gpxsee.org>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 8bit
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Oct 2022 17:42:46.1586
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: eb2a5daa-24f1-4e8b-eca6-08daa7c22dea
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB03.amd.com]
X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT034.eop-nam11.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA0PR12MB7602
X-Spam-Status: No, score=-3.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 10/6/22 09:37, Martin Tůma wrote:
> On 04. 10. 22 23:43, Lizhi Hou wrote:
>> Hello,
>>
>> This V6 of patch series is to provide the platform driver to support the
>> Xilinx XDMA subsystem. The XDMA subsystem is used in conjunction with 
>> the
>> PCI Express IP block to provide high performance data transfer 
>> between host
>> memory and the card's DMA subsystem. It also provides up to 16 user
>> interrupt wires to user logic that generate interrupts to the host.
>>
>>              +-------+       +-------+       +-----------+
>>     PCIe     |       |       |       |       |           |
>>     Tx/Rx    |       |       |       |  AXI  |           |
>>   <=======>  | PCIE  | <===> | XDMA  | <====>| User Logic|
>>              |       |       |       |       |           |
>>              +-------+       +-------+       +-----------+
>>
>> The XDMA has been used for Xilinx Alveo PCIe devices.
>> And it is also integrated into Versal ACAP DMA and Bridge Subsystem.
>>      https://www.xilinx.com/products/boards-and-kits/alveo.html
>> https://docs.xilinx.com/r/en-US/pg344-pcie-dma-versal/Introduction-to-the-DMA-and-Bridge-Subsystems
>>
>> The device driver for any FPGA based PCIe device which leverages XDMA 
>> can
>> call the standard dmaengine APIs to discover and use the XDMA subsystem
>> without duplicating the XDMA driver code in its own driver.
>>
>> Changes since v5:
>> - Modified user logic interrupt APIs to handle user logic IP which 
>> does not
>>    have its own register to enable/disable interrupt.
>> - Clean up code based on review comments.
>>
>> Changes since v4:
>> - Modified user logic interrupt APIs.
>>
>> Changes since v3:
>> - Added one patch to support user logic interrupt.
>>
>> Changes since v2:
>> - Removed tasklet.
>> - Fixed regression bug introduced to V2.
>> - Test Robot warning.
>>
>> Changes since v1:
>> - Moved filling hardware descriptor to xdma_prep_device_sg().
>> - Changed hardware descriptor enum to "struct xdma_hw_desc".
>> - Minor changes from code review comments.
>>
>> Lizhi Hou (2):
>>    dmaengine: xilinx: xdma: Add xilinx xdma driver
>>    dmaengine: xilinx: xdma: Add user logic interrupt support
>>
>>   MAINTAINERS                            |   11 +
>>   drivers/dma/Kconfig                    |   13 +
>>   drivers/dma/xilinx/Makefile            |    1 +
>>   drivers/dma/xilinx/xdma-regs.h         |  171 ++++
>>   drivers/dma/xilinx/xdma.c              | 1034 ++++++++++++++++++++++++
>>   include/linux/dma/amd_xdma.h           |   16 +
>>   include/linux/platform_data/amd_xdma.h |   34 +
>>   7 files changed, 1280 insertions(+)
>>   create mode 100644 drivers/dma/xilinx/xdma-regs.h
>>   create mode 100644 drivers/dma/xilinx/xdma.c
>>   create mode 100644 include/linux/dma/amd_xdma.h
>>   create mode 100644 include/linux/platform_data/amd_xdma.h
>>
>
> Hi,
> I have rewritten our V4L2 driver to use this new XDMA driver, but it 
> does not work on our HW (where the previous Xilinx XDMA driver derived 
> from the Xilinx sample code worked fine). The driver is sucessfully 
> loaded and 4(2+2) DMA channels are successfully created. But when a 
> DMA transfer is initiated, I get an error from my PC's DMA chip:
>
> AMD-Vi: Event logged [IO_PAGE_FAULT domain=0x000a address=0x36a00000 
> flags=0x0000]
>
> and no error from XDMA.
>
> Does the driver expect some special FPGA IP core configuration? Or is 
> there something else I'm missing? My code is quiet similar to what you 
> use in your XRT repo on GitHub (there is btw. a bug in the XRT code - 
> you do not clear the dma_slave_config struct before using) but in my 
> case the DMA transfer triggers the AMD-Vi error and timeouts.
>
> The code of our driver is attached, the relevant parts are in mgb4_dma.c
> and mgb4_core.c.
>
> M.

Hi Martin,

Thanks for trying this and got a lot thing works. I have read your 
driver. Could you call pci_map_sg() before calling prep_sg()? (and 
pci_unmap_sg()) after transfer complete?

example: 
https://github.com/houlz0507/XRT-1/blob/xdma_v4_usage/src/runtime_src/core/pcie/driver/linux/xocl/subdev/xdma.c#L103


Thanks,

Lizhi