Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Feedback-ID: i68a1478a:Fastmail
Date:   Thu, 6 Oct 2022 15:26:56 -0500
From:   Patrick Williams <patrick@stwcx.xyz>
To:     Michael Walle <michael@walle.cc>,
        Potin Lai <potin.lai@quantatw.com>
Cc:     Delphine CC Chiu <Delphine_CC_Chiu@wiwynn.com>,
        ~sircmpwn/email-test-drive@lists.sr.ht, garnermic@fb.com,
        Tudor Ambarus <tudor.ambarus@microchip.com>,
        Pratyush Yadav <pratyush@kernel.org>,
        Miquel Raynal <miquel.raynal@bootlin.com>,
        Richard Weinberger <richard@nod.at>,
        Vignesh Raghavendra <vigneshr@ti.com>,
        linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mtd: spi-nor: winbond: add support for w25q01jv-im
Message-ID: <Yz86ECK3pRyJjAo5@heinlein>
References: <20221006070841.2106194-1-Delphine_CC_Chiu@Wiwynn.com>
 <0dde4fa6ddeefa23314dbdcd1dd1b28b@walle.cc>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="L+AQa5HFPPMOr8/v"
Content-Disposition: inline
In-Reply-To: <0dde4fa6ddeefa23314dbdcd1dd1b28b@walle.cc>
Precedence: bulk


--L+AQa5HFPPMOr8/v
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Thu, Oct 06, 2022 at 01:52:33PM +0200, Michael Walle wrote:
> Hi,
>=20
> Am 2022-10-06 09:08, schrieb Delphine CC Chiu:
> > Add support for winbond w25q01jv-im chip.
> >=20
> > Signed-off-by: Delphine CC Chiu <Delphine_CC_Chiu@Wiwynn.com>
> > ---
> >  drivers/mtd/spi-nor/winbond.c | 3 +++
> >  1 file changed, 3 insertions(+)
> >=20
> > diff --git a/drivers/mtd/spi-nor/winbond.c=20
> > b/drivers/mtd/spi-nor/winbond.c
> > index ffaa24055259..2b02b05ceb0a 100644
> > --- a/drivers/mtd/spi-nor/winbond.c
> > +++ b/drivers/mtd/spi-nor/winbond.c
> > @@ -139,6 +139,9 @@ static const struct flash_info winbond_nor_parts[]=
=20
> > =3D {
> >  	{ "w25q512jvq", INFO(0xef4020, 0, 64 * 1024, 1024)
> >  		NO_SFDP_FLAGS(SECT_4K | SPI_NOR_DUAL_READ |
> >  			      SPI_NOR_QUAD_READ) },
> > +	{ "w25q01jv-im", INFO(0xef7021, 0, 64 * 1024, 2048)
>=20
> The name should be w25q01jvm.
>=20
> > +		NO_SFDP_FLAGS(SECT_4K | SPI_NOR_DUAL_READ |
> > +			      SPI_NOR_QUAD_READ) },
>=20
> That flash should support SFDP, so please try the following:
> +	{ "w25q01jvm", INFO(0xef7021, 0, 0, 0) PARSE_SFDP },
>=20
> Also, we require an SFDP dump for new flash submissions, see [1].
>=20
> -michael
>=20
> [1]=20
> https://lore.kernel.org/linux-mtd/4304e19f3399a0a6e856119d01ccabe0@walle.=
cc/

It looks like this was already attempted to be added:

https://lore.kernel.org/all/20220222085148.21594-1-potin.lai@quantatw.com/

Potin, do you have an update?

--=20
Patrick Williams

--L+AQa5HFPPMOr8/v
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEEBGD9ii4LE9cNbqJBqwNHzC0AwRkFAmM/Og4ACgkQqwNHzC0A
wRnafA/+NMv98UWc9p5+yhEAkMiT7KoYEODS+j/IJFnkAO/mhqQXRKpOi+lu9y/m
qVWP0wKzFxlTlCuDpx3GqRgR8u2q5XrWw8FODEd1GjjCm31GQO+6Dk5/GB39rpWW
KKfGBoXTl613No3K0oB93ZlA9mPL16ZRli7pulrCugND62VfAqqhRBfuPkRG6zhj
o92osIFJg8uTa7uUs0SfqRoW/YGDfhj4zLzPabrnWEiYeJ6InVl0KCWzIHrYSgYa
3cK0n+zLRkZ445OW50LsCuoqTQ4VbmKP5sKHvBETZLiSuWGA8cZt9GeZXZXN67Jb
7TjRPvzY51l4I7VAWDFIvo+TifETbZ9TGcoxvYqdX3hLqcxJuPHoFiwJq556jYWp
GJiROykvfOC/Vny/vhkPv/CcAFtbBOFYO3T3zgMWjlhVcjl5AHEKHJZJtB44qy2V
vR4e+kK/RM3ONrEKE/sOpAVgj7gReBWIHoW6GIRXU0TdljsRzJOFeVb45bTgAM4T
ap4lqiJQ6VZwtJ/XrgjvRojKOv/NBvqSH7bgBr5hxfaL3mZrN7/cvKswrSNFPjsG
EJK6rg9mu7UgbpiuN6n12/LhXQq4Iash1uZHX8nngvXRgQmJOiMX8FcIRxmPcn6I
aOMClErigDGCILguFGDWqCb7yfT5hlf7k5TwF6CvFgX4OgMR6cE=
=OlUA
-----END PGP SIGNATURE-----

--L+AQa5HFPPMOr8/v--