Received: by 2002:a05:6359:c8b:b0:c7:702f:21d4 with SMTP id go11csp52027rwb; Thu, 6 Oct 2022 14:22:51 -0700 (PDT) X-Google-Smtp-Source: AMsMyM7B4++1V78iMISSj0ucWvK4WNdn01+s6jlwJKj1SrWLtx6Jj/GqBzRWRq/XBHkyNwH1dK8q X-Received: by 2002:a17:90a:29e4:b0:20a:f9d5:c10e with SMTP id h91-20020a17090a29e400b0020af9d5c10emr8262637pjd.132.1665091371135; Thu, 06 Oct 2022 14:22:51 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1665091371; cv=none; d=google.com; s=arc-20160816; b=M0tk79rZljooQObih+cLGf4YAD5jkXOIbB5qnGmD2gDXwvzjamUa5j3aZeh9JFeAFN ye2JsqNMLPEnXbjiz8IcG/xhFr7d1GPE/mhvb4I93xKYfbWADSrLkFcOhlHwc6TLauqH i5xAwSfTmcI96QEvkwuA8OVLfUIJ8hKYGhzXI3Xq+1m1/UKk3oRTG59WGBUz2K4Rh4Ge BCoqLXPjjiWmrTLY1LYGmapkZuRyMGEDQAMvXHezv8eKahp91970mlsnJbY1B7uDv6jD gt7R82ckKhyDAcPvGVpBmlb38YpTBQwiecHiUWvwCgqgodF+4/facWsgYVnQ9qKqDw2d Q8Jw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=0PbsxfciFypoBGS4ctUovIgysMm8UsOS2BI0DhFX6xc=; b=r7hoTRh4k1XklmMDs92ME7Irsnb/ZRfF+PONpxeDzEidvBWZA7eqmDm15GKL2QG+rM CS9L5wclz87anZIaVK2/xbed62DwUobtuNCjYxQbj2wyqCOygVpluR1kcyoZ2/vukPlM G0nxEmIlv6QQtMM1U72djWTdKUEkUGlOFTVSgg6091tOtOHTCV2dYylh+OfoPvUGDtx5 XD1SeV8/3lCdMloJfVDc72uJEad4KpFY9HN2SjSBWjFnYwYB5NCAZ44Lf1asEoGPqba6 qVhQru9nZb5JJCVJ0Mhy5bgKmVwF5LsehJvoehnlFluVGw8rl21ng1QmOY3egChkOUwp DKSw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=BURM6NKu; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id z14-20020a630a4e000000b00439753f7df9si532885pgk.667.2022.10.06.14.22.35; Thu, 06 Oct 2022 14:22:51 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=BURM6NKu; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232055AbiJFVHS (ORCPT + 99 others); Thu, 6 Oct 2022 17:07:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57358 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232023AbiJFVHN (ORCPT ); Thu, 6 Oct 2022 17:07:13 -0400 Received: from mail-il1-x12a.google.com (mail-il1-x12a.google.com [IPv6:2607:f8b0:4864:20::12a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A4D21C4C1A for ; Thu, 6 Oct 2022 14:07:12 -0700 (PDT) Received: by mail-il1-x12a.google.com with SMTP id r20so1616080ilt.11 for ; Thu, 06 Oct 2022 14:07:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date; bh=0PbsxfciFypoBGS4ctUovIgysMm8UsOS2BI0DhFX6xc=; b=BURM6NKuHyGNwu73ErzY1IO5UhtEJ6qv2bms7GkMQuuPgH37yN36JHOZqoTkdFEHav k5zlInrR7SE9RmS/PGnYy4KhnY4FGkt2OY6NN5iW/Hnj8bzR1WDZg/0r3QDxG3J2xdya A28KiVaODjXBuZDv6WkbcH8IzcQhnOmG7if/RVocKv9Iq+NMdX8AKNoGeq1b5Yc2cfZD 2y38oyNKBP7nKc9/+ayzZwt7num14g3g0TMZHSfpdzlYHqRfjpWXB01+bSuVZ4q/Uim/ Ng68XKx0mtBa1DEJujJubaS2eEXQcVGAiwyWzbTHf81odUXbR7AOMM4ZnQBkhDKxwIML 8uZg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date; bh=0PbsxfciFypoBGS4ctUovIgysMm8UsOS2BI0DhFX6xc=; b=yQBEyoJVcGSyqYGH8AAJRTKlrGGuHrjwGfHKF6/CNuo/1unAAX19t9/ymUKIAMBrI7 eEtvjXQKwDsZDkRy8lVRM3nuiWBk0inLeRfd1i1SJwXvrD3b2TFGs7/erp5HiFlzkPWS GvqIJw/nKucP21CUtsoNVIbFVnsxh71rHWp8H1974BYqcP7mjvgBOLB06fqGrbUS+hbR OzvJVvPRa41RMhNB477ruuzKWkzwcStiPOiWUbNjNtz3EmEnUtu0SgIt/o1QUMFTq++4 Q0da5VU5xJRSj5yO2+axH1hMNHxA6MdNH2F7YHq63LystaTE88E2+SNIBhw6kMG57sS0 eE/Q== X-Gm-Message-State: ACrzQf1fex8NXdydKuljiREmnd0ZiSuSb03OwInxisAg4AOHXobPgUQh qpmQoQHYowgz9x4rCz+Arvs0mCkuoDtwKHvxs/0= X-Received: by 2002:a05:6e02:b2d:b0:2f9:e735:a010 with SMTP id e13-20020a056e020b2d00b002f9e735a010mr740919ilu.151.1665090431878; Thu, 06 Oct 2022 14:07:11 -0700 (PDT) MIME-Version: 1.0 References: <20221006092042.1753-1-wangdeming@inspur.com> In-Reply-To: <20221006092042.1753-1-wangdeming@inspur.com> From: Miguel Ojeda Date: Thu, 6 Oct 2022 23:07:00 +0200 Message-ID: Subject: Re: [PATCH] kallsyms: add required space for unified style To: Deming Wang Cc: keescook@chromium.org, boqun.feng@gmail.com, gregkh@linuxfoundation.org, ojeda@kernel.org, masahiroy@kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Oct 6, 2022 at 11:22 AM Deming Wang wrote: > > add required space before and after operators. There are some other instances, like `i+1`, `*result=0;`, `total=0`... that could be fixed too. One way to find them is `clang-format -i` + `git add --patch` :) That will also show you other different formatting issues, like a couple `if (...) ...;` in a single line, `if(` without space, etc. Cheers, Miguel