Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Feedback-ID: i68a1478a:Fastmail
Date:   Thu, 6 Oct 2022 15:40:48 -0500
From:   Patrick Williams <patrick@stwcx.xyz>
To:     Michael Walle <michael@walle.cc>
Cc:     Delphine CC Chiu <Delphine_CC_Chiu@wiwynn.com>,
        ~sircmpwn/email-test-drive@lists.sr.ht, garnermic@fb.com,
        Tudor Ambarus <tudor.ambarus@microchip.com>,
        Pratyush Yadav <pratyush@kernel.org>,
        Miquel Raynal <miquel.raynal@bootlin.com>,
        Richard Weinberger <richard@nod.at>,
        Vignesh Raghavendra <vigneshr@ti.com>,
        linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org,
        Potin Lai <potin.lai@quantatw.com>
Subject: Re: [PATCH] mtd: spi-nor: winbond: add support for w25q01jv-im
Message-ID: <Yz89UJsFJBMaTxuy@heinlein>
References: <20221006070841.2106194-1-Delphine_CC_Chiu@Wiwynn.com>
 <0dde4fa6ddeefa23314dbdcd1dd1b28b@walle.cc>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="pjTEFctmrz8zr3LU"
Content-Disposition: inline
In-Reply-To: <0dde4fa6ddeefa23314dbdcd1dd1b28b@walle.cc>
Precedence: bulk


--pjTEFctmrz8zr3LU
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Thu, Oct 06, 2022 at 01:52:33PM +0200, Michael Walle wrote:
> Hi,
>=20
> Am 2022-10-06 09:08, schrieb Delphine CC Chiu:
> > Add support for winbond w25q01jv-im chip.
> >=20
> > Signed-off-by: Delphine CC Chiu <Delphine_CC_Chiu@Wiwynn.com>
> > ---
> >  drivers/mtd/spi-nor/winbond.c | 3 +++
> >  1 file changed, 3 insertions(+)
> >=20
> > diff --git a/drivers/mtd/spi-nor/winbond.c=20
> > b/drivers/mtd/spi-nor/winbond.c
> > index ffaa24055259..2b02b05ceb0a 100644
> > --- a/drivers/mtd/spi-nor/winbond.c
> > +++ b/drivers/mtd/spi-nor/winbond.c
> > @@ -139,6 +139,9 @@ static const struct flash_info winbond_nor_parts[]=
=20
> > =3D {
> >  	{ "w25q512jvq", INFO(0xef4020, 0, 64 * 1024, 1024)
> >  		NO_SFDP_FLAGS(SECT_4K | SPI_NOR_DUAL_READ |
> >  			      SPI_NOR_QUAD_READ) },
> > +	{ "w25q01jv-im", INFO(0xef7021, 0, 64 * 1024, 2048)
>=20
> The name should be w25q01jvm.
>=20
> > +		NO_SFDP_FLAGS(SECT_4K | SPI_NOR_DUAL_READ |
> > +			      SPI_NOR_QUAD_READ) },
>=20
> That flash should support SFDP, so please try the following:
> +	{ "w25q01jvm", INFO(0xef7021, 0, 0, 0) PARSE_SFDP },

It seems like QEMU doesn't support SFDP yet.  Is using PARSE_SFDP a hard
requirement or can we delay until the QEMU support can be written?

--=20
Patrick Williams

--pjTEFctmrz8zr3LU
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEEBGD9ii4LE9cNbqJBqwNHzC0AwRkFAmM/PU4ACgkQqwNHzC0A
wRmpJw/+Np3IEKkaJrHkeGBaf2O57oTxLMumWGxDCWV/tu3k6J9K6k7T5opE6zBA
DHkPs7pnvSsZoGHXQYo179cNsSfX1qgOIBPiLAo0PyI0CgW73GSWt3kRlafJv38l
bb9j/vr+uXb8+k62npuX+9iM04gcRU4geAj9gVYnMHmVkUr9Ma/33vGHrkfM3sLk
c3OHdZG+cvsVTRJiatoSyrHm+S+yvkMVH7Ztw8z9WTH4/ANi26CsggapMUYANc8T
5Aa7Jtbasx2I7xTboNkioKe4Ah9O4EmwKoohChuK9mwlFI1zBFltzjjVVOkc0gfm
pMzsmz9PQriatqEAB4je+SHd4WSoDs3t3iKWReFx2rOAjUM8CRZATqAtWrv/1HUL
K/4T6wXMgLLrMU5t3bIyncHS30KiFpq76ZRq6MNicf0De1C+HBoJjSWlBSlvJ8VN
dXCBhIvzpc3nq62Mab1lWwyTn5ggTD8ZHXjr24lg2E5i44NMUMACrv/Br5osOihH
QqDmY0hAAIyggxMR90f799lsVfL4iVtovwKXi7Ud+2z1OlPZiJ2vX6Q8udxvXVVP
tIgWHecZ9d1/ZLLGoipYzGxYgoR+9EI1vYGhTJt+EvAWyG6DAs1bS3XThASli6j7
yVetrfPHlLT8rYMYvqXOd0TH12YoINOZnOs9qrn7qxkWtWxKX8o=
=f5UJ
-----END PGP SIGNATURE-----

--pjTEFctmrz8zr3LU--