Received: by 2002:a05:6359:c8b:b0:c7:702f:21d4 with SMTP id go11csp114509rwb; Thu, 6 Oct 2022 15:28:27 -0700 (PDT) X-Google-Smtp-Source: AMsMyM7H07+EwPhsdGGOalBwhHG4S09xDH5ANunRWdYf5zAj9XXgQsGs+Uw3kxs9wh8LVy3/LmgX X-Received: by 2002:a17:90b:4f45:b0:203:1cf4:6a54 with SMTP id pj5-20020a17090b4f4500b002031cf46a54mr12848109pjb.235.1665095307697; Thu, 06 Oct 2022 15:28:27 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1665095307; cv=none; d=google.com; s=arc-20160816; b=P9W+m/8jSOziAvzOCVP3H7dNsKRKTxaXAZDvhNr2Z7Z9zN6O4QcA7oyhv3Ecz4j5ZZ vstxyQXhbWVMypCGqlpR7qwJhVpVBeQsRPRtIumlxVU44N4tdwTdnGu8hgwoBi1+lZ+M nZhAiGBPzY58790GUGNInKAb7kC1FgAAIAG0CmJox0gqdQ1RgMP20ytxRViboIGi9swL Mzx5qd6mKA7lP0XZcnrjdMNPxvt+W8aFWDis51mHHgp453RFy8xMBqGxcD+RvrJiBX5L vrEzp4Lzp0U1NVbe1yrFEz/ld6ypxyOX39ElqdwSvy8qhNWPsO8vMCFbiRcKNvZzeQxe T7dw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=IKYUboxuiUIaVRLX9+Ls9Ayah1lDyM2CjdHPVn2SJhY=; b=N7JeKR+WkoWHRFKmsNXuJhmNXqZq/xJCjdYVYvlrn5ciJnw/GYEktjLY/WmAqO1UIT KsYpx3duOVZPDDald0efgagTxcvjspg/aNQVZSj7bUJGDIrknkKzzmqZLa8J99UlxFNT XgkjyiBnIoiHs2QKuZmdnAeFlBhUkU2tqRBsn62FOnEhrAx6F8XgNwHXVtjb17vx9T/Z 7eqVhVP/2Q47aFeRzm4nOG10rRIORrBKtr0RvXKaW3pDORv+uY7HzKM1utZTiMH9OUmq g5piW88a3Sg0vGGmgseeqFTPltMArJZPdd8hxIWnA5ZeiHCyfxVJmkJxlaLongg/9R59 SyRQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@comcastmailservice.net header.s=20211018a header.b=pS92lRNt; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linux.dev Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id h11-20020a056a001a4b00b0053712acc6e0si319181pfv.246.2022.10.06.15.28.14; Thu, 06 Oct 2022 15:28:26 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@comcastmailservice.net header.s=20211018a header.b=pS92lRNt; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linux.dev Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232168AbiJFWJR (ORCPT + 99 others); Thu, 6 Oct 2022 18:09:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36542 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231793AbiJFWJO (ORCPT ); Thu, 6 Oct 2022 18:09:14 -0400 Received: from resqmta-h1p-028593.sys.comcast.net (resqmta-h1p-028593.sys.comcast.net [IPv6:2001:558:fd02:2446::7]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5DFDAABF17 for ; Thu, 6 Oct 2022 15:09:11 -0700 (PDT) Received: from resomta-h1p-028434.sys.comcast.net ([96.102.179.205]) by resqmta-h1p-028593.sys.comcast.net with ESMTP id gVlMoYu4LrhuigZ3Foqf4F; Thu, 06 Oct 2022 22:09:09 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=comcastmailservice.net; s=20211018a; t=1665094149; bh=IKYUboxuiUIaVRLX9+Ls9Ayah1lDyM2CjdHPVn2SJhY=; h=Received:Received:From:To:Subject:Date:Message-Id:MIME-Version; b=pS92lRNt/kQ6IP1lIEp7tajA7dP81pNBSj6Dy+Ba7tiE6lHU0kDVY2hXcn3OH9nYJ 9AVb8cyUTnZj+ASjHsI9U9A1RE9dngd0ic0sgAGX/GAKNuYotzOX+Md0jpOtFcEW+j 1QOIonsglywIxgQZ5vMN7Ywot1+ndtfBBQAF+r4t9xvD1/eieEz/8H+ZQwahWs3FGa nNyhOOZNTy2abruKUzjPNOC/WtEA1Kprfo0d559f5ghF9LkclPKG6imMI11/vpQrK7 Xb7t826LQbLM1Lohf0mxz4oAvviR6vO5DnX2c38lauRi3G28ZTOto1meEH1V2/nPOW BXki4viB+LkFw== Received: from jderrick-mobl4.amr.corp.intel.com ([71.205.181.50]) by resomta-h1p-028434.sys.comcast.net with ESMTPA id gZ2nocknTZjG3gZ2roEgwk; Thu, 06 Oct 2022 22:08:47 +0000 X-Xfinity-VAAS: gggruggvucftvghtrhhoucdtuddrgedvfedrfeeiiedgtdeiucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuvehomhgtrghsthdqtfgvshhipdfqfgfvpdfpqffurfetoffkrfenuceurghilhhouhhtmecufedtudenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurhephffvvefufffkofgggfestdekredtredttdenucfhrhhomheplfhonhgrthhhrghnucffvghrrhhitghkuceojhhonhgrthhhrghnrdguvghrrhhitghksehlihhnuhigrdguvghvqeenucggtffrrghtthgvrhhnpedvtdejiefgueelteevudevhfdvjedvhfdtgfehjeeitdevueektdegtedttdehvdenucfkphepjedurddvtdehrddukedurdehtdenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhephhgvlhhopehjuggvrhhrihgtkhdqmhhosghlgedrrghmrhdrtghorhhprdhinhhtvghlrdgtohhmpdhinhgvthepjedurddvtdehrddukedurdehtddpmhgrihhlfhhrohhmpehjohhnrghthhgrnhdruggvrhhrihgtkheslhhinhhugidruggvvhdpnhgspghrtghpthhtohepiedprhgtphhtthhopehsohhngheskhgvrhhnvghlrdhorhhgpdhrtghpthhtoheplhhinhhugidqrhgrihgusehvghgvrhdrkhgvrhhnvghlrdhorhhgpdhrtghpthhtoheplhhinhhugidqkhgvrhhnvghlsehvghgvrhdrkhgvrhhnvghlrdhorhhgpdhrtghpthhtohepjhhonhgrthhhrghnrdguvghrrhhitghksehsoh hlihguihhgmhdrtghomhdprhgtphhtthhopehjohhnrghthhgrnhigrdhskhdruggvrhhrihgtkhesihhnthgvlhdrtghomhdprhgtphhtthhopehjohhnrghthhgrnhdruggvrhhrihgtkheslhhinhhugidruggvvh X-Xfinity-VMeta: sc=-100.00;st=legit From: Jonathan Derrick To: Song Liu Cc: , , jonathan.derrick@solidigm.com, jonathanx.sk.derrick@intel.com, Jonathan Derrick Subject: [PATCH 0/2] Bitmap percentage flushing Date: Thu, 6 Oct 2022 16:08:37 -0600 Message-Id: <20221006220840.275-1-jonathan.derrick@linux.dev> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-1.2 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,SPF_HELO_PASS,SPF_SOFTFAIL autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This introduces a percentage-flushing mechanism that works in-tandem to the delay timer. The percentage argument is based on the number of chunks dirty. It was chosen to use number of chunks due to large drives requiring smaller and smaller percentages (eg, 32TB drives-> 1% is 320GB). The first patch fixes a performance gap observed in RAID1 configurations. With a synchronous qd1 workload, bitmap writes can easily become almost half of the I/O. This could be argued to be expected, but undesirable. Moving the unplug operation to the periodic delay work seemed to help the situation. The second part of this set adds a new field in the superblock and version, allowing for a new argument through mdadm specifying the number of chunks allowed to be dirty before flushing. Accompanying this set is an RFC for mdadm patch. It lacks documentation which will be sent in v2 if this changeset is appropriate. Jonathan Derrick (2): md/bitmap: Move unplug to daemon thread md/bitmap: Add chunk-count-based bitmap flushing drivers/md/md-bitmap.c | 38 +++++++++++++++++++++++++++++++++++--- drivers/md/md-bitmap.h | 5 ++++- drivers/md/md.h | 1 + drivers/md/raid1.c | 2 -- drivers/md/raid10.c | 4 ---- 5 files changed, 40 insertions(+), 10 deletions(-) -- 2.31.1