Received: by 2002:a05:6359:c8b:b0:c7:702f:21d4 with SMTP id go11csp233958rwb; Thu, 6 Oct 2022 17:37:43 -0700 (PDT) X-Google-Smtp-Source: AMsMyM4ttcsVziBhSV1D6O/ywqZyRDjaDFX+05gP9H/P+IuO0Hg/Bgq0ClHurBYB0vdZtVb+jfo9 X-Received: by 2002:a17:90b:4a8e:b0:20b:6984:a5c6 with SMTP id lp14-20020a17090b4a8e00b0020b6984a5c6mr797621pjb.22.1665103063605; Thu, 06 Oct 2022 17:37:43 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1665103063; cv=none; d=google.com; s=arc-20160816; b=kOcOLTrliDe78+KX1ZiK11DCSRHzM+E/bt2P+b+v/hoejgeSPIL79FEVb/S5O5kG0Z QGh0me8bhMhHkVSRDWOBCbremAtnEGVHQMBEBj22SG1FfaikXHKxpfj8daPvVjN32Z+k C9PRt7cb8rPaq4NmpzI2oQEGU/9IMmvAJA63QkEpjKY/I/bxQOKiILEE9Lv1nlJ19NsW 8QOZdkuCuP4O/wmtf7741c+rr00HeqBgYOEevboqs5/Zd1yJvK05NBa8niaP+SfOqAIq 7fgkgDKNQKWXpu5Ok7neC2u2cpEIaknoD/3/OY9HOzO8IaEJ6B8zFelbk6UtnSsE5Ayr gRbw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:user-agent:references:message-id :in-reply-to:subject:cc:to:from:date:dkim-signature; bh=b4QgdxRKhwClKat+dImvkV2M5PBgJ3tXDKD7ilN9xro=; b=Ln/+ZN0T5RXRlo0A4P32uNAPPBI1xz/bf2MzEIrORMDeFPZSJunUHqQ0jjYZYAZkx2 XehrT5ZATKKTBxLGiydk4t0/al4Erx3AWkTZnJR6/HBRoTG8Y1M6NuTdUexmM5Dzl5Kn E4zrbYUQ+MIIccdPBS0OSbN1cukZ105zmcZOaQ9Lqc6c2hv0sqg+XR6n4L2b0C24Y4QC /mO3pl7X4YFMQAxDuNUKUshLihVyMFJw0yfLgn+4CjqOuG15jjD+HkDD/EqljFaITcyb NFoKw3jPzInOQNWQp0EfNx+fKQHD3yKt8futLe/rpnhNT6+we4o0+4AXk6ltoueVCUC/ t3dw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=HqwJ3XEQ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id t15-20020a17090a0d0f00b0020354bcfe09si916106pja.129.2022.10.06.17.37.30; Thu, 06 Oct 2022 17:37:43 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=HqwJ3XEQ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232195AbiJGAXl (ORCPT + 99 others); Thu, 6 Oct 2022 20:23:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55616 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231587AbiJGAXj (ORCPT ); Thu, 6 Oct 2022 20:23:39 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9623FC510A for ; Thu, 6 Oct 2022 17:23:38 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 9D41861921 for ; Fri, 7 Oct 2022 00:23:37 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5011DC433C1; Fri, 7 Oct 2022 00:23:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1665102217; bh=Et26OS3EyRmy77qPfsgsF4rcn/zFt1wMAuvka68v87U=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=HqwJ3XEQ4nYbxIa9HgoA/a7H7BKi8YZZgdoGyWU0p1t3yobUxFminM/Nmzhx7DtWE g4/UdyCL2b9YXIq1ufshqRbgzCmpCujqe7CRjCh91WSJLx7henkuE10iQE7vtgo6dY zXDO45zb0YclllssCxvKoeyufx+tocHyVs+cx5lHeQDZFeRQQemgF3IhCiEVamV9eb 30YVr2Fmf1Z5khqxrznRy+C9swz/2Uk6a+pB/9IU/kZEA5U0wrm3KfX3vE/FqKy2dN m4Wu2Qgb5t2q7Loz10eQPfMmSYbNs4gVT67zOGi6UmnKvwcr1VkpAQAojRkD2jRt1o qzNf6xBnqQqUg== Date: Thu, 6 Oct 2022 17:23:34 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Oleksandr Tyshchenko cc: Juergen Gross , "linux-kernel@vger.kernel.org" , Stefano Stabellini , "xen-devel@lists.xenproject.org" Subject: Re: [PATCH 1/3] xen/virtio: restructure xen grant dma setup In-Reply-To: Message-ID: References: <20221006071500.15689-1-jgross@suse.com> <20221006071500.15689-2-jgross@suse.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 6 Oct 2022, Oleksandr Tyshchenko wrote: > On 06.10.22 10:14, Juergen Gross wrote: > > Hello Juergen > > > In order to prepare supporting other means than device tree for > > setting up virtio devices under Xen, restructure the functions > > xen_is_grant_dma_device() and xen_grant_setup_dma_ops() a little bit. > > > > Signed-off-by: Juergen Gross > > > Patch looks good, > > one NIT, xen_dt_grant_setup_dma_ops() down the code doesn't actually > setup DMA OPS, it retrieves the backend domid via device-tree means and > stores it, > > so I would rename to it, maybe something like > xen_dt_grant_setup_backend_domid() or xen_dt_grant_init_backend_domid(), > but I am not sure it would be good alternative. > > > So, w/ or w/o renaming: > > Reviewed-by: Oleksandr Tyshchenko > > also > > Tested-by: Oleksandr Tyshchenko # Arm64 > only Acked-by: Stefano Stabellini