Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 6 Oct 2022 22:15:59 -0500
From:   Bjorn Andersson <andersson@kernel.org>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc:     Andy Gross <agross@kernel.org>,
        Konrad Dybcio <konrad.dybcio@somainline.org>,
        Linus Walleij <linus.walleij@linaro.org>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 12/16] dt-bindings: pinctrl: qcom,sm8250: drop checks
 used in common TLMM
Message-ID: <20221007031559.2rptlgxxgfwiqz57@builder.lan>
References: <20220930192954.242546-1-krzysztof.kozlowski@linaro.org>
 <20220930192954.242546-13-krzysztof.kozlowski@linaro.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220930192954.242546-13-krzysztof.kozlowski@linaro.org>
Precedence: bulk

On Fri, Sep 30, 2022 at 09:29:50PM +0200, Krzysztof Kozlowski wrote:
> The common Qualcomm TLMM pin controller schema brings already
> requirement of function for gpio pins.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Reviewed-by: Bjorn Andersson <andersson@kernel.org>

> ---
>  .../bindings/pinctrl/qcom,sm8250-pinctrl.yaml         | 11 +----------
>  1 file changed, 1 insertion(+), 10 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,sm8250-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,sm8250-pinctrl.yaml
> index d7d8e5d3b659..021592b32904 100644
> --- a/Documentation/devicetree/bindings/pinctrl/qcom,sm8250-pinctrl.yaml
> +++ b/Documentation/devicetree/bindings/pinctrl/qcom,sm8250-pinctrl.yaml
> @@ -64,6 +64,7 @@ patternProperties:
>      if:
>        type: object
>      then:
> +      $ref: qcom,tlmm-common.yaml#/$defs/qcom-tlmm-state
>        properties:
>          pins:
>            description:
> @@ -118,16 +119,6 @@ patternProperties:
>        required:
>          - pins
>  
> -      allOf:
> -        - $ref: "qcom,tlmm-common.yaml#/$defs/qcom-tlmm-state"
> -        - if:
> -            properties:
> -              pins:
> -                pattern: "^gpio([0-9]|[1-9][0-9]|1[0-7][0-9])$"
> -          then:
> -            required:
> -              - function
> -
>        additionalProperties: false
>  
>  allOf:
> -- 
> 2.34.1
>