Received: by 2002:a05:6359:c8b:b0:c7:702f:21d4 with SMTP id go11csp664583rwb; Fri, 7 Oct 2022 02:27:36 -0700 (PDT) X-Google-Smtp-Source: AMsMyM6qpOTMEnRLHwzkAs320QbkmIc5BHXFVD+H3gaTJs7qJnt+HLwRWvHo71+z0jnGCzzJNfZF X-Received: by 2002:a05:6402:22ed:b0:458:bcd1:69cf with SMTP id dn13-20020a05640222ed00b00458bcd169cfmr3742294edb.260.1665134855949; Fri, 07 Oct 2022 02:27:35 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1665134855; cv=none; d=google.com; s=arc-20160816; b=hnpBiW0mENP/+dl9Ig72FpBVxHEWAox534vpm7zKnsfVP2pbjgeU/enlErptfjMB1X 87FwrOApjgNpB8BGqcvLW9x9PPQqp9o0b2mN+mQsArpaiRbpLBxzUr3hsjqhUs4/gLxS UhLwwsDa+isFa+7sTlTXiUD4nCMZbj3wg66VYJwy10oPKtvK2Ck2ljJIH/MYB5Pa82Sz r2WHqJJ6eWd/AP3Sk1tAk38QxKyfI+0wqmNlUmkyGgkSkf2zwJ82Low4pyks4gWlzjHd R+8is4C9CpxLna4AX/0kRJNFl58viAx/SOXcq0u+GjD5RuIQvmk+lFYVcG//u8JHiVQ8 0qFA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:organization:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=+CvP5ipotFt8CT3ncCE2wBoOumytiCcMHZvLA6cIEd8=; b=Y3GC/+AunE5n6RnTh3KQktX0N6dVPSpjAEKNC7/PYvRcxLhTE4VdGLjWSUm0kc7D2W faCOLPtzglC6N4xhdPl0siQp+OvhRtR0nTwekR2e1jPXnW9q6ujK5NQ5LaducAowsN5O kAaSQXrUSoUYyD/LB4W9r6xlrWI0XNBpT6sU4btEqpevOIXVtHeHUOxOk40rEQC77JF7 S2jEWDRA2dW4zcdcjjutAYR2MpS25FYsSzSbn0tVy2V7ofhCdaT5+6VDUrEydUyew/+l LAwto/FGK15vQBoq+GaMj6m+n8m/OABFtdW8hzLli/O2AQu7ZWrXjhUaOplY3XB/FgwV RnIA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=hiJ13tI+; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id e25-20020a50a699000000b004582354990bsi1615937edc.454.2022.10.07.02.27.10; Fri, 07 Oct 2022 02:27:35 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=hiJ13tI+; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229751AbiJGJWe (ORCPT + 99 others); Fri, 7 Oct 2022 05:22:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50504 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229731AbiJGJWa (ORCPT ); Fri, 7 Oct 2022 05:22:30 -0400 Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 91FECCA8BB; Fri, 7 Oct 2022 02:22:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1665134549; x=1696670549; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=Y6QovZnXopByWxgIdjW4Tq1EYB20Z0xAuPpsuOHfho8=; b=hiJ13tI+3/e3P42NHs/q2OWrkofHkTZbq4V69KiKn0G4iq2R2Aw3Vsst sPoeyJLe+GvjzHgNk9YyeU1d24i8j3o43+tQqG0QzSGvquPVk9HDX8znL 8iJWWgwczGD0L0QZXJDW9RWmtaGAEddtJSbA0loJ1dC6ZHv1rz4Be9Y0Y HpXz65HwAs0627oAUYqSoOQDUp7wyhWr+mAmD1cWSrIDGwSQHorf9ZMT3 N+f7SRqHjh4xr3d0NVazCMZ1ahxvFANe4ufMb4/w8iQkWhNfPrKfZIiO+ bIOkfJz52iXLHSgbTCZPMDKrTVv3xwU0qt7I8I1xxuBusMVI+3nHGLF5a g==; X-IronPort-AV: E=McAfee;i="6500,9779,10492"; a="305275186" X-IronPort-AV: E=Sophos;i="5.95,166,1661842800"; d="scan'208";a="305275186" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Oct 2022 02:22:27 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10492"; a="767518301" X-IronPort-AV: E=Sophos;i="5.95,166,1661842800"; d="scan'208";a="767518301" Received: from smile.fi.intel.com ([10.237.72.54]) by fmsmga001.fm.intel.com with ESMTP; 07 Oct 2022 02:22:23 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1ogjYj-003Y19-1q; Fri, 07 Oct 2022 12:22:21 +0300 Date: Fri, 7 Oct 2022 12:22:21 +0300 From: Andy Shevchenko To: Joe Perches Cc: Matti Vaittinen , Matti Vaittinen , Jonathan Cameron , Lars-Peter Clausen , Rob Herring , Krzysztof Kozlowski , Jagath Jog J , Nikita Yushchenko , Cosmin Tanislav , linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH v2 4/5] iio: accel: Support Kionix/ROHM KX022A accelerometer Message-ID: References: <88e24b01da9f44ebf5fcd8344ded0b75ff742fbf.1665066397.git.mazziesaccount@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Oct 07, 2022 at 12:04:20AM -0700, Joe Perches wrote: > On Thu, 2022-10-06 at 21:32 +0300, Andy Shevchenko wrote: > > On Thu, Oct 06, 2022 at 05:38:14PM +0300, Matti Vaittinen wrote: > > > KX022A is a 3-axis accelerometer from ROHM/Kionix. The senosr features > > > include variable ODRs, I2C and SPI control, FIFO/LIFO with watermark IRQ, > > > tap/motion detection, wake-up & back-to-sleep events, four acceleration > > > ranges (2, 4, 8 and 16g) and probably some other cool features. > [] > > > +/* > > > + * Threshold for deciding our HW fifo is unrecoverably corrupt and should be > > > + * cleared > > > > Multi-line comments have to follow English grammar and punctuation, > > i.e. trailing period. > > I disagree. I think that would be a silly rule to enforce. https://www.kernel.org/doc/html/latest/process/maintainer-tip.html#coding-style-notes -- With Best Regards, Andy Shevchenko