Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 7 Oct 2022 12:19:18 +0300
From:   Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To:     ChiaEn Wu <peterwu.pub@gmail.com>
Cc:     pavel@ucw.cz, robh+dt@kernel.org,
        krzysztof.kozlowski+dt@linaro.org, matthias.bgg@gmail.com,
        jic23@kernel.org, lars@metafoo.de, chiaen_wu@richtek.com,
        alice_chen@richtek.com, cy_huang@richtek.com,
        linux-leds@vger.kernel.org, devicetree@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org,
        linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org,
        linux-iio@vger.kernel.org, szunichen@gmail.com
Subject: Re: [PATCH v13 5/5] leds: flash: mt6370: Add MediaTek MT6370
 flashlight support
Message-ID: <Yz/vFml0mwaF0+f9@smile.fi.intel.com>
References: <cover.1664991040.git.chiaen_wu@richtek.com>
 <1bcd19dbd09650ddac7b96b0fe2932698be2731e.1664991040.git.chiaen_wu@richtek.com>
 <Yz11bkxz9lK4wOHE@smile.fi.intel.com>
 <CABtFH5J2r=Qq1kNb=yp6Hf7=oKJH9qeiwsO+4ejy5m9N+ZODXg@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CABtFH5J2r=Qq1kNb=yp6Hf7=oKJH9qeiwsO+4ejy5m9N+ZODXg@mail.gmail.com>
Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
Precedence: bulk

On Fri, Oct 07, 2022 at 09:28:17AM +0800, ChiaEn Wu wrote:
> On Wed, Oct 5, 2022 at 8:15 PM Andy Shevchenko
> <andriy.shevchenko@linux.intel.com> wrote:

...

> > > +config LEDS_MT6370_FLASH
> > > +     tristate "Flash LED Support for MediaTek MT6370 PMIC"
> >
> > > +     depends on LEDS_CLASS && OF
> >
> > Why do you have OF dependency?
> >
> 
> Hi Andy,
> The original idea is to use the "fwnode_property_*" related function.
> But this side may only consider just "Build Pass" (?)

Yes, you increase a compile test coverage by dropping that dependency.

> I will remove "OF" in the v14 patch.

-- 
With Best Regards,
Andy Shevchenko