Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Feedback-ID: ie53945e4:Fastmail
From:   Bastian Rieck <bastian@rieck.me>
To:     Heikki Krogerus <heikki.krogerus@linux.intel.com>
Cc:     linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
        grzegorz.alibozek@gmail.com, andrew.co@free.fr, meven29@gmail.com,
        pchernik@gmail.com, jorge.cep.mart@gmail.com,
        danielmorgan@disroot.org, bernie@codewiz.org,
        saipavanchitta1998@gmail.com, rubin@starset.net,
        maniette@gmail.com, nate@kde.org
Subject: Re: [RFC PATCH 0/2] usb: typec: ucsi: Check connection on resume
Date:   Fri, 07 Oct 2022 12:00:16 +0200
Message-ID: <11781567.uqkIggiGGz@nimue>
Face:   iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAAAFz UkdCAK7OHOkAAAAVUExURdnY2d3d3vDDp8KYgoJnXK3K7i8gH0swGw4AAAH1SURBVDjLZVTNcpsw EJbopGfAk3uRPD4z2g1njDY6J2nVB0hUvf8jdFcIDO36Z8R+/n5WCCt1qLbt9uJLLe+WP52WegDl t+XF7fbAYIWV40bmdHoHpK2Vboy19ijVCqNVjXHGOFB6Z2hxV8pIAcCBUfpNASzAvWYurhtBKKM+ xVXOVApWk9r/VhkWsQY+Ab1ozSeGKPX9IFJj9y+wuuO8xlonX4GhAPf/pIbCoHtbclUA9jlo1sdU gOiNQY8FODB8ttlZwinRrFqZpAIZAHNGgACj2hicyn7hd/q8hQkDEah2l1qsN+7zthg7EYWitQJ2 4rzLlb8shSPDlLh2kTmC3EWt6x5a01/MFYcBKLnivgIXyydhsK5nqTTyIdgYjWUhgyAeNGoxqXMI I+UkQJIJOr0B4G6UyRkkkvPU7nfQ8dRAxKmEsKdigLhCcEhqO7V1e/11uExXj/PaPwB82MBWQO1S Cr44F6CneXsuNpMkDAbCvD5Le2X2NSFRSGdzxYHAZk6W3tSppuQxFGA+A5hTyIkov8ZT/wlClj6F eAbiB+8SJYbOwFNcQDaF8DXGg3uM0VuheM/L+Gi/x/hTjichxAdSlr+8PLKAL+WqqEUh/I58W4F3 Kz7H0nhjW1mGP9HwX4B9EVXpvKuyiinmuWl+rA7CeP4L2hiGKBFny1gAAAAASUVORK5CYII=
In-Reply-To: <YyRUF5cFGpe2xf+m@kuha.fi.intel.com>
References: <20220907115626.21976-1-heikki.krogerus@linux.intel.com> <YxrbtWDR7XI4s+Q+@kuha.fi.intel.com> <YyRUF5cFGpe2xf+m@kuha.fi.intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset="utf-8"
Precedence: bulk

Dear Heikki, dear all,

I am still unable to reproduce the previous error messages I=20
mentioned. In the meantime, the UCSI issues disappeared with 5.19.9=20
for me (!). I think this is related to a revert by Takashi Iwai  [1]=20
in 5.19.8.

Given these data, would it be useful to test your patch against=20
5.19.9 or a more recent version?

Thanks for all your efforts in supporting us here!

All the best,
 Bastian

[1] https://www.spinics.net/lists/linux-usb/msg230368.html

On Friday, September 16, 2022 12:46:47 PM CEST Heikki Krogerus=20
wrote:
> Hi Bastian,
>=20
> On Fri, Sep 09, 2022 at 09:22:50AM +0300, Heikki Krogerus wrote:
> > On Thu, Sep 08, 2022 at 07:01:34AM +0200, Bastian Rieck wrote:
> > > Dear Heikki,
> > >=20
> > > > I'm sending these as an RFC first because I'm not done
> > > > testing.
> > > >=20
> > > > I made a small modification to my original proposal (in the
> > > > bug
> > > > report). Now also connection during suspend should be
> > > > covered.
> > > >=20
> > > > I would appreciate if you guys could test these again. If
> > > > everything works, and the bug is fixed, let me know, and
> > > > I'll add
> > > > your Tested-by tags to the patches.
> > >=20
> > > Thanks so much for these changes=E2=80=94that's awesome! I have just
> > > finished testing this against 5.19.7 (Arch Linux) with a
> > > Lenovo X1 (Gen 9).
> > >=20
> > > I am very happy to see that, as far as I can tell, the issue
> > > disappeared completely!
> > >=20
> > > However, I am receiving additional warnings via `journalctl`
> > > that I did not receive before; I have attached this trace as
> > > an additional log file. Nothing in there seems critical and I
> > > can confirm that the system continues to operate normally. I
> > > merely wanted to provide you with this additional information
> > > in case it is of relevance.
> > >=20
> > > Please let me know if there's anything else I can do here; I
> > > really appreciate the time you spent on this!
> >=20
> > Thank you for the report. That warning certainly needs to be
> > sorted out before I send the final versions. I'll try to
> > reproduce that.
> I'm not getting anywhere with this one. Could you provide me with
> the trace output from both module and ucsi events?
>=20
> To enable those events - assuming debugfs is mounted to
> /sys/kernel/debug:
>=20
>         % echo 1 > /sys/kernel/debug/tracing/events/ucsi/enable
>         % echo 1 > /sys/kernel/debug/tracing/events/module/enable
>=20
> Run the suspend resume cycle, and then dump the trace output to a
> file:
>=20
>         % cat /sys/kernel/debug/tracing/trace > ucsi_trace
>=20
> thanks,