Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20221007111442.51481-1-a5b6@riseup.net> <20221007111442.51481-2-a5b6@riseup.net>
In-Reply-To: <20221007111442.51481-2-a5b6@riseup.net>
From:   Fabio Estevam <festevam@gmail.com>
Date:   Fri, 7 Oct 2022 08:51:45 -0300
Message-ID: <CAOMZO5C3PgvV6uoOZ_2iO8=QpE6bHzquo-hxNV4QgX6EmpcUGQ@mail.gmail.com>
Subject: Re: [PATCH v2 1/2] drivers: gpu: drm: add driver for samsung
 s6e3fc2x01 cmd mode panel
To:     Nia Espera <a5b6@riseup.net>
Cc:     Thierry Reding <thierry.reding@gmail.com>,
        Sam Ravnborg <sam@ravnborg.org>,
        David Airlie <airlied@linux.ie>,
        Daniel Vetter <daniel@ffwll.ch>, linux-kernel@vger.kernel.org,
        dri-devel@lists.freedesktop.org, linux-arm-msm@vger.kernel.org,
        Caleb Connolly <caleb@connolly.tech>,
        phone-devel@vger.kernel.org, ~postmarketos/upstreaming@lists.sr.ht
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Hi Nia,

On Fri, Oct 7, 2022 at 8:16 AM Nia Espera <a5b6@riseup.net> wrote:

> +static int samsung_s6e3fc2x01_prepare(struct drm_panel *panel)
> +{
> +       struct samsung_s6e3fc2x01 *ctx = to_samsung_s6e3fc2x01(panel);
> +       struct device *dev = &ctx->dsi->dev;
> +       int ret;
> +
> +       if (ctx->prepared)
> +               return 0;
> +
> +       ret = regulator_enable(ctx->supply);
> +       if (ret < 0) {
> +               dev_err(dev, "Failed to enable regulator: %d\n", ret);
> +               return ret;
> +       }
> +
> +       samsung_s6e3fc2x01_reset(ctx);
> +
> +       ret = samsung_s6e3fc2x01_on(ctx);
> +       if (ret < 0) {
> +               dev_err(dev, "Failed to initialize panel: %d\n", ret);
> +               gpiod_set_value_cansleep(ctx->reset_gpio, 1);

You should also call regulator_disable() here in the case of failure.

> +static int samsung_s6e3fc2x01_unprepare(struct drm_panel *panel)
> +{
> +       struct samsung_s6e3fc2x01 *ctx = to_samsung_s6e3fc2x01(panel);
> +       struct device *dev = &ctx->dsi->dev;
> +       int ret;
> +
> +       if (!ctx->prepared)
> +               return 0;
> +
> +       ret = samsung_s6e3fc2x01_off(ctx);
> +       if (ret < 0)
> +               dev_err(dev, "Failed to un-initialize panel: %d\n", ret);
> +
> +       gpiod_set_value_cansleep(ctx->reset_gpio, 1);

regulator_disable() should be called here as well.