Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 7 Oct 2022 14:17:00 +0100
From:   Will Deacon <will@kernel.org>
To:     Geert Uytterhoeven <geert+renesas@glider.be>,
        catalin.marinas@arm.com
Cc:     Mark Rutland <mark.rutland@arm.com>,
        Neng Chen <nengchen@linux.alibaba.com>,
        Jonathan Cameron <Jonathan.Cameron@huawei.com>,
        Baolin Wang <baolin.wang@linux.alibaba.com>,
        Hongbo Yao <yaohongbo@linux.alibaba.com>,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drivers/perf: ALIBABA_UNCORE_DRW_PMU should depend on
 ACPI
Message-ID: <20221007131659.GB26341@willie-the-truck>
References: <2a4407bb598285660fa5e604e56823ddb12bb0aa.1664285774.git.geert+renesas@glider.be>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <2a4407bb598285660fa5e604e56823ddb12bb0aa.1664285774.git.geert+renesas@glider.be>
User-Agent: Mutt/1.10.1 (2018-07-13)
Precedence: bulk

On Tue, Sep 27, 2022 at 03:37:16PM +0200, Geert Uytterhoeven wrote:
> The Alibaba T-Head Yitian 710 DDR Sub-system Driveway PMU driver relies
> solely on ACPI for matching.  Hence add a dependency on ACPI, to prevent
> asking the user about this driver when configuring a kernel without ACPI
> support.
> 
> Fixes: cf7b61073e4526ca ("drivers/perf: add DDR Sub-System Driveway PMU driver for Yitian 710 SoC")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
>  drivers/perf/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/perf/Kconfig b/drivers/perf/Kconfig
> index 44c07ea487f4482a..341010f20b777905 100644
> --- a/drivers/perf/Kconfig
> +++ b/drivers/perf/Kconfig
> @@ -185,7 +185,7 @@ config APPLE_M1_CPU_PMU
>  
>  config ALIBABA_UNCORE_DRW_PMU
>  	tristate "Alibaba T-Head Yitian 710 DDR Sub-system Driveway PMU driver"
> -	depends on ARM64 || COMPILE_TEST
> +	depends on (ARM64 && ACPI) || COMPILE_TEST
>  	help
>  	  Support for Driveway PMU events monitoring on Yitian 710 DDR
>  	  Sub-system.

Acked-by: Will Deacon <will@kernel.org>

Another one for Catalin to queue as a fix.

Will