Received: by 2002:a05:6359:c8b:b0:c7:702f:21d4 with SMTP id go11csp1083243rwb; Fri, 7 Oct 2022 07:57:35 -0700 (PDT) X-Google-Smtp-Source: AMsMyM6TJ6wo5tPYu8Z2NOYkCxMD07278PTx2F0WgLEFP8Lt9+7xXK6OJgFLZXxL8fuKM74Dw4pJ X-Received: by 2002:a17:906:3197:b0:73d:5e1a:44ac with SMTP id 23-20020a170906319700b0073d5e1a44acmr4306471ejy.512.1665154655111; Fri, 07 Oct 2022 07:57:35 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1665154655; cv=none; d=google.com; s=arc-20160816; b=ixErPtc1snU7G8N4NSAysfRL4Et/3EO4U3mcKLllwPgKvKQOkJMPdA+V/iM+v/3iVE r21HPz0LzfVgY/6HhITmIxdYVqNlTrO/fPjn2tPahNYJLlwAmN7nKmOWcxFQ6K4UrHBP fPE3D7kwckkDmgrmJdDZ0YU7/i5DMlvpAIlJ3M29snZupwJ4eQ1/Nr4JvWofDivtcfGj SwpEU5lTNgoUEUZ8XHKYJmF+Tf+s7Sb0UMad3Aa5ujZAuuYfW8fZcWe0FT7k9i5C3IZH R5SwKJhMgvBxY/HfFcHrmg36XrNZdHLwDCozKpLiVTTVk4QxvtamlydXFnKCg0Ylw4P8 dIkg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=2fM88JkR3ZA5dJ8+EnLpWg95xXbRsFNcDjLXwrdZGhA=; b=EIhpK09OapNXHfiAfr5YZ1O1Gr61cDXQn2DwBXEDCEpRNxsoLAT/27AwuCSELRxcra w2s7KwABgcc7IL/Sjg/xvoK2iOhguEIGVywcFbDan3o/zQa3MjSrunrz+L2OnoPpjIRv qYAOaOyj3so2Am0STlY5f5rBnSS96J8MO/IkPSK0z9Eyop2YomaXJGh90tYDly5S2Sl5 U8o0bx3Tb1uAFj+11Gq2jJ/bXFmpDMdH+Df3HiK33acSFCG5Mbwdqp5/oaNGvfaLone7 Ytz1664u8hEb+soG6aHSJSn8/bJfdbIq/tJBLlOLc53ZbVZJP33+QnzUT94mZhmhAZMB 6Jzg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=ngKGLeZw; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id ji7-20020a170907980700b0078d42f9d0ddsi2369172ejc.477.2022.10.07.07.57.08; Fri, 07 Oct 2022 07:57:35 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=ngKGLeZw; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229591AbiJGOXF (ORCPT + 99 others); Fri, 7 Oct 2022 10:23:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58420 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229469AbiJGOXD (ORCPT ); Fri, 7 Oct 2022 10:23:03 -0400 Received: from mail-yb1-xb29.google.com (mail-yb1-xb29.google.com [IPv6:2607:f8b0:4864:20::b29]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 97F23120EF6 for ; Fri, 7 Oct 2022 07:22:58 -0700 (PDT) Received: by mail-yb1-xb29.google.com with SMTP id 203so5907437ybc.10 for ; Fri, 07 Oct 2022 07:22:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=2fM88JkR3ZA5dJ8+EnLpWg95xXbRsFNcDjLXwrdZGhA=; b=ngKGLeZw9CyDozp6mhH3E6+a9FtNqfDGo49G1ogq76s7RYMMmOKfZHUijQIMis6UTn Fi3JKdHhCGn2719hZRUeg8GTpk1q4t8cKpUHBoOmPIIOMoiQhdWewEfgvfVZxboNQArK 5Gn18JCzuwjUaXwAC0aQORqQ9O1LmLB+46iD80w7oOLX+UwRfaLpi2zpgOLoIjrTEn1H /nUu076Aqvd+mBg9cqbDCyWCWmesJ2QuveR42CE0kShWT3nPFiIJkLVANTYKQx0X4Tx0 WnJUReob4IeU36iwEzUSB1JEfJh5fcjXDNdzgd7MlIZ/mHqUSlIqIpC64jE/5TgutdtW 9g0g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=2fM88JkR3ZA5dJ8+EnLpWg95xXbRsFNcDjLXwrdZGhA=; b=vg+k/Hsi696sZv7hzygWbq1PjSacFynL6/p74BSzjRDGxrpQWnRq+WKq6ZR3sLDExj m/uHZ4lprvrdy4SparecexwJXDypnNs51GqjstuV/udDnxUW+caRfyGbe9oD+vcs9HnT ufZ+aKpt1xrm+k7kCBTqQkbaI9h0G8dFUa26aT9SopWxTaWu2o9VBjD+gR65jPWvlvk/ EWyo2Oxiga2oLtTtHNY+skMXxvpnRG08KoY/ZaeE0PbwI1KpPKKckkKN+7g8jsKDNwrI Kfzq0AxkRnQGhthh+w4qMfEle9hXDuVV+N6aSOy+Na6s1VXWPHYhdtNZXHvpUTeQoCXC ZGJA== X-Gm-Message-State: ACrzQf1dElNbqrek39L9ZKmrfj1A9l+zqkGS7zpL/Ppz18T5yYGVKpIx S0+2LQ/mq773lXuySn4/TgTIn50s6wkYiuFdB8Q= X-Received: by 2002:a25:a0cd:0:b0:6bc:9569:b63e with SMTP id i13-20020a25a0cd000000b006bc9569b63emr5069657ybm.376.1665152577389; Fri, 07 Oct 2022 07:22:57 -0700 (PDT) MIME-Version: 1.0 References: <20221004171351.3678194-1-daeho43@gmail.com> <4d7f250d-19c0-acd0-dde4-752f95c5fc2a@kernel.org> In-Reply-To: <4d7f250d-19c0-acd0-dde4-752f95c5fc2a@kernel.org> From: Daeho Jeong Date: Fri, 7 Oct 2022 07:22:46 -0700 Message-ID: Subject: Re: [f2fs-dev] [PATCH v4 1/2] f2fs: correct i_size change for atomic writes To: Chao Yu Cc: linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, kernel-team@android.com, Daeho Jeong Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-1.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_ENVFROM_END_DIGIT, FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > > Fine to me. > > But another question is, now it allows GC to migrate blocks belong > to atomic files, so, during migration, it may update extent cache, > once largest extent was updated, it will mark inode dirty, but after > this patch, it may lose the extent change? thoughts? > Oh, I missed that case. Maybe we could prevent updating the i_size of atomic files in f2fs_update_inode() while allowing inode dirtying.