Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <de559e06-7391-b28e-2d59-50abc68c3034@kernel.org>
Date:   Fri, 7 Oct 2022 22:42:53 +0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.2
Subject: Re: [f2fs-dev] [PATCH v4 1/2] f2fs: correct i_size change for atomic
 writes
To:     Daeho Jeong <daeho43@gmail.com>
Cc:     linux-kernel@vger.kernel.org,
        linux-f2fs-devel@lists.sourceforge.net, kernel-team@android.com,
        Daeho Jeong <daehojeong@google.com>
References: <20221004171351.3678194-1-daeho43@gmail.com>
 <b1ca9048-99c5-1ab4-fb77-5fe0bbc6d4de@kernel.org>
 <CACOAw_zXTHzc5mjPchGNXkgnswZLxLEBfRoEztB7VFdV-rtpwQ@mail.gmail.com>
 <4d7f250d-19c0-acd0-dde4-752f95c5fc2a@kernel.org>
 <CACOAw_weAbKWs6qi5x9t2=L41tVUV+CKjG-BGn1gOOtgjdWYug@mail.gmail.com>
Content-Language: en-US
From:   Chao Yu <chao@kernel.org>
In-Reply-To: <CACOAw_weAbKWs6qi5x9t2=L41tVUV+CKjG-BGn1gOOtgjdWYug@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 2022/10/7 22:22, Daeho Jeong wrote:
>>
>> Fine to me.
>>
>> But another question is, now it allows GC to migrate blocks belong
>> to atomic files, so, during migration, it may update extent cache,
>> once largest extent was updated, it will mark inode dirty, but after
>> this patch, it may lose the extent change? thoughts?
>>
> 
> Oh, I missed that case. Maybe we could prevent updating the i_size of
> atomic files in f2fs_update_inode() while allowing inode dirtying.

Agreed. :)

Thanks,