Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 7 Oct 2022 08:45:40 -0700
From:   Ira Weiny <ira.weiny@intel.com>
To:     Andrew Morton <akpm@linux-foundation.org>
CC:     "Fabio M. De Francesco" <fmdefrancesco@gmail.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        Christoph Hellwig <hch@lst.de>,
        kernel test robot <lkp@intel.com>,
        Al Viro <viro@zeniv.linux.org.uk>,
        Linus Walleij <linus.walleij@linaro.org>, <linux-mm@kvack.org>,
        <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH V2] highmem: Fix kmap_to_page() for kmap_local_page()
 addresses
Message-ID: <Y0BJpOiAlStJJ5CM@iweiny-desk3>
References: <20221006040555.1502679-1-ira.weiny@intel.com>
 <20221006133331.dabd345508f7d62a887dfb4d@linux-foundation.org>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20221006133331.dabd345508f7d62a887dfb4d@linux-foundation.org>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?bar97cD3lbXEGvf5z+108l/B3OPI8FRojimDYqbEqHDL79M64Ot21wW/sWc3?=
 =?us-ascii?Q?eopYVUg78p6QSdwpV6x/TRu1lDp2wxmQnr2WSMP9B/Lp5+DC947p6qA5VLxr?=
 =?us-ascii?Q?bNFUnSrXnys1PN0HQW/hAW+TtlvdqZ8u5jLwVb3G/lAr4vRitDkjGBdAcfYc?=
 =?us-ascii?Q?VkaTFFUxkoh/qOaKfFw9ctEZobkrmSqY8Fc0PoAwtGhM25wzoFT42n7xjzqF?=
 =?us-ascii?Q?gXZyyJm0ziO13/p+vRj5U7r/ok8nqD9t5dR2mR1dl9KGIS0rOTA9v3NATDPk?=
 =?us-ascii?Q?nINFYMIZE5KdCTPKLkJI/IVr0pbtDBqGaA8U8/77hBtCLEAPUGE3t89tvRdk?=
 =?us-ascii?Q?FbDS9FjdD2OOjkYrdQ+ebjhhPIpmcCPFlmOaqasyVPyT6p7i58caY6sF0xvn?=
 =?us-ascii?Q?Uwa0hBpobp/cyLWym3Qq2yDiSzATlOJvfZvHIygPYDYzbWQT0qb6aXDstpFO?=
 =?us-ascii?Q?Rae8pNdpOqBQZP0CDQ/0oQk1cHe3CWSFOiTUZSc3L+/VQdTubyrzRJdeY2ts?=
 =?us-ascii?Q?OrSAbUGhd6HS4PG/4A5tPyhfW/OkYjekvbgGKKIxYoEKjEFyG1ah7t2MqcX2?=
 =?us-ascii?Q?+xa9L+0POtm1hf809kddPP2XrMU9ZlyoLZEsvI0RTLXLCySSyPR2rIyfjFwu?=
 =?us-ascii?Q?KywC4CfQkBfVXyV1EMhERTMkv1Xb1J51EXkolJQW8zYj9lrKl1wFF/FSslqt?=
 =?us-ascii?Q?L4YvXl6Kzh/5nO1UzQ+5LPvo+/CA/42hHRXNy21EpM1rNHE554o6EKFhrd8W?=
 =?us-ascii?Q?nBqrwf1Hy+rS05dEHeQuZKA9Om/y2pS0665SFQZdkrWG8Ks6I6WfS6JGDap/?=
 =?us-ascii?Q?z5JxWxujbyVs+PsGCZKKyKjnDSTLNmOoVRDFkgvC8mrqMaFUoUkG8UBrkxpY?=
 =?us-ascii?Q?44nF15hJ0+eSf2oeEY1vC+/jPQIc+J1OtIJT9ixGQ5Sp4Q1NyHbrrsFof8lv?=
 =?us-ascii?Q?qIUpKYRd4Tw5u8BJDoHZdggPKkxSLx6D6W57IJ6N+D2hmqDNccdbORwMjS1n?=
 =?us-ascii?Q?4rLqm/hRi3YhzXb6ZLLEqhpFqdjoacmuDeQMfeCChiqqjvlKNRyhuKrnpcXV?=
 =?us-ascii?Q?jfi1Szua1egyKhdUIGZBy8KAvJfs5xAe9J0+DU8HNmTBDvp8F8YHp2XqDf1i?=
 =?us-ascii?Q?7qEzSZTUrSbhWXKnhFPABWPaG1Z4eEDJO2JjfZbvowlshGR0aYFEFt7RWMK/?=
 =?us-ascii?Q?A1b7Cq8bjXb2dYyEZMJkD8HBuLOP9qWmTVdS/dh0wQFDWmwfdkG4cQY/qEVr?=
 =?us-ascii?Q?ybnagM1Ozis1iWcJJpWZ03VQ2Hec/DVToRduX//tlZf/1dCfAIfo0Yp9sBYq?=
 =?us-ascii?Q?KflMuV8PhOUGbGGadEQWxaANhpQq8/wtr+BenYPksoZlnhGxcgm6DFimS6+q?=
 =?us-ascii?Q?vwzVp6rMx/esxEf5aCLYsxsfQiseMKzJ4gBW0pWVCSSmKrCsYUQYq2/D6bGp?=
 =?us-ascii?Q?LD8y9CKDW6l208T4W5my/OYizOMp8Om3UYBb8Ld+61h4nGbfAP8LPH5wmaWX?=
 =?us-ascii?Q?7fRCBDvouD4j+v9mfSLM+CvVGHtUYOrg3W5hbDE4RA4OUlbEih8A9OPlCGcL?=
 =?us-ascii?Q?P/sMFjvoFsA253E58YsqM4o/zDWnvoWaZrUWqkA/?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 1a1b764a-fda7-4e48-e786-08daa87aff7e
X-MS-Exchange-CrossTenant-AuthSource: SA1PR11MB6733.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Oct 2022 15:45:45.3580
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: HOkBGYWoM8QrZz9dNAfZO3QyBDvl8QgaF1XvW3GvyHdPV+keKrJuyrs5xfT0hdp8f+j2rmlm1oLlz0+8BSr7SA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR11MB4988
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,
        SPF_NONE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Oct 06, 2022 at 01:33:31PM -0700, Andrew Morton wrote:
> On Wed,  5 Oct 2022 21:05:55 -0700 ira.weiny@intel.com wrote:
> 
> > kmap_to_page() is used to get the page for a virtual address which may
> > be kmap'ed.  Unfortunately, kmap_local_page() stores mappings in a
> > thread local array separate from kmap().  These mappings were not
> > checked by the call.
> > 
> > Check the kmap_local_page() mappings and return the page if found.
> > 
> > Because it is intended to remove kmap_to_page() add a warn on once to
> > the kmap checks to flag potential issues early.
> 
> What were the user-visible runtime effects of this?

No one actually hit a bug with this because AFAIK only one kmap() call has been
converted to kmap_local_page() which then eventually calls kmap_to_page().

	https://lore.kernel.org/lkml/YzN+ZYLjK6HI1P1C@ZenIV/

However that has already been fixed by Al in that thread.

> 
> Are we able to identify a Fixes:?

I suppose this could be added as a Fixes: to the original patch introducing
kmap_local_page()?  But one could argue that kmap_to_page() was only intended
to support kmap() addresses because it does not work with kmap_atomic()
addresses either.

I'm proposing this as a stop gap to ensure that work can continue on converting
kmap() uses to kmap_local_page() without fear of causing breakage while
simultaneously we evaluate and hopefully remove kmap_to_page() as well.

Ira