Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Feedback-ID: ifd894703:Fastmail
User-Agent: Cyrus-JMAP/3.7.0-alpha0-1015-gaf7d526680-fm-20220929.001-gaf7d5266
Mime-Version: 1.0
Message-Id: <b3886864-5c54-4524-8e30-b6701553b615@app.fastmail.com>
In-Reply-To: <Y0A9L2KajswAEKsu@kroah.com>
References: <20221007141207.30635-1-jiaxun.yang@flygoat.com>
 <Y0A9L2KajswAEKsu@kroah.com>
Date:   Fri, 07 Oct 2022 17:37:34 +0100
From:   "Jiaxun Yang" <jiaxun.yang@flygoat.com>
To:     "Greg KH" <greg@kroah.com>
Cc:     "linux-mips@vger.kernel.org" <linux-mips@vger.kernel.org>,
        linux-kernel@vger.kernel.org,
        "Thomas Bogendoerfer" <tsbogend@alpha.franken.de>,
        linux-api@vger.kernel.org, f.fainelli@gmail.com
Subject: Re: [PATCH v5] MIPS: Expose prid and globalnumber to sysfs
Content-Type: text/plain;charset=utf-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk


=E5=9C=A82022=E5=B9=B410=E6=9C=887=E6=97=A5=E5=8D=81=E6=9C=88 =E4=B8=8B=E5=
=8D=883:52=EF=BC=8CGreg KH=E5=86=99=E9=81=93=EF=BC=9A
[...]
>> +
>> +static int cpuregs_cpu_offline(unsigned int cpu)
>> +{
>> +	struct device *dev;
>> +	struct cpureg *reg =3D per_cpu(cpuregs, cpu);
>> +
>> +	dev =3D get_cpu_device(cpu);
>> +	if (!dev || !reg)
>> +		return -ENODEV;
>> +	if (reg->kobj.parent) {
>
> Why are you looking at the parent of a kobject?  Why not just always
> remove the kobject if you have a reference to it now?  How does the
> parent matter?

Another dummy copy from Arm64 code... kobject_put should be enough here?

Thanks

>
> thanks,
>
> greg k-h

--=20
- Jiaxun