Received: by 2002:a05:6359:c8b:b0:c7:702f:21d4 with SMTP id go11csp1321953rwb; Fri, 7 Oct 2022 10:53:15 -0700 (PDT) X-Google-Smtp-Source: AMsMyM4H44/oheKHfxjJamBQHMT/IJKLdztsAaaJDOujFw5iGXXTEuZN1wIvdP64VVCsEHf2pGJM X-Received: by 2002:a05:6402:5256:b0:459:42b3:3d86 with SMTP id t22-20020a056402525600b0045942b33d86mr5526598edd.370.1665165195030; Fri, 07 Oct 2022 10:53:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1665165195; cv=none; d=google.com; s=arc-20160816; b=x9e20WCQJjKoaD/1Di2xa6vjg7m91Xhig6f/SWDL6TqB6TIoSL2JVBRris+zYvXuJw 2GP3ysgLm4TMkMrz4F7EELFSeERbkQ4cfizpOWcQ+woAR7eyb4FYH7ufzNEwMD8TMKc/ baCUAtdVoo9+DKSMSo+/b3smkYVYhXk3xy/zA9PhIkxa+cVeKj5IWDdmLig02SwFi4Qq oxByYikKfQu6+URdmpNqakEj5dqxfZghepOk5Sy+n/XY3xCE3TQEzt8MwpMqnW8iDUAt dyqERkfD1nfmCUtnORbGtgvC2HLXcwzkRKCP0G0i2tGQF36qiJceyyl+LMFWOXItW4Om 0ekw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:mail-followup-to:message-id:subject:cc:to:from:date :dkim-signature; bh=SPtuiDiMDgyngSZvR6+bVeBAbAz5xZ/G+BgQniYEpEQ=; b=rTK6ffD6WP7Qbcp4Vg3Apf3he/FxwlnlSpXIgQ5FB5WZQL1DupE23EwZcgUMLDxk3H gE+ZfuV8N1RfIzZq6SLjrUg5x6A+JqdUtN8CUt8oNmNul9mWttoniVQsO8Lq9LrcVRvs +9cFOWZ5kiFixuPBxd8ZGmByU8meF7WYUJoeOAlvwtJlj+25pUGUuLjUnq9TMQ4pBUMZ z/Y4pTzuQ6G/lbfLXnp+fAmhgXCX7GIjPYHffRonl3XQZsItEAr255rwXQrCt0G4gxoH 8DeUXjxoz01f8/7CI/SPHf9BPwtE6v9qpO3cPDKzaFasf/J57MuIleVxzWeUJfuc7R7G p7BQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=LP8J88p4; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id o10-20020a170906974a00b0078d49878779si2974320ejy.803.2022.10.07.10.52.48; Fri, 07 Oct 2022 10:53:15 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=LP8J88p4; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229790AbiJGRqq (ORCPT + 99 others); Fri, 7 Oct 2022 13:46:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59192 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229713AbiJGRqj (ORCPT ); Fri, 7 Oct 2022 13:46:39 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5F742102522 for ; Fri, 7 Oct 2022 10:46:38 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id DD75161509 for ; Fri, 7 Oct 2022 17:46:37 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 892F4C433C1; Fri, 7 Oct 2022 17:46:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1665164797; bh=GYvJFCOsj2U1zfDFdDoeHoZGcUx99SoKzBKO4FXvIwI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=LP8J88p4uPSjSloYJKiszC6Q9OQ9Qv85yEaKADNULmXu1KJhprUXxKEPZfhohJHUN NbonQo6MO2W0cat/n62wOxq67CtB9e2wezVpiAzjQTPQ1NHk6AKzqLj02wIju1caqQ Ltc7WJ2aIcgnVOXZOS/dlbrhex4JkeuYeANtnYcBO50+d6YMyN4VQle7TpXQ9bDZlx 0OpfyK6QhN+rmGLKmD86KNZCngIRcCX7AfyhYkjlVOaMfKP+XCE4eptkP5E52pTEJb Uau0O+zMJ2pfStM4QJhZVXl7pqFgr3IOYqLMnctQqW4JZTU+OElrseJYviNJHVYSqA 78xfkEPOWNCBQ== Date: Sat, 8 Oct 2022 01:46:32 +0800 From: Gao Xiang To: Yue Hu Cc: xiang@kernel.org, chao@kernel.org, linux-erofs@lists.ozlabs.org, linux-kernel@vger.kernel.org, zhangwen@coolpad.com, Yue Hu Subject: Re: [PATCH v2] erofs: fix invalid unmapped accesses in z_erofs_fill_inode_lazy() Message-ID: Mail-Followup-To: Yue Hu , xiang@kernel.org, chao@kernel.org, linux-erofs@lists.ozlabs.org, linux-kernel@vger.kernel.org, zhangwen@coolpad.com, Yue Hu References: <20221005013528.62977-1-zbestahu@163.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20221005013528.62977-1-zbestahu@163.com> X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Oct 05, 2022 at 09:35:28AM +0800, Yue Hu wrote: > From: Yue Hu > > Note that we are still accessing 'h_idata_size' and 'h_fragmentoff' > after calling erofs_put_metabuf(), that is not correct. Fix it. > > Fixes: ab92184ff8f1 ("erofs: add on-disk compressed tail-packing inline support") > Fixes: b15b2e307c3a ("erofs: support on-disk compressed fragments data") > Signed-off-by: Yue Hu Reviewed-by: Gao Xiang Thanks, Gao Xiang