Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 7 Oct 2022 13:44:10 -0700
From:   Colin Foster <colin.foster@in-advantage.com>
To:     Vladimir Oltean <olteanv@gmail.com>
Cc:     linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
        devicetree@vger.kernel.org, netdev@vger.kernel.org,
        Russell King <linux@armlinux.org.uk>,
        Linus Walleij <linus.walleij@linaro.org>,
        UNGLinuxDriver@microchip.com,
        Alexandre Belloni <alexandre.belloni@bootlin.com>,
        Claudiu Manoil <claudiu.manoil@nxp.com>,
        Lee Jones <lee@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Rob Herring <robh+dt@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Eric Dumazet <edumazet@google.com>,
        "David S. Miller" <davem@davemloft.net>,
        Florian Fainelli <f.fainelli@gmail.com>,
        Vivien Didelot <vivien.didelot@gmail.com>,
        Andrew Lunn <andrew@lunn.ch>
Subject: Re: [PATCH v3 net-next 12/14] dt-bindings: net: dsa: ocelot: add
 ocelot-ext documentation
Message-ID: <Y0CPmuxTRr799AR5@euler>
References: <20220926002928.2744638-1-colin.foster@in-advantage.com>
 <20220926002928.2744638-13-colin.foster@in-advantage.com>
 <20220927202600.hy5dr2s6j4jnmfpg@skbuf>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220927202600.hy5dr2s6j4jnmfpg@skbuf>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?ciWgi5e06fG57ADKU8zKxBf7gYm7HrHz5OaBmX6KATNKQhfl2QvwzZjOme/h?=
 =?us-ascii?Q?jChinKMuRTdDzo8r6nDDxj3kB5Xy4qWdVZ/uuPAW1WoWtGvO3P3gm37F+R/A?=
 =?us-ascii?Q?JCGOm+7WGQt7MSmoa21zV1AEZmEJ6hbE6cpln/4BX8tcMjJarGWfnYfYa0St?=
 =?us-ascii?Q?jGnYmZ3538hCxOOpjCYfAuQCn3HSZbxhI3aEx0c8+m2EzVUZxNSrDrQA2V1j?=
 =?us-ascii?Q?cFBKiTJfOQBdt1hseRqVzFY2vak2UCbYBuggvLJ+ghwhd29NbvXYvLYSKAMc?=
 =?us-ascii?Q?JgBHRi+twEliVxvMRjAd2xHfMQRYVbzfs75hZWsXSM34UqipczlnpBDfT6IJ?=
 =?us-ascii?Q?TgXCK5kvCp0ebDMUCqVcqDYl4wQtSqIzJkTlMsl5hNLbVMW1Q8Dy9u6R4Ert?=
 =?us-ascii?Q?YkSgRL53nX+lQMilEnxPXtOck+l+myKhtLFH+jIQ5smVTV+yKU2S3mO+nl9O?=
 =?us-ascii?Q?7vdqa4rafBpHvQzyfKShrqaDBRxAPXbpR/0gLI2Su9N1NolimHuhzYT4alYU?=
 =?us-ascii?Q?BMb5J4Rlj/Zd0gkKdGHlal9sW6tCSoSzRolou4SFh1vRyTl7BgGbNFQkI+4g?=
 =?us-ascii?Q?1Yl3R90RRExhbBQ5r5NtU1Si2HcRGZdojbbA9iqjycXfaCbeAvxuGylZA9pQ?=
 =?us-ascii?Q?y84tTwAZpUQMhguji3P7nLX5FXaM3BU+vdDdho47pA3QNKDKcxftX/6/dkXW?=
 =?us-ascii?Q?hMlihSFPsZyDsDsWipJSvIq3lh0Rm7Zai0d8nHkZqG3aBUWlKM3TvhEdOTb1?=
 =?us-ascii?Q?pCZc8TB6G7H7mnX6CVQQcXp6rgsn/WxcMD6GTTp2umfs5p9byULRAZuhlq5R?=
 =?us-ascii?Q?I2OsBBF52v5zJ2c2hlztCAq4j3vVe2U7R7wtTmponN3CMllaLgeQk4/O+XG4?=
 =?us-ascii?Q?BIlOmvJrLMwr8bGkogHJxbE87diZaOIVYg/Evmr7CEC7L+cmpCISaWd3WfPz?=
 =?us-ascii?Q?aHqBKDbiir5qMXrw2Dc+RsvaHovUuGEETsBRhAVoCO4IWu7ofmH1qbmGIVn7?=
 =?us-ascii?Q?R1dZiHBqRBXpGHysVPRpXaDKLYm8zPD6CILPPHSRa3Uai5vkLIYQvcfvfIA2?=
 =?us-ascii?Q?sjVaPXQ1NiKamb36sppqmCG99hQPSoAjtGahdwZ82Wi/9SbRoMPcflNPPCJT?=
 =?us-ascii?Q?rBPtXXFVpU7eKjWdjh1i0rnwB1JXI1uR1Z+rpc6HzTp/KZTxOQ4IY6F5U8rM?=
 =?us-ascii?Q?/NFrCax1//9uasY+HI3Jb9YxJmGymnaTliy/Z6vk2ZDUpZ0H2O1efTsfMSSP?=
 =?us-ascii?Q?PqbhEdZX5aVKNCp42dFdyFxrxNB8871uANJSeBQmDFuPhDrMdowDTkbQ0NQN?=
 =?us-ascii?Q?/Q/c2vpDpk2ioMsFAF0CxUiEDERf7f/X8xfsoLpB/36qrzhtO87xiWwjwD6p?=
 =?us-ascii?Q?GNJLMzrzfkE0TgP+1MsjystfYyq1WJnpHyWIVfD+uQjqUiboxfcsYoIl12hL?=
 =?us-ascii?Q?IW7/m1YtN0wGEj6RB4wh+odH/NpYSE1PYsfIZPHvpYjho5oEBcwGP/wpe2mL?=
 =?us-ascii?Q?jNuzjGdB7zIVSWY2cnaZzbEVF0UMJEEjnIv48BBUPqbwDZ9WrANsBo9COAYQ?=
 =?us-ascii?Q?hwWTMKffd4ru6W+21QomkH1rrnyIlCaHxl1xaCf1P7iPM5A6+hvGF2ZXOTyH?=
 =?us-ascii?Q?6A=3D=3D?=
X-OriginatorOrg: in-advantage.com
X-MS-Exchange-CrossTenant-Network-Message-Id: dd275cd9-6a18-4d43-579c-08daa8a4b254
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2351.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Oct 2022 20:44:14.8664
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 48e842ca-fbd8-4633-a79d-0c955a7d3aae
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 09saHnr0y8aMyWF7n9WaPxG4ntWqOlNZI5Nn3aQ7hU93upjRoIH1xBNMp+VVyK5hVEdm2JoyuYeXg0DFcZniPe4fhbb7+oNFwD9Tx+2j3fE=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR10MB5942
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Sep 27, 2022 at 11:26:00PM +0300, Vladimir Oltean wrote:
> On Sun, Sep 25, 2022 at 05:29:26PM -0700, Colin Foster wrote:
> > +
> > +    The Ocelot family consists of four devices, the VSC7511, VSC7512, VSC7513,
> > +    and the VSC7514. The VSC7513 and VSC7514 both have an internal MIPS
> > +    processor that natively support Linux. Additionally, all four devices
> > +    support control over external interfaces, SPI and PCIe. The Ocelot-Ext
> > +    driver is for the external control portion.
> > +
> > +    The following PHY interface types are supported:
> > +
> > +      - phy-mode = "internal": on ports 0, 1, 2, 3
> 
> More PHY interface types are supported. Please document them all.
> It doesn't matter what the driver supports. Drivers and device tree
> blobs should be able to have different lifetimes. A driver which doesn't
> support the SERDES ports should work with a device tree that defines
> them, and a driver that supports the SERDES ports should work with a
> device tree that doesn't.
> 
> Similar for the other stuff which isn't documented (interrupts, SERDES
> PHY handles etc). Since there is already an example with vsc7514, you
> know how they need to look, even if they don't work yet on your
> hardware, no?
> 

With regards to the interrupts - I don't really have a concept of how
those will work, since there isn't a processor for those lines to
interrupt. So while there is this for the 7514:

interrupts = <18 21 16>;
interrupt-names = "ptp_rdy", "xtr", "fdma";

it seems like there isn't anything to add there.

That is, unless there's something deeper that is going on that I don't
fully understand yet. It wouldn't be the first time and, realistically,
won't be the last. I'll copy the 7514 for now, as I plan to send out an
RFC shortly with all these updates.