Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <2a887f96-93d4-90ed-cfc4-61e895b102cf@huawei.com>
Date:   Sat, 8 Oct 2022 16:47:35 +0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.0
Subject: Re: [PATCH -next] x86/tsc: Make art_related_clocksource static
To:     <tglx@linutronix.de>, <mingo@redhat.com>, <bp@alien8.de>,
        <dave.hansen@linux.intel.com>, <x86@kernel.org>, <hpa@zytor.com>,
        <feng.tang@intel.com>, <gregkh@linuxfoundation.org>,
        <peterz@infradead.org>, <linux-kernel@vger.kernel.org>
References: <20220823021821.3052159-1-chenlifu@huawei.com>
From:   chenlifu <chenlifu@huawei.com>
In-Reply-To: <20220823021821.3052159-1-chenlifu@huawei.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk

在 2022/8/23 10:18, Chen Lifu 写道:
> The symbol is not used outside of the file, so mark it static.
> 
> Fixes the following warning:
> 
> arch/x86/kernel/tsc.c:53:20: warning:
> 	symbol 'art_related_clocksource' was not declared. Should it be static?
> 
> Signed-off-by: Chen Lifu <chenlifu@huawei.com>
> ---
>   arch/x86/kernel/tsc.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/x86/kernel/tsc.c b/arch/x86/kernel/tsc.c
> index cafacb2e58cc..a78e73da4a74 100644
> --- a/arch/x86/kernel/tsc.c
> +++ b/arch/x86/kernel/tsc.c
> @@ -49,11 +49,11 @@ static DEFINE_STATIC_KEY_FALSE(__use_tsc);
>   int tsc_clocksource_reliable;
>   
>   static u32 art_to_tsc_numerator;
>   static u32 art_to_tsc_denominator;
>   static u64 art_to_tsc_offset;
> -struct clocksource *art_related_clocksource;
> +static struct clocksource *art_related_clocksource;
>   
>   struct cyc2ns {
>   	struct cyc2ns_data data[2];	/*  0 + 2*16 = 32 */
>   	seqcount_latch_t   seq;		/* 32 + 4    = 36 */
>   

friendly ping ...