Received: by 2002:a05:6359:c8b:b0:c7:702f:21d4 with SMTP id go11csp2146057rwb; Sat, 8 Oct 2022 03:06:52 -0700 (PDT) X-Google-Smtp-Source: AMsMyM4lZCnqW59yZwn7lF++tp4D5f1DfyK88YRrvxWXXONDec+XumoN273y/Bst7iV5k+a+1s7u X-Received: by 2002:a17:902:8346:b0:178:a33f:89cf with SMTP id z6-20020a170902834600b00178a33f89cfmr8869552pln.9.1665223611897; Sat, 08 Oct 2022 03:06:51 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1665223611; cv=none; d=google.com; s=arc-20160816; b=RJ6Lh0s7vO80EZCXlDwBJJURvEdmZQqj5JH6eGtmCOsLu0sD5pZmGlz1BAVhQHBi1V sAaEg8RBt6TB18x2R3aASz5AsiPDTQNkq8sz6uG/2mcGffrhZmeWT/ZHS+hLtworsBAV rqQxp65IyTOsRstikYV0btzlnlfNWQHCKQXaOTYAXtidoBBgHbGEI8y3vP8lC8YZONca 219mWKZym162bki7Z72dhA+XQuiuM7dkQqmzkIKPWA1o1bik7XFi/BptIeH8o9B1iSQb WcyeFaYLLyW1Q2l+Os9C/4a5boI5lCFDiUKtq3CBiDeCXBlKb/sQLjqVVeIZRQHaE9/m MPZA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=j0csZi8Gzdjhjd/1dekMsZrEJ6oOb8x12MOH5rD4E9w=; b=t3NJ2r2prggWX/OGGvvy2HN+4sm57kTGFs3yG4MDJ67zLKo3DrDFnsMAtg3OPvNolX 9pme6u9Z7JGy1nQwwVbn01IEtrD7EdF14t4+iDHuCTvkkKUNZ79zCngmfLeyCJYxSe+N HEnpDfhUoBoTlP+Yhta2/QQneljcDZS8nbqr5B0PrlV+DHVBeVuknG11EHPRivcnSqkJ SqdnbnU59R05+L2koy8oP2WO2FrksSEL+f292axMDpHOVS95L3Z044nIIc/DiyVnvkhR 4oBV5OPkKH/5j5XxD5d/h6L37blXUQq1/QAHKcHYwxbuL0xgcEEVtDypCvLMnNj27P+j +EtA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b="Ucw/4c33"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id a10-20020a170902ecca00b00179ff32688esi5142526plh.476.2022.10.08.03.06.40; Sat, 08 Oct 2022 03:06:51 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b="Ucw/4c33"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229862AbiJHJvX (ORCPT + 99 others); Sat, 8 Oct 2022 05:51:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57174 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229695AbiJHJvV (ORCPT ); Sat, 8 Oct 2022 05:51:21 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6C53A5FC7; Sat, 8 Oct 2022 02:51:20 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id EBA0D60A5A; Sat, 8 Oct 2022 09:51:19 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C05B9C433D6; Sat, 8 Oct 2022 09:51:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1665222679; bh=x13HOIyD9suTVaFon3YOufV/ukJs++5vFFe4lyLKq8s=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Ucw/4c33UnsaixjglaVysYOQszO9SclUkKPpu4TblPcpqpDbAEsifY4ZLQGzhzWNM mIx5OqB5x06BuuN3HL4HxNBXNk7K/N4x2FKfLJiJjqJLYayNOw1uxO5haIhMQx1ekf isFo1ffZtrZZMtAeGHLHPgFrA2T6xgE7iTcFMyQU= Date: Sat, 8 Oct 2022 11:52:01 +0200 From: Greg Kroah-Hartman To: Zhou Furong Cc: Elliot Berman , Bjorn Andersson , Jiri Slaby , Murali Nalajala , Trilok Soni , Srivatsa Vaddagiri , Carl van Schaik , Andy Gross , Dmitry Baryshkov , Jassi Brar , linux-arm-kernel@lists.infradead.org, Mark Rutland , Lorenzo Pieralisi , Sudeep Holla , Marc Zyngier , Rob Herring , Krzysztof Kozlowski , Jonathan Corbet , Will Deacon , Catalin Marinas , Arnd Bergmann , devicetree@vger.kernel.org, linux-doc@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 14/14] tty: gunyah: Add tty console driver for RM Console Services Message-ID: References: <20220928195633.2348848-1-quic_eberman@quicinc.com> <20220928195633.2348848-15-quic_eberman@quicinc.com> <4cb5e7eb-1571-ed91-e1da-b4223a26f41c@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4cb5e7eb-1571-ed91-e1da-b4223a26f41c@linux.intel.com> X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Oct 08, 2022 at 03:41:53PM +0800, Zhou Furong wrote: > > > > + > > > +/* > > > + * The Linux TTY code does not support dynamic addition of tty derived devices so we need to know > > > + * how many tty devices we might need when space is allocated for the tty device. Since VMs might be > > > + * added/removed dynamically, we need to make sure we have enough allocated. > > > > Wrap comments at 80 columns please. > > > > checkpatch has extend LINE MAX to 100,do we still suggest wrap to 80? For comment blocks, yes please.