Received: by 2002:a05:6359:c8b:b0:c7:702f:21d4 with SMTP id go11csp2526928rwb; Sat, 8 Oct 2022 09:16:00 -0700 (PDT) X-Google-Smtp-Source: AMsMyM5NpJ7BjQHj0WaV5Vtec6Y6ziV3u2viuGCveYujxC4CratIYQ2Qlpkl8MErpNCKO68eQpTl X-Received: by 2002:a63:4c64:0:b0:442:1d06:de0c with SMTP id m36-20020a634c64000000b004421d06de0cmr9576614pgl.55.1665245760390; Sat, 08 Oct 2022 09:16:00 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1665245760; cv=none; d=google.com; s=arc-20160816; b=q+1N3jNXuduBQaZprx8xDMwSDGobaXsxSkVWhUW9C4TFZfu6o6GFJiNW3kFfoE9YbW Lc6kHl0V6MKATrvAkfj9tu+5diHKqJctrlPmDQHfZ6myV9mkjLXZ0OHBbDDxLBTqkUyq oMI81mmXcFtgjX/vj/tf5dumLF3dDaEKkE9XcraTzFitljFyyWXmmS51+gxxhXSbEEXM 3iiVz3G2DVtiokMf12+fTpMoxfM/QmuvUD3eTwKQQtKrtMmZLR05dKuA7biZe/Wed5xI x0dqJwyol1hWzvy92ordbF8eRb8g+pTYynnGaeXj4d+HmxrjIiRCGwRyBMHydGkzY8Ul y3GQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=HF28Q8th4XcTms4byBChnIDrf/4m4l69xXoyfa21q/Q=; b=hBIDE9OIQPYXblXhbMTeI1bLmzZP2gExRSgDzD8zl0oa8QtyNaeUTPYNXsw/ah7TLl CP+ha4K0aV3c5/bOU1sMc91vUAdjvNy+Yt21Usep9YmZs4JOBjXhL3C0uvnFcaKCKBVU JbUbCipF8W3/0D31xrr4Ddq6coXd6lCtw/NwgU/fLyDZtRcPKuhLkg3Co/cYs7xqMPB6 pznFLPkhFHpY2VL7WM2GaTmguFbpCB8dkcbhbo1p39AV3xlVCNJLup7ibXJxbZWrklVa /mYZ0ok6KITSct6yM+UbYz8aar8B6jaDItfhXbEKg9uCcGkcmJw2ixPvj5UDcaVWWdFN PuJA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=awHIACMQ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id j71-20020a636e4a000000b004308011fd84si6550526pgc.426.2022.10.08.09.15.38; Sat, 08 Oct 2022 09:16:00 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=awHIACMQ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229820AbiJHPja (ORCPT + 99 others); Sat, 8 Oct 2022 11:39:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57844 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229459AbiJHPj2 (ORCPT ); Sat, 8 Oct 2022 11:39:28 -0400 Received: from sin.source.kernel.org (sin.source.kernel.org [IPv6:2604:1380:40e1:4800::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 92D2C4BD14; Sat, 8 Oct 2022 08:39:26 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sin.source.kernel.org (Postfix) with ESMTPS id B19AACE0AFF; Sat, 8 Oct 2022 15:39:24 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 89939C433C1; Sat, 8 Oct 2022 15:39:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1665243562; bh=mz2vCGCOEvfMyxm2IwhI2TPNWcuWcXnjlouOu3uMn3Y=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=awHIACMQzsGRgKAOjJH2e5yeNW0Y+wbsoTADVnHWhiUhB+7iyhDIeDdr+v3bfXvnN w7DuLcqkly9OfVpjny7gO1OatnBu1899qHklv8iC+h1lO1STEuauuz9KYcXFleCYkp 2t0YTsqshSJYDEKfhQWkEfSxBy/c0W16DtAaQGqs= Date: Sat, 8 Oct 2022 17:40:04 +0200 From: Greg KH To: 3090101217@zju.edu.cn Cc: pawell@cadence.com, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Jing Leng Subject: Re: [PATCH] usb: cdnsp: Fix wrong transmission direction of EP0 Message-ID: References: <20220926075902.7390-1-3090101217@zju.edu.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220926075902.7390-1-3090101217@zju.edu.cn> X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Sep 26, 2022 at 03:59:02PM +0800, 3090101217@zju.edu.cn wrote: > From: Jing Leng > > EP0 transfer is bi-directional, but in the cdnsp gadget, the > transmission direction of EP0 is not changed after it is > initialized to IN, so the OUT data from EP0 received by the host > is invalid. > > The value of ep0_expect_in will change according to the value of > bRequestType in the SETUP transaction of control transfer, so we > can use it as the transmission direction of EP0. > > Signed-off-by: Jing Leng Your email does not match your From: line and the signature of it shows that it is invalid and does not pass authentication :( Please work with your university to get an email address that works properly. thanks, greg k-h