Received: by 2002:a05:6359:c8b:b0:c7:702f:21d4 with SMTP id go11csp2665396rwb; Sat, 8 Oct 2022 11:53:56 -0700 (PDT) X-Google-Smtp-Source: AMsMyM6jW/L/E5eDjbVXmGVV4ZF9GyLeiv8tn/H3RepFMrBuDrdk6yNCQLsnG9IDZKP/CIyYZDzl X-Received: by 2002:a05:6402:1356:b0:459:3c9e:81d4 with SMTP id y22-20020a056402135600b004593c9e81d4mr10228530edw.148.1665255236312; Sat, 08 Oct 2022 11:53:56 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1665255236; cv=none; d=google.com; s=arc-20160816; b=WEc6UkNO9IPIi2+fY0aV2gzIuHwGQdAMSzy7tzxlwSzMXwyrdewkK8Zhe1ml0mUMA2 FtvLLM+Z5LEhhXrEYnPI3/nHV3EXymT4LGS/wJ1icbsi0+bL2Ci1whzyhNcoCRFlWkW2 vzekftOb67NUnI6QbFertFSJ7Z5WHgjTupVCZMj0WO9UAP/SgmibH7ylm6fdd0mp2m2G T+PQbAfzsepwKBlUBTM4+yA8FBAh67tPpXQBcXZqbPaK509INv5DzpHengjRnGc2zr9I uPa4x2+6+waCcRdzLQQlJ69seZWwK8lKG+fY6pfoFn65mPZKeYk5ccRFS+F6ew1BOKR2 sXXg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:organization:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=fuQvtmozNjWF6W+AIdgTKeV86ghSuBANYQGvfUTruY4=; b=vOBCejvAdtpo43sMvRXT1TiZGRcFukpc1O64FluZiAfOTVK6lORVNoR2QxOO9Ggf7y UhNyAsWcYWeQXMcpKUlnkcn+KKTNkRQxQT/as2XkNt3qqBgYp75zPsGX13Pe6/s/yLOY f+zHmAk+a4mcl6Zlqr0wcYSadhuGVxiYSVvElgLaT2yXVOcq6ZIwJnPUQ+s+pJ7kKySd dGALrsXpROZ4QxU39VcRo0MduKBTwc6CCA+mL8oyQlKXlhLlZUgnpXMPqjaW1lj6UYio mH+6txqcG7c4G+89AMYrIw36bYHYJPt0/ZfSBny9KUe/RJ5Zjbtm9Ml0Wl+4+83cNOww xfHA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=TE+ZuIg9; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id x13-20020a05640226cd00b0045a378a24b6si5068966edd.512.2022.10.08.11.53.29; Sat, 08 Oct 2022 11:53:56 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=TE+ZuIg9; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231127AbiJHSVn (ORCPT + 99 others); Sat, 8 Oct 2022 14:21:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42458 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229867AbiJHSVl (ORCPT ); Sat, 8 Oct 2022 14:21:41 -0400 Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 423E641511 for ; Sat, 8 Oct 2022 11:21:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1665253301; x=1696789301; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=OWIiubz5fdA83E6sHScFPXfGeMg/96S0x3o/FGgfFQA=; b=TE+ZuIg9CuSFf+RTGOaNZ6WM2teyBnSTetcHZlJW8YL7b60S0GPY8Uh3 /IrIaqwIO7IFyNZWpKkKuyih1TmEudgoH+7xU61n44n8tyyW+J/aC2sWA 6me+M4YMr8zBDAtDKwJPaElx/5mA0ehr3AR3H9ujzrmtMhRwu95lwUME/ z+UaoS0eVHYC5HxDDhc77gdD5yJem0G72i/UDzb4pv8WqnNY82ToT+JjE 2qCc2Sam/kOJEdqKnDmHsylM71+9165V3sOpYJ7yiHRLjZVYcpS0EWbSt OpQriIatXB9pvvnecHL+X7A3lrUSSy67D4FX1tdszxsJ3dyxrmRtDZOER g==; X-IronPort-AV: E=McAfee;i="6500,9779,10494"; a="305558508" X-IronPort-AV: E=Sophos;i="5.95,170,1661842800"; d="scan'208";a="305558508" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Oct 2022 11:21:40 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10494"; a="658706046" X-IronPort-AV: E=Sophos;i="5.95,170,1661842800"; d="scan'208";a="658706046" Received: from smile.fi.intel.com ([10.237.72.54]) by orsmga001.jf.intel.com with ESMTP; 08 Oct 2022 11:21:37 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1ohES7-0048li-2p; Sat, 08 Oct 2022 21:21:35 +0300 Date: Sat, 8 Oct 2022 21:21:35 +0300 From: Andy Shevchenko To: "jay.xu@rock-chips.com" Cc: "linus.walleij" , Heiko =?iso-8859-1?Q?St=FCbner?= , Bartosz Golaszewski , "robert.moore" , robh , "open list:ARM/Rockchip SoC..." , Linux Kernel Mailing List , lenb , rafael Subject: Re: Re: [PATCH 11/20] gpio/rockchip: add of_node for gpiochip Message-ID: References: <20220920103108.23074-1-jay.xu@rock-chips.com> <20220920103108.23074-12-jay.xu@rock-chips.com> <2022100814192810242455@rock-chips.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2022100814192810242455@rock-chips.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Oct 08, 2022 at 02:19:28PM +0800, jay.xu@rock-chips.com wrote: ... > the gc->of_node is a fix for my patch serial, without this the gpiochip will fail to register. Do not use of_node. We have parent and fwnode members, use them according to your needs. -- With Best Regards, Andy Shevchenko