Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Colin Foster <colin.foster@in-advantage.com>
To:     netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
        devicetree@vger.kernel.org
Cc:     Russell King <linux@armlinux.org.uk>, UNGLinuxDriver@microchip.com,
        Alexandre Belloni <alexandre.belloni@bootlin.com>,
        Claudiu Manoil <claudiu.manoil@nxp.com>,
        Paolo Abeni <pabeni@redhat.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Eric Dumazet <edumazet@google.com>,
        "David S. Miller" <davem@davemloft.net>,
        Vladimir Oltean <olteanv@gmail.com>,
        Florian Fainelli <f.fainelli@gmail.com>,
        Vivien Didelot <vivien.didelot@gmail.com>,
        Andrew Lunn <andrew@lunn.ch>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Rob Herring <robh+dt@kernel.org>, Lee Jones <lee@kernel.org>
Subject: [RFC v4 net-next 08/17] net: dsa: felix: populate mac_capabilities for all ports
Date:   Sat,  8 Oct 2022 11:51:43 -0700
Message-Id: <20221008185152.2411007-9-colin.foster@in-advantage.com>
In-Reply-To: <20221008185152.2411007-1-colin.foster@in-advantage.com>
References: <20221008185152.2411007-1-colin.foster@in-advantage.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?gJMaNkYtOmEQjPZCCnbIxyx8NY7fSCoZ+ia1c+9zWF5co+j60AkjkfA1UIfZ?=
 =?us-ascii?Q?sVyM+SiRDvJ7FWeAC7HNRCcv3ILz+0HI+KlOOYUP7L28ZXVU3XrdUrl0VNBx?=
 =?us-ascii?Q?9HTcZDQdPxrvwOK81UyPC202P4dnoIf1QCDfab+PpXTEnihcxFZxzUc8bk8+?=
 =?us-ascii?Q?qb8TsUBZUPWs/xrJz2yFGAMXR+0Lpif3AfrZ5FFtONEMtbznifK7ANXzPFiz?=
 =?us-ascii?Q?Aaf30A5IweFfo/GpGgM1yfjW/5yHD8mSlcZ/nzoj0azthVYg2Q+cyPfS+lP2?=
 =?us-ascii?Q?TB+qq6ty1HqoXEZNSSly0G/JS5NQ8BGbonSFjEkiXoDiP7TOBFPU6XwCytfM?=
 =?us-ascii?Q?/PNhLd+gund+OxTuQqc9Mc3pq/CNByRk1eULMdfJZ0v/HU3XaNauVqUn1HYa?=
 =?us-ascii?Q?uaxtSPlR9tTvZ0gvK1rcdgcHT3K6rq33c0egcK/SykBNLxkp7paq3XBmVmGE?=
 =?us-ascii?Q?v84shAfh8gp06fbZO7u3s83mY3GaYnX7R7ZFYuUOAkQbqrNl+4eUP0nYyixP?=
 =?us-ascii?Q?E8azzYmSNFeS0nCMklZkYqyjYwZHXA05bb31ugRcxK/p3G7d7VJAbg/AN1vh?=
 =?us-ascii?Q?6txfuipLi9ed+oR3inKqmoWFv2ide/mllncgtJw/pCwdNejGN+DMF8lkR/uh?=
 =?us-ascii?Q?34DRnjN0eENtBCXVjInJD0oY0TyRNv8GmSKHtwXHY4GAOa0genZGHXUSw3JN?=
 =?us-ascii?Q?HAuNh93j//6ktKZvi8UEvzcfUFsZUynTw8tLOwr3uv5pjqf10WpxaqVpeUNp?=
 =?us-ascii?Q?ErpnVDMNGw8Xu4Yyl0NFdMFYI5bpfJFah8Qm6pzByOTK+HOk8VBIxL0Lp9/b?=
 =?us-ascii?Q?F/kMWCIPgkzk/Fd2DCmP4wGqIGfVb7d5TBWfUFAyszyEnbNMY9b1wLVJv9jn?=
 =?us-ascii?Q?h8GsN3YfXO1pTB0sf80kNJs2gtQh9pziaYS0/e/XBbYycM9OA9YNp58PiYGF?=
 =?us-ascii?Q?GXn+ZClgURaNFhv6D0W3DOOaomFbrymILyfuorqc73oGdHIGPuXi58mwI84b?=
 =?us-ascii?Q?7eALXxkEdkoRvw1z/1WzUk1vpubjeIxQoHFFqgUHPnfN+87KVao8adkFnbNs?=
 =?us-ascii?Q?MHX2TizmyMqIkA9IdYnpsrCtLwD7N5ki2E627DtFqPVNanNyMzg/HR3drfh+?=
 =?us-ascii?Q?UiMqs+/a5InZXmVtfOzwfiDblikPw5VtNkcc7MYNGQpKLRThX/14Ovd+i31o?=
 =?us-ascii?Q?b5Vdg2MpPghVODVf3CzW06oyaClFyEfoQtzNazNPx1iQc1c+olcvIceLc5Ne?=
 =?us-ascii?Q?JqAw+1G/UrOo/VZiNs5UGYf0qZHnzDdbg01K2RMQH6nbIukgKmueO8upAO4H?=
 =?us-ascii?Q?9QEXOLXYK8ZCoVbhwvXa13F+HfeEmUSeHqBlM09uJfD7YSy1+4DIiRlN7DXp?=
 =?us-ascii?Q?otTSDgzAnu/54N+kxdQ+PRVLnNNH135rzaXexlasHblBy3GO9E5LTKoZ0Odg?=
 =?us-ascii?Q?+W/Fd895mjEaHAA+bzymAT+Yndb+oTvZcHNtz6jykQ0XPFqQAsTRAOmfmK4G?=
 =?us-ascii?Q?ABoScfl7xEVPaTNOx633+lc7iJA4VGXXdmTFzpzdaWbGhjlSsTpUeXeiSuje?=
 =?us-ascii?Q?uXlIBnaNAIQshpmegebewsbnq/idY7dzcSLqMAu3OuTrORDcbBzQzKqggA3o?=
 =?us-ascii?Q?RSg9A7C1O4kisG+s+YUJNaA=3D?=
X-OriginatorOrg: in-advantage.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c9fb9a7c-2a02-4cd1-5b21-08daa95e3336
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2351.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Oct 2022 18:52:07.9129
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 48e842ca-fbd8-4633-a79d-0c955a7d3aae
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: h0Rm1lWymZVujPG6i0ILLMsSYz6uRDT5S9mY08z6N7piTbwYysUUzZXKuVrf1dl6jGPIFLqEVTAG06KG9D1+md1QjcMDI5eseruR1KVANTs=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR10MB6129
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

phylink_generic_validate() requires that mac_capabilities is correctly
populated. While no existing felix drivers have used
phylink_generic_validate(), the ocelot_ext.c driver will. Populate this
element so the use of existing functions is possible.

Signed-off-by: Colin Foster <colin.foster@in-advantage.com>
---

v3-v4
    * No change

v2
    * Updated commit message to indicate "no existing felix drivers"
      instead of "no existing drivers"

v1 from previous RFC:
    * New patch

---
 drivers/net/dsa/ocelot/felix.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/net/dsa/ocelot/felix.c b/drivers/net/dsa/ocelot/felix.c
index d56f6f67f648..1d938675bd3a 100644
--- a/drivers/net/dsa/ocelot/felix.c
+++ b/drivers/net/dsa/ocelot/felix.c
@@ -1050,6 +1050,9 @@ static void felix_phylink_get_caps(struct dsa_switch *ds, int port,
 
 	__set_bit(ocelot->ports[port]->phy_mode,
 		  config->supported_interfaces);
+
+	config->mac_capabilities = MAC_SYM_PAUSE | MAC_ASYM_PAUSE | MAC_10 |
+				   MAC_100 | MAC_1000FD | MAC_2500FD;
 }
 
 static void felix_phylink_validate(struct dsa_switch *ds, int port,
-- 
2.25.1