Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sat, 8 Oct 2022 16:19:28 -0400
From:   Steven Rostedt <rostedt@goodmis.org>
To:     Leo Yan <leo.yan@linaro.org>
Cc:     Ingo Molnar <mingo@redhat.com>, Jonathan Corbet <corbet@lwn.net>,
        linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] docs: ftrace: Correct access mode
Message-ID: <20221008161928.7098b068@rorschach.local.home>
In-Reply-To: <20221008083250.3160-1-leo.yan@linaro.org>
References: <20221008083250.3160-1-leo.yan@linaro.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Sat,  8 Oct 2022 08:32:50 +0000
Leo Yan <leo.yan@linaro.org> wrote:

> The documentation gives an example for opening trace marker with
> write-only mode, but the flag WR_ONLY is not defined by glibc.
> 
> Use O_WRONLY to replace it.
> 
> Signed-off-by: Leo Yan <leo.yan@linaro.org>
> ---
>  Documentation/trace/ftrace.rst | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Documentation/trace/ftrace.rst b/Documentation/trace/ftrace.rst
> index b37dc19e4d40..60bceb018d6a 100644
> --- a/Documentation/trace/ftrace.rst
> +++ b/Documentation/trace/ftrace.rst
> @@ -564,7 +564,7 @@ of ftrace. Here is a list of some of the key files:
>  
>  	start::
>  
> -		trace_fd = open("trace_marker", WR_ONLY);
> +		trace_fd = open("trace_marker", O_WRONLY);

Acked-by: Steven Rostedt (Google) <rostedt@goodmis.org>

-- Steve

>  
>  	Note: Writing into the trace_marker file can also initiate triggers
>  	      that are written into /sys/kernel/tracing/events/ftrace/print/trigger