Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <298867dd-01d9-cd61-cdaa-95bbaf2dd2e4@bytedance.com>
Date:   Sun, 9 Oct 2022 08:53:21 +0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.3.0
Subject: Re: [PATCH 1/3] ipmi: fix msg stack when IPMI is disconnected
Content-Language: en-US
To:     minyard@acm.org
Cc:     openipmi-developer@lists.sourceforge.net,
        linux-kernel@vger.kernel.org, qi.zheng@linux.dev
References: <20221007092617.87597-1-zhangyuchen.lcr@bytedance.com>
 <20221007092617.87597-2-zhangyuchen.lcr@bytedance.com>
 <Y0CBbRqGPDU3g9hQ@minyard.net>
 <28367829-10e1-1a74-5572-ba01b8f8b716@bytedance.com>
 <Y0FjriRusk0H4Fxp@minyard.net>
From:   Yuchen Zhang <zhangyuchen.lcr@bytedance.com>
In-Reply-To: <Y0FjriRusk0H4Fxp@minyard.net>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

Ok, I will send v2 today.

On 10/8/22 7:49 PM, Corey Minyard wrote:
> On Sat, Oct 08, 2022 at 09:36:16AM +0800, Yuchen Zhang wrote:
>>> Also, the following is in start_kcs_transaction():
>>>
>>> 	if ((kcs->state != KCS_IDLE) && (kcs->state != KCS_HOSED)) {
>>> 		dev_warn(kcs->io->dev, "KCS in invalid state %d\n", kcs->state);
>>> 		return IPMI_NOT_IN_MY_STATE_ERR;
>>> 	}
>>>
>>> You probably need to remove the (kcs->state != KCS_HOSED) part of this
>>> now.  Would you agree?
>>>
>>> -corey
>>>
>> I agree. KCS_HOSED state should be an invalid state.
> 
> Can you make this change, run a quick test, and re-submit this one
> patch?  With that, I can include this.
> 
> Thanks,
> 
> -corey

--
Thanks,
Zhang Yuchen