Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sun, 09 Oct 2022 03:31:33 +0100
Message-ID: <87r0zhhgmy.wl-maz@kernel.org>
From:   Marc Zyngier <maz@kernel.org>
To:     Jianmin Lv <lvjianmin@loongson.cn>
Cc:     Thomas Gleixner <tglx@linutronix.de>, linux-kernel@vger.kernel.org,
        loongarch@lists.linux.dev, Jiaxun Yang <jiaxun.yang@flygoat.com>,
        Huacai Chen <chenhuacai@loongson.cn>,
        Bjorn Helgaas <bhelgaas@google.com>,
        Len Brown <lenb@kernel.org>, rafael@kernel.org,
        linux-pci@vger.kernel.org, linux-acpi@vger.kernel.org
Subject: Re: [PATCH V2 1/2] irqchip/loongson-pch-pic: Support to set irq type for ACPI path
In-Reply-To: <7d3894f9-9708-0b4f-b485-f167408feede@loongson.cn>
References: <20221008025150.10734-1-lvjianmin@loongson.cn>
        <20221008025150.10734-2-lvjianmin@loongson.cn>
        <87v8othkgz.wl-maz@kernel.org>
        <7d3894f9-9708-0b4f-b485-f167408feede@loongson.cn>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue)
 FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1
 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO)
MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue")
Content-Type: text/plain; charset=US-ASCII
Precedence: bulk

On Sun, 09 Oct 2022 03:26:21 +0100,
Jianmin Lv <lvjianmin@loongson.cn> wrote:
> 
> Ok, thanks, I'll separate this patch, so we have to make the patch
> fixing PCI INTx handling to be after the patch supporting for the LPIC
> model to avoid kernel hang, yes?

Pick whatever order fits your system, really. But don't mix generic
ACPI changes and irqchip code in the same patch, that's just wrong.

Thanks,

	M.

-- 
Without deviation from the norm, progress is not possible.