Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <64aedb51-b0b4-d412-b5ad-67d50f12ad8b@huaweicloud.com>
Date:   Sun, 9 Oct 2022 11:34:22 +0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.9.0
Subject: Re: [PATCH] clk: bcm: rpi: Fix an out-of-bound access to
 raspberrypi_clk_variants
Content-Language: en-US
To:     Stefan Wahren <stefan.wahren@i2se.com>,
        linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org,
        linux-rpi-kernel@lists.infradead.org,
        linux-arm-kernel@lists.infradead.org
Cc:     Michael Turquette <mturquette@baylibre.com>,
        Stephen Boyd <sboyd@kernel.org>,
        Florian Fainelli <f.fainelli@gmail.com>,
        Broadcom internal kernel review list 
        <bcm-kernel-feedback-list@broadcom.com>,
        Maxime Ripard <maxime@cerno.tech>,
        Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
        Xu Kuohai <xukuohai@huawei.com>
References: <20221008144544.283945-1-xukuohai@huaweicloud.com>
 <bce9efac-15a8-75e5-6f3f-bc62e33d0184@i2se.com>
From:   Xu Kuohai <xukuohai@huaweicloud.com>
In-Reply-To: <bce9efac-15a8-75e5-6f3f-bc62e33d0184@i2se.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 10/9/2022 1:07 AM, Stefan Wahren wrote:
> Hi Xu,
> 
> Am 08.10.22 um 16:45 schrieb Xu Kuohai:
>> From: Xu Kuohai <xukuohai@huawei.com>
>>
>> KASAN reports an out-of-bound access to raspberrypi_clk_variants[]:
>>
>> ==================================================================
>> BUG: KASAN: global-out-of-bounds in raspberrypi_clk_probe+0x1dc/0x690
>> Read of size 1 at addr ffffcc7116d615a0 by task kworker/u8:0/8
>>
>> CPU: 1 PID: 8 Comm: kworker/u8:0 Not tainted 6.0.0-rc3-00900-g08f4df4a3c53 raspberrypi#10
> 
> this kernel is a little bit older and doesn't contain bc163555603e ("clk: bcm: rpi: Prevent out-of-bounds access").
> 
> Can you please check Linux 6.0?
> 

Yes, the kernel branch I used was not updated, and the KASAN warning was gone after switching to 6.0 kernel, thanks.

> Best regards
>