Received: by 2002:a05:6359:c8b:b0:c7:702f:21d4 with SMTP id go11csp3196037rwb; Sun, 9 Oct 2022 00:12:34 -0700 (PDT) X-Google-Smtp-Source: AMsMyM4QsxXkBgTPIZu8civosD+UxD3vvhbz53frZNsKgDvvRWYt9xPsvatULgv+60gLri8QlIXP X-Received: by 2002:a17:90b:811:b0:20b:16ca:2abc with SMTP id bk17-20020a17090b081100b0020b16ca2abcmr14375325pjb.163.1665299554447; Sun, 09 Oct 2022 00:12:34 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1665299554; cv=none; d=google.com; s=arc-20160816; b=tZlilGdK5zF+gdBx/Y1nQJznfquhRlgBMzLaIYzCHJgLHgZBqkHd+DcH76jxgiHRai aTA3DVL63qHdy2SG8x78+v+/iktzgyg2fy67JUhTw6rP//T1D5gwPZPO76wb0yX1ZP2A XAorVP5Hmo7gNDNxk7SJ0Ti0G6o+NfOZIknHSlMJvYBBRX4fsVPa8YFeOtKx5Z2Er4Ur 5gdRWn92Xgwd9iCiFAr4oh2fO1V0+V/rbRzes1NyFqLBFwst50guputmWtYjhGcnSm4o oAzf1/rxnW/3kJS7JUKrPXYC5QT94eakey8M7Kp8569bzf8IoEaXXIVEIkJj4iIK0rMx n8vA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=wFbjZPAAqkxo59RT/6fWIdU43K/0oPb3Wzilaj0rZ2Y=; b=TFV+jfElrSxZKqKgvfJarH0Lxb6OPWr1311EMpwBW0W34bE7m8+5OR20te1ULBz7j8 xb0/Dkji3bWIxUgzfEsxzd2bZzpjdlJ74CiNqhNRdbnd2mUMPRM3Ac9rtLHmjM5rcFfI h5rdyDSTPUr22Mk+TAd/tSCq6vcb2T7rybjo2pWQ2cvpZkkDoYfgVvczUh1vpdR/2NnB 1/Ej8SU5paIpkM63uZx8Ou6nk5Rib/Gg5HGZRPtPkXnQYMVLy1078f/1Y/RNAG9Y5V3m wqWnZMdgaJ/BksCf7yWCFiFaD+j7KZZWp3QoFlVR/ReYpp1Gh27qq5Anr3691D7i7ySn zEjQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=fHNCuCS+; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id t19-20020a635353000000b004349d87a601si8841539pgl.27.2022.10.09.00.12.21; Sun, 09 Oct 2022 00:12:34 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=fHNCuCS+; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229977AbiJIGw3 (ORCPT + 99 others); Sun, 9 Oct 2022 02:52:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46240 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229553AbiJIGw2 (ORCPT ); Sun, 9 Oct 2022 02:52:28 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 95B732A426; Sat, 8 Oct 2022 23:52:27 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 53813B80B02; Sun, 9 Oct 2022 06:52:26 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9F405C433C1; Sun, 9 Oct 2022 06:52:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1665298345; bh=hY2moWN7aawBvjhYz3VFmMcafpGLPLpnIUUqaC4drow=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=fHNCuCS+gEepH4lsAV9JqYFZIn/NCllLjIpdUjNP0iOxVlrodnLjY9xleiEM1vNJw SohQbjKkag8Tb6GxJhyT+sPdBi1aItTWHMCZjY2MXFp1zPw/byzs5IKh3AbOWGo0fW O6j2I0Q4qCl0XhCHhS3LwEwTtuXyHINnlsMye1zk= Date: Sun, 9 Oct 2022 08:53:07 +0200 From: Greg Kroah-Hartman To: Dongliang Mu Cc: Pawel Laszczak , Dongliang Mu , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] usb: cdns3: adjust the partial logic of cdnsp_pci_remove Message-ID: References: <20221009053245.154922-1-dzm91@hust.edu.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221009053245.154922-1-dzm91@hust.edu.cn> X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Oct 09, 2022 at 01:32:45PM +0800, Dongliang Mu wrote: > From: Dongliang Mu > > In cdnsp_pci_remove, if pci_is_enabled returns true, it will > call cdns_remove; else it will call kfree. Then both control flow > goes to pci_dev_put. > > Adjust this logic by modifying it to an if else. > > Signed-off-by: Dongliang Mu Your email address does not match your From: address, and your From: address is saying it is being spoofed and not correct :( Please work with your school to fix your email system and do not use gmail to hide it. thanks, greg k-h