Received: by 2002:a05:6359:c8b:b0:c7:702f:21d4 with SMTP id go11csp3238437rwb; Sun, 9 Oct 2022 01:13:05 -0700 (PDT) X-Google-Smtp-Source: AMsMyM4AcZI/vlGjuu1y/UPjE6sjEfejoKapVK1ZjYmMfOUbUo/TYEIyVH07IsJ1lDEqFGpz7NkD X-Received: by 2002:a17:906:5a65:b0:78d:3610:9b8 with SMTP id my37-20020a1709065a6500b0078d361009b8mr10157493ejc.437.1665303185050; Sun, 09 Oct 2022 01:13:05 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1665303185; cv=none; d=google.com; s=arc-20160816; b=CCXYY7y9Gco5kSafVAaK1ATuhq5Hpd6adRvER0hyiHlhO66KlyPGJX2/xcnD+6mlje HGr4KTMDWZzRPY1G/F6qH5nk8w21ReicSW08M9KfPVGM1EMtVOyTrJbG3ir3Fe1U/tDO +MbM2jxgrMIDhBdRyOs0P9yStZntA09bQRB0OUiqqhpH+UrnX0T/J5l3g7dR7BpW5+Oj cCAm1w4/698C1Zf64bX2xUs4i7v8f+OGiZR9fUm/Reu7n5qnuGPJph0K9OxUXXKz4vIx BW0AoJHesR/8cFFLMQgN3X1hNUjDhlrlHzOLViO0ghRD3oHThHgv1LBJMQZKyPpPrh74 kUdg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=TcltXX1LdWoOAyefprBIZA4YErGm5XD+4QXIrmFx73U=; b=X5BGx3BH9wElBmXp87RDFA60RXqvoEcgAhe6AEQgh6hJ7tQCIAcU1b15+3ULa7zro6 iggoAnFkgkGUxSkoZjp6cT7kr7NpXQSzRQP08O58+xoEcCJmLUZVnEOCtS/1rUDpzIXa hlazjEzvBJuHdpxtjKvdsGvMLTlDllpa5gjM8PK1G7HDkINo4xbaTm7axjPSnmYZcdm0 mbbBdpSuDLE2VFJan8fZ0xYkckX19Zy82CR58HZ/mTIUpkvgXTZO5emsyjQoyLBpi5n3 4ZNQC21s6qCZICAep9AmygYNXDC+Kxi8jFSgiPwFr/EZ0zX2ybh83WgmeAsi7w/fGfQH jzww== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=Mf1Rn9gL; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id dy19-20020a05640231f300b004593bcff7e5si6338658edb.475.2022.10.09.01.12.38; Sun, 09 Oct 2022 01:13:05 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=Mf1Rn9gL; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229919AbiJIHeX (ORCPT + 99 others); Sun, 9 Oct 2022 03:34:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42780 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229463AbiJIHeV (ORCPT ); Sun, 9 Oct 2022 03:34:21 -0400 Received: from mail-ej1-x62b.google.com (mail-ej1-x62b.google.com [IPv6:2a00:1450:4864:20::62b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 158573386C; Sun, 9 Oct 2022 00:34:20 -0700 (PDT) Received: by mail-ej1-x62b.google.com with SMTP id bj12so19099217ejb.13; Sun, 09 Oct 2022 00:34:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=TcltXX1LdWoOAyefprBIZA4YErGm5XD+4QXIrmFx73U=; b=Mf1Rn9gLGA6iv8vxQbOOODoJJCL/sBVy+ZOQflKcDqjO6kFJ2WeSvKrFRjqjhabGdl 55sETv4Dqd8VVhjwlxVCkhDL9qXAJTfSWUZL4c1VgBv67+ivy4RPiZc1DdyAiZoloq2V cFLTAjcLWx6m2Ph0q5ZOnk5WEK7fMmPwUucrZHseo/7iRc2P2tZhoLAe/9/ezIzKnRXa a73BN8lRoE5cXAEXY2jYVOAuMWOCDi3T1hTXTX2VCcRQzUyWeCFGBO0liAHAstQN4Ian gi9lqdiFaLqfx9N7ZAvkkKf4pjBtjxpLV3AA9+3SBWt4kpINDyIZmR0cCg1RytRO9Cwb pokQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=TcltXX1LdWoOAyefprBIZA4YErGm5XD+4QXIrmFx73U=; b=01lgSw0nXb+bY9I2+b2237UIFDk9U81o7Gbvl3sAdRB70GyMMtYGUvcguCjYH7zWpM olOh//n8H21gr98u9lDg79to5+sUC7V333i3UEyR9d9scQH1NEbfApxGqXx/ZaSJr8tC NSYQ26i2e/a2e7m8ZzDKJRP7bIuwmscqi3T05eRmE/Rm+gGuwdRha/x7qLqU66xKCRt+ qJGGtkT4QOb42V7Ky59S8O0u9Q7aAjG/565jXuL/oV7uQrGO2wI+Iiwhkft5TWm7dUT5 Lq6ukNrUBGt/FHMbIJpy2Ka+aw8ikSYMWN5odjAgoVQZo9EIqOdteRgP2z+MybbesScH RV1Q== X-Gm-Message-State: ACrzQf2TdivI8DR4xIbRDzq2HpBg9nnuoFHfY3/boYoG/j0fRCbtCZke Sj3AepKthnAf7FNSlDLAIhXVyw/uVJh7wGyE9jo= X-Received: by 2002:a17:906:7310:b0:782:cfd4:9c07 with SMTP id di16-20020a170906731000b00782cfd49c07mr10841307ejc.708.1665300858584; Sun, 09 Oct 2022 00:34:18 -0700 (PDT) MIME-Version: 1.0 References: <20221009053245.154922-1-dzm91@hust.edu.cn> In-Reply-To: From: Dongliang Mu Date: Sun, 9 Oct 2022 15:33:51 +0800 Message-ID: Subject: Re: [PATCH] usb: cdns3: adjust the partial logic of cdnsp_pci_remove To: Greg Kroah-Hartman Cc: Dongliang Mu , Pawel Laszczak , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Oct 9, 2022 at 2:52 PM Greg Kroah-Hartman wrote: > > On Sun, Oct 09, 2022 at 01:32:45PM +0800, Dongliang Mu wrote: > > From: Dongliang Mu > > > > In cdnsp_pci_remove, if pci_is_enabled returns true, it will > > call cdns_remove; else it will call kfree. Then both control flow > > goes to pci_dev_put. > > > > Adjust this logic by modifying it to an if else. > > > > Signed-off-by: Dongliang Mu > > Your email address does not match your From: address, and your From: > address is saying it is being spoofed and not correct :( > > Please work with your school to fix your email system and do not use > gmail to hide it. My git config uses Gmail. I forget to change this after I joined the new school and changed sendmail configuration. I sent a new version several minutes ago. > > thanks, > > greg k-h