Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sun, 9 Oct 2022 20:43:51 +0700
From:   Bagas Sanjaya <bagasdotme@gmail.com>
To:     Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
Cc:     rostedt@goodmis.org, mhiramat@kernel.org,
        linux-kernel@vger.kernel.org, Abaci Robot <abaci@linux.alibaba.com>
Subject: Re: [PATCH v2] ring-buffer: Fix kernel-doc
Message-ID: <Y0LQF02sKheWtkD8@debian.me>
References: <20221009020642.12506-1-jiapeng.chong@linux.alibaba.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="YH9GWmnykX8Ccsn+"
Content-Disposition: inline
In-Reply-To: <20221009020642.12506-1-jiapeng.chong@linux.alibaba.com>
Precedence: bulk


--YH9GWmnykX8Ccsn+
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Sun, Oct 09, 2022 at 10:06:42AM +0800, Jiapeng Chong wrote:
> kernel/trace/ring_buffer.c:895: warning: expecting prototype for ring_buf=
fer_nr_pages_dirty(). Prototype was for ring_buffer_nr_dirty_pages() instea=
d.
> kernel/trace/ring_buffer.c:5313: warning: expecting prototype for ring_bu=
ffer_reset_cpu(). Prototype was for ring_buffer_reset_online_cpus() instead.
> kernel/trace/ring_buffer.c:5382: warning: expecting prototype for rind_bu=
ffer_empty(). Prototype was for ring_buffer_empty() instead.
>=20

Describe what this patch does to fix these warnings. Remember to write
in imperative mood. (Actually I figured out what you are doing, see
below).

> Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=3D2340
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
> ---
> Changes in v2:
>   -Get rid of the parenthesis.
>=20
>  kernel/trace/ring_buffer.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>=20
> diff --git a/kernel/trace/ring_buffer.c b/kernel/trace/ring_buffer.c
> index c3f354cfc5ba..199759c73519 100644
> --- a/kernel/trace/ring_buffer.c
> +++ b/kernel/trace/ring_buffer.c
> @@ -885,7 +885,7 @@ size_t ring_buffer_nr_pages(struct trace_buffer *buff=
er, int cpu)
>  }
> =20
>  /**
> - * ring_buffer_nr_pages_dirty - get the number of used pages in the ring=
 buffer
> + * ring_buffer_nr_dirty_pages - get the number of used pages in the ring=
 buffer
>   * @buffer: The ring_buffer to get the number of pages from
>   * @cpu: The cpu of the ring_buffer to get the number of pages from
>   *
> @@ -5305,7 +5305,7 @@ void ring_buffer_reset_cpu(struct trace_buffer *buf=
fer, int cpu)
>  EXPORT_SYMBOL_GPL(ring_buffer_reset_cpu);
> =20
>  /**
> - * ring_buffer_reset_cpu - reset a ring buffer per CPU buffer
> + * ring_buffer_reset_online_cpus - reset a ring buffer per CPU buffer
>   * @buffer: The ring buffer to reset a per cpu buffer of
>   * @cpu: The CPU buffer to be reset
>   */
> @@ -5375,7 +5375,7 @@ void ring_buffer_reset(struct trace_buffer *buffer)
>  EXPORT_SYMBOL_GPL(ring_buffer_reset);
> =20
>  /**
> - * rind_buffer_empty - is the ring buffer empty?
> + * ring_buffer_empty - is the ring buffer empty?
>   * @buffer: The ring buffer to test
>   */
>  bool ring_buffer_empty(struct trace_buffer *buffer)

Oh, these warnings above are due to mismatched function name, right?

Thanks.

--=20
An old man doll... just what I always wanted! - Clara

--YH9GWmnykX8Ccsn+
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQSSYQ6Cy7oyFNCHrUH2uYlJVVFOowUCY0LQFwAKCRD2uYlJVVFO
o8HKAP460IufdwWV8co3egGjt7J15uH6orDk7k2t8ftPF74EBwEAhS8C1XK/9ihJ
CVgn1cZRCN39cfVjldh6jYnG4tu5nAQ=
=3LtU
-----END PGP SIGNATURE-----

--YH9GWmnykX8Ccsn+--