Received: by 2002:a05:6359:c8b:b0:c7:702f:21d4 with SMTP id go11csp3631046rwb; Sun, 9 Oct 2022 08:18:45 -0700 (PDT) X-Google-Smtp-Source: AMsMyM7Qkm4V0EDJFmp5lJpt2fxXqgNIUhnH87nvjpTURF74FVjyx1DP/Mo8SA6PARDlHV7uYji1 X-Received: by 2002:a17:907:2bf1:b0:78d:9c74:5a78 with SMTP id gv49-20020a1709072bf100b0078d9c745a78mr4829729ejc.319.1665328724908; Sun, 09 Oct 2022 08:18:44 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1665328724; cv=none; d=google.com; s=arc-20160816; b=FxgJMjQf/WOYcdo4kmzWDSj++6MFhTI+Bw69wfPrLM5NEnW8mtIIcBO+9YOZmWzieR KwlhrkC0SkyugRKxztbKUoQmwQPX0PZ3cV+24C54NanAOZlxhWTXgpnshsE9XWFK9iKr t1G4C/ykrKVu6dMBbt03cqzDW9QKQhVqs+mBUo4DJbCV4BQsqJ5gSVbYmyTy1fvCKV63 cFh7aajmV2/A+qFZEV8dP5QupOcjdILFGTBsWhm8k6ALj4Rw0YN9Hw72kiwKq9kidDux mqhsusT33ktF7M0X9lz7Q9Ffl9aJH6ZYLbXYCn3juDPHJSRCOsHCN0Y+0s1gMv6G33nP hZSw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=u2hBQdaFyitVR4o7VAQhi1z5vf0SoViuC4mH8i4th+A=; b=bOcUtHjlZRavieBtm+/ezvoW5c+JJEizrnr8hZkIXHh8QH8PLPhs0XaanZQjLePv4y s8Rnxvh1Irjak7RDL82CZ1OLqcjCG9c2dU5YJfkM/JvzIzUwMQ0MU+pV3rdUHYfB5WOE m7msTdB9nH4dOzhVBcDSAe2OZU1EfwpLJKfePzH05dV3+Vb7WIUtdOUiLmn0SI6ednxj c86DWmERgFNu4+UT3QJkXaFqmEKzuvZV3SqMf9vAcC5+yY72vyHyKS6W8J7X9TOAEVqB FTL1QXmsVR3AGsLlDNVtJ5WECRI0kTNQiQF1SdC7uyLbKlO1Gm6T6JkOdj5y272iUu/r ShWA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=JToBOpJU; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id go37-20020a1709070da500b0077b08d909fbsi7905956ejc.53.2022.10.09.08.18.18; Sun, 09 Oct 2022 08:18:44 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=JToBOpJU; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229974AbiJIPMP (ORCPT + 99 others); Sun, 9 Oct 2022 11:12:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38316 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229520AbiJIPMO (ORCPT ); Sun, 9 Oct 2022 11:12:14 -0400 Received: from mail-pj1-x1036.google.com (mail-pj1-x1036.google.com [IPv6:2607:f8b0:4864:20::1036]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 46DC827B10 for ; Sun, 9 Oct 2022 08:12:13 -0700 (PDT) Received: by mail-pj1-x1036.google.com with SMTP id i7-20020a17090a65c700b0020ad9666a86so11170020pjs.0 for ; Sun, 09 Oct 2022 08:12:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=u2hBQdaFyitVR4o7VAQhi1z5vf0SoViuC4mH8i4th+A=; b=JToBOpJUcGPwEp0K/SG/cfexHuQEzvqjNItWRsyrhrfn0i9LV+adrin+Tz9xESErUK 5+fnkZWHpewPVUp4rz54yojsMWsOxmncmUhd6noH5Dgc9B5sJ2KK3BZmGZIlAW1KNhiX 4JTXBxMb2p8kDI87YFLMY7Vs7/rYyWcHrBXBE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=u2hBQdaFyitVR4o7VAQhi1z5vf0SoViuC4mH8i4th+A=; b=L3zbzc+HhglDMpKFjCv3k4mtWSVZun7RRa2+Mp6K91PCerOcmCGaS+wEisYU2/uYgm s5KTljuAp/DDjVUqjdgT7g4b+9D+lGoU/Gubu1PfiooxT+/gL4Ll9aqKcoi2IZHkW9qa IGni1Xv3Ud2UNRoFykvEF98TYqyGPlbBzbxVEHxHD0YieGlgULolDsBXJbtDShZFp0lT /ERcgZmOAu4ysByJD2epoXnzuC7f6MVI8TzFsZccg5Vagp/gPiWBwPedc9VKtSt+Vgcg XHJy86UWg9oB1ypCEPYtymJu1OpX0xKVQOmmuIxvI7Vp3wntkSJp03PwJBVtByeeciiB lA0A== X-Gm-Message-State: ACrzQf008eXnubrzTWXo0j0RsELZHKxIydZecjRHIGljQ5kBUx93Bqtj iG9jFJVdKF113Kj8+Ot9JZGopw== X-Received: by 2002:a17:902:f602:b0:178:9818:48a4 with SMTP id n2-20020a170902f60200b00178981848a4mr14430380plg.148.1665328332721; Sun, 09 Oct 2022 08:12:12 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id s15-20020a170902ea0f00b0016d72804664sm4853779plg.205.2022.10.09.08.12.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 09 Oct 2022 08:12:12 -0700 (PDT) Date: Sun, 9 Oct 2022 08:12:11 -0700 From: Kees Cook To: Li zeming Cc: mcgrof@kernel.org, yzaikin@google.com, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH] proc: Remove =?utf-8?Q?unneces?= =?utf-8?B?c2FyeSDigJhOVUxM4oCZ?= and '0' values Message-ID: <202210090811.3C43AC2BF@keescook> References: <20221008093026.4952-1-zeming@nfschina.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221008093026.4952-1-zeming@nfschina.com> X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Oct 08, 2022 at 05:30:26PM +0800, Li zeming wrote: > Remove unnecessary initialization assignments, which are used after the > assignment. They don't hurt anything, and in fact show the intent of the initial variable state. Additionally, the compiler will drop it once it finds the later assignment. -Kees -- Kees Cook