Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <386fe4ae-0fae-0822-f86d-f5903369b424@axentia.se>
Date:   Sun, 9 Oct 2022 18:36:52 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.13.1
Subject: Re: [v9 3/4] i2c: muxes: pca954x: Configure MAX7357 in enhanced mode
Content-Language: en-US
To:     Serge Semin <fancer.lancer@gmail.com>,
        Patrick Rudolph <patrick.rudolph@9elements.com>
Cc:     robh@kernel.org, laurent.pinchart@ideasonboard.com, wsa@kernel.org,
        linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20221007075354.568752-1-patrick.rudolph@9elements.com>
 <20221007075354.568752-4-patrick.rudolph@9elements.com>
 <20221008125436.ndj2nwesx5lgppsf@mobilestation>
From:   Peter Rosin <peda@axentia.se>
In-Reply-To: <20221008125436.ndj2nwesx5lgppsf@mobilestation>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Zmw5ditoZ1ZTQkF3bWFOT2N2ekphNWhheXZLajBCQkpjTjlrVTZyWjl0SWRZ?=
 =?utf-8?B?WkxMbUdySWsvbCtmSnc0YmY2RTdCZndzWncwbmFWdWFKanY3aHJGU2x5Vlln?=
 =?utf-8?B?ZUJ4WTlXODloZVpKVU9ZbXdvUHJjKzdwZUhuVzFpbHZFb1FSSmVTcVdzK05D?=
 =?utf-8?B?R0crOWpNSitIWmxWLys2eU9zc0p1TFlQTitjWmptSEF5eHg0NHFZc2tPcTA3?=
 =?utf-8?B?QVJ3YjNuZVd6eE9WQTY3d0hxY2FKOWFIVjJPeVprYXRWMTRZbG16MmxrWS9I?=
 =?utf-8?B?bk9FY0RzWHVaR081eENzeHljRkV5UWtDSTJUSVhVVUhCMUFBc3BwaTd3b1U2?=
 =?utf-8?B?QXZLVFpld3lYb1VCcy8xdkNEYm5XSWhPTEhnOXhVZk9GOEV1cG4vTXFGM3RO?=
 =?utf-8?B?UDdQQ1lCU0lWYWtEdzV3aU5OZ3h1bEUvL0MvdmJ3cXRkVVFuZFY2VkNoODVK?=
 =?utf-8?B?VWdGYk1xR1dGdExvbDM4c243NUtzUjR0TmlyU0dZeDdDUnQxamtIbS9rVmUw?=
 =?utf-8?B?WllITHpTWERtVnByZlRwQ24zNWFGd1h3VnRJY3pIVFdqU0RCUkxuWkFrYmVS?=
 =?utf-8?B?bFUvaEd1NUF0d3Mvc29laDNvekJxUTlReEpiUHpvSHZrTVJDcG51MTR1b0Er?=
 =?utf-8?B?eUpqQ1BIeWh5VFo3K2ljZ2xwbWs2anhaYVhtbGx3aUtsdTVKbG56OGZZbW9C?=
 =?utf-8?B?bXlFeEN4eFk5NFlnSVdRa1BBaldTRGtZOGFtM0tXUTFoR0t2V0x1YUJzZGIx?=
 =?utf-8?B?clNpd0ZhMEJNWGRNZi9NekhiNUJFcWtBUkQrZmxFR1owL0ZhWFJUbzJjSDl2?=
 =?utf-8?B?Q0lrMlc0WGwxL1NQTjJKWHVLU3ZRTUxWNXFENmEvbStiZmNBYlE3Y3VWN2Mx?=
 =?utf-8?B?T0MvNkRkM0dGMGk5Smx6aE81SDRleWlZZzJrVFZZNWRyRjlOeDArcFlCUnhy?=
 =?utf-8?B?ZWtESW4rZ1dFU1RUNFZHUlE0SVk3bXFTN05oZFJCenFTemJLcWxDOW5scEd0?=
 =?utf-8?B?VkEwKzVuK2djU0Y4WFovR28wYW8zWjBYTmV5TGR2dlpLTlZVM0hsTU9yNjE3?=
 =?utf-8?B?WWdIb1lZejVPVmlxTkpZNWpLSnA3YWtNQlEvd0lyam5WZFd1TUJTQ2FtSjJr?=
 =?utf-8?B?ZkhSTENXY2VGUGhUekNNbjAvTm5tTzRlS1o4aVpralRSc3BzYXFpQWtrS3Vx?=
 =?utf-8?B?RnQ2eWhrRmJKVzYvQlh4UHpObnlOM2VxNGVLWmdGQlozd1RsMUh6MFl3TW5p?=
 =?utf-8?B?em1vM3lWellQUjU1ZWowbkVkTW1FbjZPSGUvWUE2ZlVEYkN5aXhWeDJGMHBO?=
 =?utf-8?B?aHErRTF5T3lJU0MvajR2YnlCNFZEemtiTEV1a2RSd25JQVhyN05RTHczUjZk?=
 =?utf-8?B?NXFaNTJJcXBJNFJtUlFhZUh4YWs5aW9ua0Y1WGFjWGR4dFcwMmk3UjJrb2l6?=
 =?utf-8?B?Q1lKdUtSZ1FKZ3BWd29ZMW1BOHdnNHRNeEx0VVJyVHl5Y1YwMFFhMkIzdkFH?=
 =?utf-8?B?RWNJRVRGNFFzM05Ld3dCenlVQXhuVWFaeXBmVCtkdEJZNzh0Uk0rYUJ0bWw5?=
 =?utf-8?B?cUF2YlVWQzhBTllRWlZYYUo1N1R1WFRjMzFpVWlmaUJuMVJDZ3lmYTlBK1FQ?=
 =?utf-8?B?dzZLSUd5VzBUcEh1UGRWWmVpM3h5aTl2amhIdmYvbnpldE83RmJ2TUJrTWxp?=
 =?utf-8?B?ZVBZY3FzTWdsUVE5M2oxa24xajBoZDJRZ1Rna3NzL3VqT2dVUithMUtzcGlO?=
 =?utf-8?B?Q09UT0xrd0RxaGVDODg2RkFnb0N5N1N4cmZESjZOTysxQVpzbmVncHpENWZE?=
 =?utf-8?B?ZVBYbUlxbVFmVU1HNTdXMUlXWkRYd2JsTVhSRDQrZHMwQ3ZySXkzOHRlNGxq?=
 =?utf-8?B?MEtDT25EUi9GZE4reFlYTm94OUlzTG5XZzhwNU10dTBUQ3d1b1FxTnRhY1Rw?=
 =?utf-8?B?aWlkRHRMRCtyd1Boa09SYlR1VmpWaFRHN1ZjcTF2czk3NGhQUHQ3Wm9Qc2Vq?=
 =?utf-8?B?NVQrUGNOaFdnWGkxVkFlNzcyVkp6c29MVmxtN0cwcCtOcGVNYUpJbDhmUDQ2?=
 =?utf-8?B?ZFo3azB5MlBKaTEwTHBiOXhVUVZtMjNSa3lGMEhHNmIzcitZanlxcHU0L2hN?=
 =?utf-8?Q?UadtUn3MS4s6sxl9YQzBrfeqR?=
X-OriginatorOrg: axentia.se
X-MS-Exchange-CrossTenant-Network-Message-Id: e7290a36-f232-483d-9b70-08daaa14798a
X-MS-Exchange-CrossTenant-AuthSource: AM0PR02MB4436.eurprd02.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Oct 2022 16:36:54.3259
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4ee68585-03e1-4785-942a-df9c1871a234
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: NpJcTKLwXeFJFW/y9f9Odv7tSwhc5YJFA7dWAbbIrEYacvpdZrHrZULUrj/GuPs5
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR02MB9017
X-Spam-Status: No, score=-6.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

2022-10-08 at 14:54, Serge Semin wrote:
> On Fri, Oct 07, 2022 at 09:53:52AM +0200, Patrick Rudolph wrote:
>> +	u8 maxim_enhanced_mode;
> 
> So long name.( What about a shorter version, i.e. max(im)?_enh ?

No thank you, please keep the long name as is. This is a corner
case and the name is not repeated that many times. Spelling it
out makes the code more readable.

Cheers,
Peter