Received: by 2002:a05:6359:c8b:b0:c7:702f:21d4 with SMTP id go11csp3885049rwb; Sun, 9 Oct 2022 13:02:12 -0700 (PDT) X-Google-Smtp-Source: AMsMyM5RHLjEWB/a37vO7AueC3uOLrDkxIfQMUPSf/18VpGdpGEiV4P99oKVHuY/SkTzM02k9Sl8 X-Received: by 2002:a17:902:ea03:b0:180:b53f:6da with SMTP id s3-20020a170902ea0300b00180b53f06damr9876447plg.69.1665345732586; Sun, 09 Oct 2022 13:02:12 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1665345732; cv=none; d=google.com; s=arc-20160816; b=dugGfJSOszV7X8xC/lRTyW+SLJROI1OPalC0yUM/JY7aP1fJqHxTPOBAGQe4SWh/Yd IcM1W++xMWlBhKrDtuaCkbqohQcPeyCwWT/BetiSOs8Cb2k9/OhjM821POizmwP+0lrT PkrGbPxYuVigMyIZOFAFy12X1f1RABQZ/L+aLdKlDohmqp5FYI+PZ0HBUyI43Y1FO6RE o5pMaNbZo0pSmksq6bADMVzekZYQGMO5A1YDo9qypTVxXs+LY3FC2ouhhuOuLXIVlUF9 KYoGJGZoBR47KVfHJdJUb87VzBuz+KYlRVzl3ofZu66N3ZY3HNW2m/6chuKtOhjlGslR 2vvQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:in-reply-to:references:date:message-id :from:subject:content-transfer-encoding:mime-version:dkim-signature; bh=Y3qp5qnutmsXd60H6arizbjh70PxrVkT9GuTXTVt+nc=; b=ec6PwZIZ6SH7pvfU2kL757AxgxPHu+9sfkeO+4i+smzOV96UdSNxW4j/2u2EZszExQ jVl0kzBsHryRp4mu0w4o7yeCsM4bjWpqXK6cMObJrGZACiQ8c3N2dLkKk5xtRfz8UfzW YMny03vzd8NvYK9SJnathKYonb/NrCDPFGXj2f/a72vLUgmZ23yUInvkM0sikxNpw9lZ KwbIwZx756DLO807bI7C3pdjOV7muACqQWv9ERDcKLbjPeXQh9E2Zo6W/NIBdDPVrw3i 92VcXeO98JtIK64sZsR6rRy4oJs7BkX7yTKKt5H5nZGSNzZObDiXDBhm6mE1cBytI6wN 7MeQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=EpFwq0kh; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id oc1-20020a17090b1c0100b001fdd6d07d39si20040623pjb.8.2022.10.09.13.01.48; Sun, 09 Oct 2022 13:02:12 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=EpFwq0kh; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230360AbiJITAV (ORCPT + 99 others); Sun, 9 Oct 2022 15:00:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39448 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229996AbiJITAR (ORCPT ); Sun, 9 Oct 2022 15:00:17 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B524619297; Sun, 9 Oct 2022 12:00:15 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 5747E60C6E; Sun, 9 Oct 2022 19:00:15 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPS id A4330C433D7; Sun, 9 Oct 2022 19:00:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1665342014; bh=5oaT6cRjV0u69+2ayKlnvYUhASoH5qRDauJkOK0L8NQ=; h=Subject:From:Date:References:In-Reply-To:To:Cc:From; b=EpFwq0khgbmOQS+SqdLnwvjh0m62CUG2xc3Pn20O/ZyiYYFN/tOMYDxSaBLv3tgmh cml3Rzwy0FjTQ/r+GaDsMqMC7K4OXrl8ZrnQ+HEn9WcqN25BBec3/5NasaYXWSH1sU 6dz2DUWRt7UXo7sJvUhjg4twDgFehpLvYwRGq/Dzt8R+rDBqfNFV9qAMbR4Bd2jhKe WfRrBumCoBedKdruYDOKfoUJbhQPq6EwjOwwnBNSrkzbhGHr8or/0UQ0VMR6gT5wFS VNpxvwlZdCH3gRSXQuDyWIeo6yHyBtlPUAQGhtGUClAtG3mDU7cz8si32j/N5oT8bO A/A/rfbSv462A== Received: from aws-us-west-2-korg-oddjob-1.ci.codeaurora.org (localhost.localdomain [127.0.0.1]) by aws-us-west-2-korg-oddjob-1.ci.codeaurora.org (Postfix) with ESMTP id 895ACE21EC5; Sun, 9 Oct 2022 19:00:14 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: Re: [PATCH] mISDN: hfcpci: Fix use-after-free bug in hfcpci_softirq From: patchwork-bot+netdevbpf@kernel.org Message-Id: <166534201455.6058.9588339706087338743.git-patchwork-notify@kernel.org> Date: Sun, 09 Oct 2022 19:00:14 +0000 References: <20221009063731.22733-1-duoming@zju.edu.cn> In-Reply-To: <20221009063731.22733-1-duoming@zju.edu.cn> To: Duoming Zhou Cc: linux-kernel@vger.kernel.org, isdn@linux-pingi.de, kuba@kernel.org, andrii@kernel.org, gregkh@linuxfoundation.org, axboe@kernel.dk, davem@davemloft.net, netdev@vger.kernel.org, zou_wei@huawei.com X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello: This patch was applied to netdev/net.git (master) by David S. Miller : On Sun, 9 Oct 2022 14:37:31 +0800 you wrote: > The function hfcpci_softirq() is a timer handler. If it > is running, the timer_pending() will return 0 and the > del_timer_sync() in HFC_cleanup() will not be executed. > As a result, the use-after-free bug will happen. The > process is shown below: > > (cleanup routine) | (timer handler) > HFC_cleanup() | hfcpci_softirq() > if (timer_pending(&hfc_tl)) | > del_timer_sync() | > ... | ... > pci_unregister_driver(hc) | > driver_unregister | driver_for_each_device > bus_remove_driver | _hfcpci_softirq > driver_detach | ... > put_device(dev) //[1]FREE | > | dev_get_drvdata(dev) //[2]USE > > [...] Here is the summary with links: - mISDN: hfcpci: Fix use-after-free bug in hfcpci_softirq https://git.kernel.org/netdev/net/c/175302f6b79e You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html