Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220930082405.1761-1-zhang.lyra@gmail.com> <20220930082405.1761-3-zhang.lyra@gmail.com>
 <727a540d-0ca9-ade3-894d-f1774d10a681@linaro.org> <CAAfSe-u4y84kjjksv-Y7=zyosV=34M-=_wrDQC9884znvx9V4Q@mail.gmail.com>
 <e0d69843-4b37-2e0d-66c7-fc8fd09ed385@linaro.org>
In-Reply-To: <e0d69843-4b37-2e0d-66c7-fc8fd09ed385@linaro.org>
From:   Chunyan Zhang <zhang.lyra@gmail.com>
Date:   Mon, 10 Oct 2022 09:52:11 +0800
Message-ID: <CAAfSe-vQ3Vhjpp9kwRxmha1WR=kfW08BmuYEW+r1POBD1oFqnQ@mail.gmail.com>
Subject: Re: [PATCH V2 2/3] dt-bindings: gpio: Convert Unisoc EIC controller
 binding to yaml
To:     Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc:     Linus Walleij <linus.walleij@linaro.org>,
        Bartosz Golaszewski <bgolaszewski@baylibre.com>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        linux-gpio@vger.kernel.org, devicetree@vger.kernel.org,
        Baolin Wang <baolin.wang7@gmail.com>,
        Orson Zhai <orsonzhai@gmail.com>,
        Chunyan Zhang <chunyan.zhang@unisoc.com>,
        LKML <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Sun, 9 Oct 2022 at 23:17, Krzysztof Kozlowski
<krzysztof.kozlowski@linaro.org> wrote:
>
> On 08/10/2022 04:57, Chunyan Zhang wrote:
> >>> +        eic_debounce: gpio@40210000 {
> >>> +            compatible = "sprd,sc9860-eic-debounce";
> >>> +            reg = <0 0x40210000 0 0x80>;
> >>> +            gpio-controller;
> >>> +            #gpio-cells = <2>;
> >>> +            interrupt-controller;
> >>> +            #interrupt-cells = <2>;
> >>> +            interrupts = <GIC_SPI 52 IRQ_TYPE_LEVEL_HIGH>;
> >>> +        };
> >>> +    };
> >>> +
> >>> +    sc2730_pmic {
> >>
> >> If you insisted to keep it, at least should be correct, so just pmic.
> >>
> >>> +        #address-cells = <1>;
> >>> +        #size-cells = <0>;
> >>> +
> >>> +        pmic_eic: gpio@300 {
> >>
> >> It's exactly the same example as above - all same properties. Drop it or
> >> bring some differences.
> >
> > The differences are on #address-cells and #size-cells.
> >
>
> Which don't really matter...

Alright, will drop it in the next version.

>
> Best regards,
> Krzysztof
>