Received: by 2002:a05:6358:1087:b0:cb:c9d3:cd90 with SMTP id j7csp168911rwi; Sun, 9 Oct 2022 20:59:35 -0700 (PDT) X-Google-Smtp-Source: AMsMyM4xwkBYxcBOzEI1K/0/JTdpEbz+bZGF8dfCcgJw7mWM1nuGE/cuRt2Qevlg79JxN0GZK+yP X-Received: by 2002:a17:90b:3a88:b0:209:f55a:962e with SMTP id om8-20020a17090b3a8800b00209f55a962emr19380160pjb.28.1665374375352; Sun, 09 Oct 2022 20:59:35 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1665374375; cv=none; d=google.com; s=arc-20160816; b=f+xUYCpebmJ7/BXEtk7gHEvGm0hkA3N4E2OdHv3B3F88kI5vF4ht/cq4UzuWenYWrd oU9+lzgifudgFwaTaMv5PpjtgUIDmTl40NJk1D4174vgemWRW7HUiyBz8QHjLbjauiL/ CQjJ+FrJ5CNoThOuX6umTCe0gmCMWc8NDjeBj3JkVCvUSkZdnjefW4OWLgKip6qgcTca RkDEju/Bcq8bGBNsHxObNnNxA6q6S0W3JXNmvfjWpadKRa/IMJtTi7q/ISsP7Lrpex3l hFKuWkfKQ+8DA1F1dA9riIbYhzPeILg6VouvQH7R/UwIhKJG5ImhmakLXVVaht7VTEN2 2L6w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=0RvipzyCwcwCdOuCNQFfFNwYNR5sm1Uw9mApVKX+WO8=; b=ogSrEydReHqiDYAJQiQJ65VD0fCMD1KeF/pF5VWMscm8ICON2NEPbNIN2mmp0e1JmP 77hPRtqwYbJlMi5BlyT7QOhOgaoIwE8ZhcmysPx6uaq0+gLCwNUn6nTj83hea0+UFF7q ChKiRcuwL5G/ixfD0QkmfRcYCUZmE6NurjjwfJCY2Q521b5V/SmRuYIRxIlrZ++rmLUp 963qxegFJDyWc2hNUbIqA7HiSXX759Zndxz3M7kCgctCXEsFA6E0gfo77afZT2mDhF60 C98/Z5S7+m4sd+E5Asv7PSF+Uxhd/ZKxvam8mrQLRn06AXzBwwpfjzGqO6Od7ebFhzFD FNmw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=MZdqDSH4; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id g1-20020a056a000b8100b00554f1b32131si10800717pfj.362.2022.10.09.20.59.22; Sun, 09 Oct 2022 20:59:35 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=MZdqDSH4; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230274AbiJJDq2 (ORCPT + 99 others); Sun, 9 Oct 2022 23:46:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36208 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230246AbiJJDq0 (ORCPT ); Sun, 9 Oct 2022 23:46:26 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4BCF63DF2C for ; Sun, 9 Oct 2022 20:46:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=0RvipzyCwcwCdOuCNQFfFNwYNR5sm1Uw9mApVKX+WO8=; b=MZdqDSH4EfjD25C0qM1EJoYWQM lv2CiLKsO1p4L6g73V9Y45cuO3XMDkMQb5yD411PSkYm3rrEYCHwVI8BoOSw2fXSTnMcmbt/hv2oS rAsAxj3Kjjwk7JQCsAvQIA0G4FfdEkcJ9rqGqhJwRQXxzKFAWGuaKWCkN+V/+ptngFjKKBvfZVr3h 2TF9u1g1h0xLA6UgYv1XEXhlA7kJKFSCL5yMOdEpaLOMMNfuediK/e0n+pglh0s6y5aNOiUiIuYTZ YU2bO10QT5yW9X4nS/JpXZt5DA72ZYA6X1ThO7RVvIgbk6nJPu/SSfUQ0ttovkPHt3apbVYCWwP5J kvSkcnzA==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1ohjkE-003v8q-5p; Mon, 10 Oct 2022 03:46:22 +0000 Date: Mon, 10 Oct 2022 04:46:22 +0100 From: Matthew Wilcox To: XU pengfei Cc: akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH V2] mm/mmap_lock: Remove unnecessary 'NULL' values from Pointer Message-ID: References: <20221010034238.3604-1-xupengfei@nfschina.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221010034238.3604-1-xupengfei@nfschina.com> X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Oct 10, 2022 at 11:42:38AM +0800, XU pengfei wrote: > Pointer variables allocate memory first, and then judge. There is no > need to initialize the assignment. This seems worse to me.