Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <c25ce92b-ea93-1bd8-11ba-4812b040724d@gmail.com>
Date:   Mon, 10 Oct 2022 07:13:23 +0300
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.0
Subject: Re: [RFC PATCH v2 1/5] regulator: Add devm helpers for get and enable
To:     Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc:     Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>,
        Jonathan Cameron <jic23@kernel.org>,
        Lars-Peter Clausen <lars@metafoo.de>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Jagath Jog J <jagathjog1996@gmail.com>,
        Nikita Yushchenko <nikita.yoush@cogentembedded.com>,
        Cosmin Tanislav <demonsingur@gmail.com>,
        linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <cover.1665066397.git.mazziesaccount@gmail.com>
 <fa667d6870976a2cf2d60f06e262982872349d74.1665066397.git.mazziesaccount@gmail.com>
 <Yz7/o1q7p8NmGKMe@smile.fi.intel.com>
Content-Language: en-US
From:   Matti Vaittinen <mazziesaccount@gmail.com>
In-Reply-To: <Yz7/o1q7p8NmGKMe@smile.fi.intel.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi Andy,

On 10/6/22 19:17, Andy Shevchenko wrote:
> On Thu, Oct 06, 2022 at 05:36:52PM +0300, Matti Vaittinen wrote:
>> A few regulator consumer drivers seem to be just getting a regulator,
>> enabling it and registering a devm-action to disable the regulator at
>> the driver detach and then forget about it.
>>
>> We can simplify this a bit by adding a devm-helper for this pattern.
>> Add devm_regulator_get_enable() and devm_regulator_get_enable_optional()
> 
> ...
> 
>> (cherry picked from commit b6058e052b842a19c8bb639798d8692cd0e7589f)
> 
> Not sure:
>   - why this is in the commit message
>   - what it points to, since
> $ git show b6058e052b842a19c8bb639798d8692cd0e7589f
>   fatal: bad object b6058e052b842a19c8bb639798d8692cd0e7589f
> 
>> Already in Mark's regulator tree. Not to be merged. Included just for
>> the sake of the completeness. Will be dropped when series is rebased on
>> top of the 6.1-rc1
> 
> Ah, I see, but does it mean the commit has been rebased or you used wrong SHA?

I did probably cherry-pick this from my local development branch and not 
from Mark's tree. Sorry for the confusion. I thought people would ignore 
these first two patches when reviewing as was requested in cover-letter.

-- 
Matti Vaittinen
Linux kernel developer at ROHM Semiconductors
Oulu Finland

~~ When things go utterly wrong vim users can always type :help! ~~