Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Pawel Laszczak <pawell@cadence.com>
To:     Dongliang Mu <dzm91@hust.edu.cn>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>
CC:     "linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] usb: cdns3: adjust the partial logic of cdnsp_pci_remove
Thread-Topic: [PATCH] usb: cdns3: adjust the partial logic of cdnsp_pci_remove
Thread-Index: AQHY27ATjFC1Puf270uKLKm53d01q64HCYkg
Date:   Mon, 10 Oct 2022 04:27:15 +0000
Message-ID: <BYAPR07MB53817EF4EACBA1CECEED97FDDD209@BYAPR07MB5381.namprd07.prod.outlook.com>
References: <20221009072305.1593707-1-dzm91@hust.edu.cn>
In-Reply-To: <20221009072305.1593707-1-dzm91@hust.edu.cn>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?1Ewy3RK19ZU8NJf/HBHab3OIdGDE6aXrG4zdR0/iI+raEHMKZK+mHAKLRkAD?=
 =?us-ascii?Q?fIajypMWM/cbYmfC+DgKfwz3DxtYYumyq1h/CEH7l3zM/MlpylhLtvu92HVe?=
 =?us-ascii?Q?4EuRVUcafhYNJuKZPCj++v0t0TMejiReiHWxXN1Ry5oDrI2v0oq9Rj2QhP/m?=
 =?us-ascii?Q?ayRzwrAm1f3DURMSOqXXtvT0PNMEwzP0U0tOyHnmM6G86WAQ/EYUFWfL5yfs?=
 =?us-ascii?Q?h1ODNMGeN+stv3ng8PQkb5F6bdg80jco7vxb7+oh7ezLC+zyaO+QPcv4nKK7?=
 =?us-ascii?Q?Ikul/VrU8wIkAFSR/isYm4HquERCKYUtg7fsLu3isGzkCU7ilribNFQfp7Uc?=
 =?us-ascii?Q?SGyDAgVqpm1lMGnmMlqHsCL5aG/Yps9L5UPQUnhobYrVh9RMc1UDnRIYu8Zi?=
 =?us-ascii?Q?3k2LzKOO2GJ5jcN0rLXOYvItM6wE2jTNKAfHxvZjawmLVYKF+9OlvxYkkl6r?=
 =?us-ascii?Q?oMvYTEozL1wfkyMDf5uJtwGqdsoZyBjonXpek8/Tk8ksX+zc8dIdYS4y6fuX?=
 =?us-ascii?Q?Ev4Kq/vruPT4Y2uTu4e6YkaCqgOhIRZZURLWXIBJa3G2hgRUa0+bpqTeMCK9?=
 =?us-ascii?Q?jkkyBb0JM58hPPIVtnMv7L2BVkHwV2bUkowfjPcxa3nIUaTNz3x6Lz4IwVhG?=
 =?us-ascii?Q?t6h/B6DH4r4U8xTLQCn1IkCraFOrjAlaKNpXOAvCkTNdoxVHM6ptD+PiPSP+?=
 =?us-ascii?Q?4A7NDrV+PI/KqsSwI3l3X+MPoJBkz03+wvXsdoQudcJOWl23+GCsPdSYNqCf?=
 =?us-ascii?Q?mNjdMCf11hMqpwgVJA8dRRgqoLV6twVJWmzVYDXBB5T4BQ8aihrWt5syloy+?=
 =?us-ascii?Q?J8i8YsMYNV7FO/x1IpwkrVLn10rttil2+YoF8zzBdpTXp3iBryl/SscG4D/o?=
 =?us-ascii?Q?5oQtWsaNb3x36WGnVVD0uJygDWhGyj4AfueE5N+MrAfZai3MIsym7KGITZH1?=
 =?us-ascii?Q?Ug+BFZjwN1jsp7SrIB8WC2q5sEYMXTCVVQvc5tHZ6BfERre1tH+jDEUx33gC?=
 =?us-ascii?Q?31rX/1zFAXB8KOWNp6OkNm6ABq9X+u5YHl3uT8RBTyg8/eUlPzARKbJNAQz3?=
 =?us-ascii?Q?oMqobguhVUZxAeX0a/wKIwvsqdYhgJEDVcqFSyzbpgIPk+OE++wTTq2GHfZ7?=
 =?us-ascii?Q?8lwYCEeiAek1b4jAnIYowih7UMbxZvWnr4twQMlZ0eDsLQ6P1MByNtZGVsy9?=
 =?us-ascii?Q?DUCYB7VPi/UZ2rdyOsuspeIS9LYshQMdZZSwEv3+OgLpyU23Okij3rQE0+CF?=
 =?us-ascii?Q?3306hUT95ClITgRD7DJhl5QyCDBzcY5jQ4tP+mD/8DuAX0UNWExA5AtTOW+v?=
 =?us-ascii?Q?h78S8maH6JL/Wr7QcWU8YOCghld2JM4493L+qsvKhtPyxBWpwuoKVHU8eN2Z?=
 =?us-ascii?Q?cw1lu5/JKm81j/VOBCPCXshc2AMgWp45eYsKJs5KUN8oLKCO2FNotGEzymKG?=
 =?us-ascii?Q?3cj/b1RqJPJS8T5/9fdOgyS2i4rq6vDS+4yHVUls9aqxphOFrMmnkxGw9yiU?=
 =?us-ascii?Q?S+kLqRkNcW6Qlh4pSPPf6KHvuXsfrScKVEsN/vLUOhgWTVLTqfD3CPpumCxu?=
 =?us-ascii?Q?I0mzyq7xWO9J7WkQ0aBot7KTLVtJW2QvIsi7t95+t+NxNjHR643Mm1khOLTz?=
 =?us-ascii?Q?Mw=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: cadence.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BYAPR07MB5381.namprd07.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 53cabf8e-70c4-4527-ab93-08daaa77b59c
X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Oct 2022 04:27:15.0495
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: d36035c5-6ce6-4662-a3dc-e762e61ae4c9
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: dWECJflmNlFqqKluakJVa5x3Hudcx6e0gWIh7sV6RNTJwTUGquiq0pTsTzuDAkN3l18ziHwaCBVe1GTKOHpxs4ZMMymGnXMUqdRXaiagBfo=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR07MB3160
X-Proofpoint-GUID: APgSWVIzeBEy-2YJcji_6VLxk3qM6_17
X-Proofpoint-ORIG-GUID: APgSWVIzeBEy-2YJcji_6VLxk3qM6_17
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.528,FMLib:17.11.122.1
 definitions=2022-10-07_04,2022-10-07_01,2022-06-22_01
X-Proofpoint-Spam-Details: rule=outbound_check_notspam policy=outbound_check score=0 adultscore=0
 malwarescore=0 phishscore=0 clxscore=1015 lowpriorityscore=0
 mlxlogscore=938 suspectscore=0 mlxscore=0 bulkscore=0 impostorscore=0
 priorityscore=1501 spamscore=0 classifier=spam adjust=0 reason=mlx
 scancount=1 engine=8.12.0-2209130000 definitions=main-2210100026
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE,
        SPF_NONE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

>
>In cdnsp_pci_remove, if pci_is_enabled returns true, it will
>call cdns_remove; else it will call kfree. Then both control flow
>goes to pci_dev_put.
>
>Adjust this logic by modifying it to an if else.
>

Acked-by: Pawel Laszczak <pawell@cadence.com>

Thanks
Pawel,

>Signed-off-by: Dongliang Mu <dzm91@hust.edu.cn>
>---
> drivers/usb/cdns3/cdnsp-pci.c | 8 +++-----
> 1 file changed, 3 insertions(+), 5 deletions(-)
>
>diff --git a/drivers/usb/cdns3/cdnsp-pci.c b/drivers/usb/cdns3/cdnsp-pci.c
>index fe8a114c586c..efd54ed918b9 100644
>--- a/drivers/usb/cdns3/cdnsp-pci.c
>+++ b/drivers/usb/cdns3/cdnsp-pci.c
>@@ -192,14 +192,12 @@ static void cdnsp_pci_remove(struct pci_dev *pdev)
> 	if (pci_dev_run_wake(pdev))
> 		pm_runtime_get_noresume(&pdev->dev);
>
>-	if (!pci_is_enabled(func)) {
>+	if (pci_is_enabled(func)) {
>+		cdns_remove(cdnsp);
>+	} else {
> 		kfree(cdnsp);
>-		goto pci_put;
> 	}
>
>-	cdns_remove(cdnsp);
>-
>-pci_put:
> 	pci_dev_put(func);
> }
>
>--
>2.25.1