Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <fa1a74cb-d240-d3d1-1ede-3c786becef7d@kontron.de>
Date:   Mon, 10 Oct 2022 09:11:34 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.1
Subject: Re: [PATCH 1/2] mtd: spinand: winbond: fix winbond lashes
 identifications
Content-Language: en-US
To:     mikhail.kshevetskiy@iopsys.eu, linux-kernel@vger.kernel.org,
        linux-mtd@lists.infradead.org
Cc:     Vignesh Raghavendra <vigneshr@ti.com>,
        Richard Weinberger <richard@nod.at>,
        Miquel Raynal <miquel.raynal@bootlin.com>
References: <20221007104820.198938-1-mikhail.kshevetskiy@iopsys.eu>
From:   Frieder Schrempf <frieder.schrempf@kontron.de>
In-Reply-To: <20221007104820.198938-1-mikhail.kshevetskiy@iopsys.eu>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?T2pES085R1FRcmxQQ0pGMFJNVWJwSWl3c25QcEUxWUpqeHphR0laSHVoa1pp?=
 =?utf-8?B?Y21XOTFXRXg1WlgweWdrenNkYjRBSkZZQ2FQUE80N0xsMGVxeUtmL1NlT2k5?=
 =?utf-8?B?WWV6RU1IalpIYS82bXhFYzJSWFdsbGNyYTd3dnVqTjVnajMvOStNdlhtanor?=
 =?utf-8?B?aE9uakY3UUpoMFFGUlVqNjNDVWtDSzU5dXlPSG94K3hVWFpSNU1pY0d5ZlZJ?=
 =?utf-8?B?THIrQnZJUlA2d3FyZlk4NlRRejlEa3lBaU85TWd0ektKZDdNeVlDc01pUHNH?=
 =?utf-8?B?alpFNmoreWRQbDVEQkpEYncrRllia3BJL29sUVR1Vi80M0o4d2Q1Q0l6UTVp?=
 =?utf-8?B?N0dqY2x4RFB0SGtucXd5MUZOTGFYa1NONHZMM0hTN2dEaFNiNjZURVc4ZGJG?=
 =?utf-8?B?TGF0OWI5TUYvSVU2ZWVScTBsZkpNUkM1SG1zVDJ4RjVCTTRTRUNKZFFOQWVI?=
 =?utf-8?B?UVN6c0grUU1sdmF1aWhkbWsxVS9yM3BpSmQ4VEdhNGh0RUJzSGxUSVU0UnVF?=
 =?utf-8?B?OGE0ZWFZS0hhWVp3UytQVllncERNdkowRDJYWDM4M0FGZnF1YUtZVm8zVFBv?=
 =?utf-8?B?dVRsbHR2REwrNEVQcU1qSG1PeGF0ZUh2VDR0UFBJYmx1ZFV3M3VSOExtcEhY?=
 =?utf-8?B?TER1Ymppa0RVUkI0ZTRIdnFVdWl5SW0vREo3RUk5ZlErTzI2YjdsTlNpZzh5?=
 =?utf-8?B?cGs0azFWTnBSVUY3ODhaV2N3UVpidnZiaXJ1SnRqNnNEV1ZELzFHdTRmeWFE?=
 =?utf-8?B?dXZLUU9yc3VTb0pJdzhLaXFmd0NBZDZpSlNDVFdDV1hyUHE4UFFWRXNDc3Jn?=
 =?utf-8?B?RkpJZ3pXaWI1ck1rSHpNd0pQV3VyN213QXJlWHoyeERFQzRXQm9GdUxLalZY?=
 =?utf-8?B?K1RSWG84SHV6NVBzejVpYkY1N040cXVPNXpWSTB4clRtR215NGRkZVo4L0tu?=
 =?utf-8?B?RktBZkZHamN5dGVhQUtScW5GdjdJWVV6bXc1SHJJeVVHMmM2UVhGS1JnL1hY?=
 =?utf-8?B?czNKUFoxcWZHYnRPblJkdG92OWNnZko5OFpiS3pFT1ZGeWl4cWxNZkVMQi9G?=
 =?utf-8?B?Y3k2Qm4yWXJQSVVWQzIyREptVVZkNzROQkY1WFBwWEFrTzUrbUlMcTJjRFIz?=
 =?utf-8?B?QzgrOFlxTW85YzlRMGNZVXNQMC9RODU1dTE3Zkw5ZTYzeFh1N1FyemN0OXZr?=
 =?utf-8?B?ajBVTnhUZnJUL2JIMllvWngvenFpWGt1VFUvTitCMGFSNloxNnZlWTB4cHRl?=
 =?utf-8?B?bURZL2FLbWFhWVl2QWc0eEprWktxa0tXMnFWMlRGQjB0ZW1UeTErTTF4dWRn?=
 =?utf-8?B?eFJvcHFqUGF4NE5UakU5ZUIybzlBZ3pUUjRVbERCT1VTRVdGemN0T3BtNGV6?=
 =?utf-8?B?Q2pGbkUxTDEwdkJhZjVCdktuVmszYm55bm45Y2VxMGpEVlg0T2VwZ2FzUzgv?=
 =?utf-8?B?cjhrbHBwbysrakZSN1lBZnJzWGFmRjRKQWhUTnM3K2haQzBCMU5Nak5yN1Yz?=
 =?utf-8?B?VjZ3cC8vYjNGUG9XcUdVR0FsWXFlRXJYRHNLa1BFZXRybllLQVhVeGw5bkV1?=
 =?utf-8?B?ampkNnAwUjFVemhFTlRiZTVleUpZcEttVWxIT3hOOWlOaW5pWVJUemRXcGIv?=
 =?utf-8?B?cFpuWkhYSlNzQ0VMbUUzdTBidklZWlNqMlNmNUVDdEc3V1BYZmxEMjZGK3dm?=
 =?utf-8?B?SURVbUV6MHVCLzN2RFczaUQ3Q01Ncko1SVhYQmIyVGtvK1FwVEp4cDB6bVQ1?=
 =?utf-8?B?UVgyN1ViUkZJUWhOaWl0ZUg0K09BQUNJbDlKUlRSemltdHVzMzFFczFCb0Vl?=
 =?utf-8?B?dlhGcC9ZL0dUYmJ1UGFwOWprN1B4SFRWMStlUmVhMDlPNWZtd0lOMmFpUjJC?=
 =?utf-8?B?UU5kZEZvaW50UjJKVVNGZlM4YjlsOW02MWswQUxFU2FXR1pIcVY4MU5mWTBr?=
 =?utf-8?B?SEd1dFZhR3Jaa0ozV1BvZHdhd2NBaHZQaTRiMjZmZGZuUjAzT0I0U1VUVk1v?=
 =?utf-8?B?SDhhdytqRUZNbmdpMlNnZUs4T2xoK0VRZmNhdmFOTlp0bVRlZVo2VVdaVHh3?=
 =?utf-8?B?Q2dLR0NEKzdzQ1pwWWUvdmJpNUYzQ3ViZUpYc0FPOGx1Y1g2WjhKTkZUZENG?=
 =?utf-8?B?eWVteE5QOTcweDhidTFYeWJyaG5sYXk4aFZHR0hIY0UyeUZXRERHd1dQdzNK?=
 =?utf-8?B?N0E9PQ==?=
X-OriginatorOrg: kontron.de
X-MS-Exchange-CrossTenant-Network-Message-Id: d1a795b7-899a-4bd3-ecb9-08daaa8eaac9
X-MS-Exchange-CrossTenant-AuthSource: PA4PR10MB5681.EURPRD10.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Oct 2022 07:11:35.5190
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 8c9d3c97-3fd9-41c8-a2b1-646f3942daf1
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 4Y8sIwRIBBLv7MTnU3tGvmku+7kLnMZPQcqXNVwXQfqsZ8R7GmcPTFu2DyhKlQZO+u/HVRlSn3PlgWOcu3Dz7WFFB7ao6+9uoT9pMKQ0CpI=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR10MB6898
X-Spam-Status: No, score=-5.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,
        SPF_HELO_PASS,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 07.10.22 12:48, mikhail.kshevetskiy@iopsys.eu wrote:
> From: Mikhail Kshevetskiy <mikhail.kshevetskiy@iopsys.eu>
> 
> Winbond uses 3 bytes to identify flash: vendor_id, dev_id_0, dev_id_1,
> but current driver uses only first 2 bytes of it for devices
> idenfification. As result Winbond W25N02KV flash (id_bytes: EF, AA, 22)

  ^ identification

> is identified as W25N01GV (id_bytes: EF, AA, 21).
> 
> Fix this by adding missed identification bytes.
> 
> Signed-off-by: Mikhail Kshevetskiy <mikhail.kshevetskiy@iopsys.eu>

Two things:

* each time you send a new version of your patches, you should increase
the version number in the prefix (e. g. using "git format-patch -v 2").

* I'm not a native English speaker and I don't get what "fix winbond
lashes identifications" is supposed to mean. Maybe something simple like
"fix identification" or "add missing id bytes" would do?