Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <a913e81e-3904-2e35-eaa7-89ae11652407@gmail.com>
Date:   Mon, 10 Oct 2022 12:28:25 +0300
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.0
Subject: Re: [RFC PATCH v2 3/5] dt-bindings: iio: Add KX022A accelerometer
Content-Language: en-US
To:     Jonathan Cameron <jic23@kernel.org>
Cc:     Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
        Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>,
        Lars-Peter Clausen <lars@metafoo.de>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        Jagath Jog J <jagathjog1996@gmail.com>,
        Nikita Yushchenko <nikita.yoush@cogentembedded.com>,
        Cosmin Tanislav <demonsingur@gmail.com>,
        linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <cover.1665066397.git.mazziesaccount@gmail.com>
 <80fa42040f385eb47f4f3c71b9b02f643a643e38.1665066397.git.mazziesaccount@gmail.com>
 <fc7c064f-074a-e66a-07b3-541f2ad56804@linaro.org>
 <7bbc0c04-04a8-f2c6-0436-3be0fc1013c7@gmail.com>
 <20221009132711.16055354@jic23-huawei>
From:   Matti Vaittinen <mazziesaccount@gmail.com>
In-Reply-To: <20221009132711.16055354@jic23-huawei>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 10/9/22 15:27, Jonathan Cameron wrote:
> On Thu, 6 Oct 2022 18:32:22 +0300
> Matti Vaittinen <mazziesaccount@gmail.com> wrote:
> 
>> Hi dee Ho Krzysztof,
>>
>> On 10/6/22 18:23, Krzysztof Kozlowski wrote:
>>> On 06/10/2022 16:37, Matti Vaittinen wrote:
>>>> KX022A is a 3-axis Accelerometer from ROHM/Kionix. The sensor features
>>>> include variable ODRs, I2C and SPI control, FIFO/LIFO with watermark IRQ,
>>>> tap/motion detection, wake-up & back-to-sleep events, four acceleration
>>>> ranges (2, 4, 8 and 16g) and probably some other cool features.
>>>>   
>>>
>>> Thank you for your patch. There is something to discuss/improve.
>>>    
>>>> +
>>>> +properties:
>>>> +  compatible:
>>>> +    const: kionix,kx022a
>>>> +
>>>> +  reg:
>>>> +    maxItems: 1
>>>> +
>>>> +  interrupts:
>>>> +    minItems: 1
>>>> +    maxItems: 2
>>>> +
>>>> +  interrupt-names:
>>>> +    minItems: 1
>>>> +    maxItems: 2
>>>> +    items:
>>>> +      enum:
>>>> +        - INT1
>>>> +        - INT2
>>>
>>> This allows any order, which I assume was your intention.
>>
>> Yes. I don't see real need to restrict ordering - besides, with my
>> yaml/schema skills it'd took eternity to find corrct example(s) ;)
>>
>> My intention is that the user can give either one of these - or both.
>> Order needs naturally to match the order of IRQs - but this we can't know.
>>
>>> However maybe
>>> at least fix it a bit like:
>>> minItems: 1
>>> items:
>>>     - enum: [ int1, int2]
>>>     - const: int2
>>
>> If you say so XD
>> I can fix this for v3 :)
> If my limited understanding is correct, one advantage of this restriction
> is that we can't have
> 
> "INT1", "INT1"
> though that may be prevented elsewhere...
> 
> There is no loss of useful flexibility in how Krzysztof suggested doing it
> so looks like a good suggestion to me.
Thanks Krzysztof and Jonathan :) I'll use Krzysztof's suggestion for the 
v3.

-- 
Matti Vaittinen
Linux kernel developer at ROHM Semiconductors
Oulu Finland

~~ When things go utterly wrong vim users can always type :help! ~~