Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <e70603da-4996-07c6-62de-85eab2d77b09@kontron.de>
Date:   Mon, 10 Oct 2022 12:59:19 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.2
Subject: Re: [PATCH v3 1/2] mtd: spinand: winbond: fix flash identification
Content-Language: en-US
To:     mikhail.kshevetskiy@iopsys.eu, linux-kernel@vger.kernel.org,
        linux-mtd@lists.infradead.org
Cc:     Vignesh Raghavendra <vigneshr@ti.com>,
        Richard Weinberger <richard@nod.at>,
        Miquel Raynal <miquel.raynal@bootlin.com>
References: <20221010105110.446674-1-mikhail.kshevetskiy@iopsys.eu>
From:   Frieder Schrempf <frieder.schrempf@kontron.de>
In-Reply-To: <20221010105110.446674-1-mikhail.kshevetskiy@iopsys.eu>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?V1lrOVVUUmh4K3JRajBwdEdmcXhybjA0WXBINkordkM0MkZXYXZKTCtlT09Y?=
 =?utf-8?B?L1lTTC9DV1lxcmU0OHNYSFhYbTJNTFZ2YWxsU1U3UDE3Vk80QW5aQ1pLaXA5?=
 =?utf-8?B?RnJpSHArMXI5d1lyMXVtUzNIZUFpb0R3d0pWN3dFWGdSdEpaK0MxZUloeHVr?=
 =?utf-8?B?V3JrRnp0bW5ySFlPOVdCeURKdVRZeXdsdDR5ek5IUC9odVFYRUxscHhER1B1?=
 =?utf-8?B?a3NxOXJJSjV2aVV4RjdzNVRkVU05NDVjVnE0dEZUa1FmdHNXK2RMQVR4U214?=
 =?utf-8?B?eEZJYW1XU3NLejhPaEVBN1JzbzF1aFdtQXkzWkNubGdVaklFMXV4cG5TcXp4?=
 =?utf-8?B?azlLMGwzZ081c1NqV3MyQUszTlJUR3dtZGo2QnFpVFV2cWpwZ0h4WWhaVXUz?=
 =?utf-8?B?a0tIbGl2VlRsRStHellxYzg1eEpJdHQ0NnQyVjVGRCtIaGZvUlVqTHc4Vnds?=
 =?utf-8?B?VU92ZmY2SUZoWm56T09vTWxtVi83aURlWm0zTlVjdFl5NGJaaU9peVFVOXgy?=
 =?utf-8?B?QlJUWkMzNGNjMXhZME54UEZJYXlGR3Q0TVYyTmRjTmpveDBWQVpDWjliZHdO?=
 =?utf-8?B?SkZZejY0eHVlMjVQRWlxVVJhWldXd09FcEFqbyszMnB5czZIbVEyYU13aElx?=
 =?utf-8?B?ZnRUa1Q4S2NHT1BjVXhXWFhuUXAwbnRJejNzbUU1UXBJUTZSYWNKUEhoODJI?=
 =?utf-8?B?d1gzY3ZIR0xIV1BWdXpVNDNGbFprcmNuYjRlaHByeWMvRnp0aXQvaURTS0xQ?=
 =?utf-8?B?cEdZcVVCYno4RlA0Z1NUWGE3ekUvb3Rya1lrYnQ4NnExTmFQRXB0bXRvdlNJ?=
 =?utf-8?B?d2dLanlCRThwTCtrK2dpZ2t2aDlyRUZTVzBxR1YxUkZDMHMvMnhNS2tFWXlG?=
 =?utf-8?B?WENkN3hva0FGUVNEY1BPNmFYZzYwRzc1c29ZMXJ4R0JVT0Z2NmlGbXNLYUVy?=
 =?utf-8?B?QTVGWU5FUkxFQ25jbjhtOXpBMEZmeWlhZ2xKUUFEVnc1MjlGNDcxUGV4b3Vj?=
 =?utf-8?B?OFRaV21HSEkvOU81MWFzbzdQcjNKSEdrRzVaWlZid0ZVczBEUzgrUUY5eEFK?=
 =?utf-8?B?NzlRKytleEJiSFo2SUtWa0x6OUhZSXFlQXVCc3BTYXFKT0NkR1NYRERGbzAx?=
 =?utf-8?B?Y0FqcFlLTm96SjVnMnRadDRVWjF5SXNEVnpZM21lNktPbEVIRGNuK3dzbStO?=
 =?utf-8?B?QWN5d0UwZHFML1JrN2E1QWxUNmR1ZGo5ZXhHMjNJdkRPOU0vWWd0TDY2Ti9k?=
 =?utf-8?B?c2F2Y1gvRThvaWNxQStKVklHQzBodUkxdkpMSVE2SmEyUkR1cCszYllSbnh0?=
 =?utf-8?B?NUlWQ3RLSTl0Z28xblFSeGM0QVpDYWlqV1hTVHViUEpXSS9NWHNtV1RlMkVo?=
 =?utf-8?B?R1doOGRXQzVUNmF4cEFzNldVSFVIMyszWmw2ZGZxY0lCMHhDZjhiaTFveW9v?=
 =?utf-8?B?VExmZm9rekR3SmthUVFtUUwzTytzeitvb2ZkQTJ3UzZLdXpacnpUK3UwbXpB?=
 =?utf-8?B?TmJGSlVyWDBnRHA0UFhEb21CUWNLSjBnNFRQU2xoWG1sZXpRUTVOS1hCV1JR?=
 =?utf-8?B?SDAwTlZQb3JaM0xNZHJwQTNDT2dSYVpzeDRsTmdMd2pSMFdvZzRpcVNTVFFv?=
 =?utf-8?B?WW9PaVB6OGU0MUl2b3JvOFc5NzcrRWtQcW8rTnl3QkJpMEFTUHh0SUNxdlpp?=
 =?utf-8?B?L2ZQVUwwallCcXJ0MytsTWxHOThoc3cxVGtTQWNzTTArK2EvY1Zvc2FkeVdJ?=
 =?utf-8?B?cWw3a05VVFN6ZTl3SFBvWTRhckF0QnZrM2NTU2JRR1MrNmZKRGhYaVU2blFQ?=
 =?utf-8?B?eXdZOXhPckhmeFpGT2JYT3ZkTmxVenJYbmhuSVdYd2g5OWlWYkVtc2x6YUZw?=
 =?utf-8?B?WFJmRlNCUkVyanhZdWpQcTcwQzJ0Q0FQQUh4ZlNpMnNTa3VlR2JFa1B3V2Y4?=
 =?utf-8?B?UXRaNnI0QjBvL3BzS3BlM1VhL3F4Sk12WjQ1Z282N1crcmluL0J3M09RWHZq?=
 =?utf-8?B?RTRqdmRaNEJJWFVFY0pYckRVbmIweDNLVnpxNTNWSjYzcklKMEIwVFBhVUhT?=
 =?utf-8?B?L2FNNnRZYjdHaTliVVp4ZkhXdmhQdWVoK1R3WkJhV2lnY3VkR2ozaVhrSDRL?=
 =?utf-8?B?dVZwei9pcWQxb2RLWXVxZzhQKys0RWdsSkVMMWhNUnVtam8xbndyck05cU54?=
 =?utf-8?B?N3c9PQ==?=
X-OriginatorOrg: kontron.de
X-MS-Exchange-CrossTenant-Network-Message-Id: 7f9c9a2a-cef0-4e71-6c09-08daaaae7bb3
X-MS-Exchange-CrossTenant-AuthSource: PA4PR10MB5681.EURPRD10.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Oct 2022 10:59:20.4140
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 8c9d3c97-3fd9-41c8-a2b1-646f3942daf1
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: MzychonvpPB+jLtGdrF9NUrBtdOy801g9qCydCQnInQEubCuvCiuj7c8K9N9FEfxALQha6wCtRrQkfbAnm46LuSxUCG0WNSVDlRViXqEybQ=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR10MB6728
X-Spam-Status: No, score=-3.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,
        SPF_HELO_PASS,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 10.10.22 12:51, mikhail.kshevetskiy@iopsys.eu wrote:
> From: Mikhail Kshevetskiy <mikhail.kshevetskiy@iopsys.eu>
> 
> Winbond uses 3 bytes to identify flash: vendor_id, dev_id_0, dev_id_1,
> but current driver uses only first 2 bytes of it for devices
> identification. As result Winbond W25N02KV flash (id_bytes: EF, AA, 22)
> is identified as W25N01GV (id_bytes: EF, AA, 21).
> 
> Fix this by adding missed identification bytes.
> 
> Signed-off-by: Mikhail Kshevetskiy <mikhail.kshevetskiy@iopsys.eu>

Thanks!

Reviewed-by: Frieder Schrempf <frieder.schrempf@kontron.de>