Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <b44eee1a-0d61-f5bb-7b0c-a01f13a0b297@redhat.com>
Date:   Mon, 10 Oct 2022 13:16:03 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.1
Subject: Re: [PATCH v2 1/5] memblock tests: add range tests for
 memblock_alloc_exact_nid_raw
Content-Language: en-US
To:     Rebecca Mckeever <remckee0@gmail.com>,
        Mike Rapoport <rppt@kernel.org>, linux-mm@kvack.org,
        linux-kernel@vger.kernel.org
References: <cover.1664753534.git.remckee0@gmail.com>
 <c73a6fd7fc3fa4529a6e444b9602d9c63ded91fd.1664753534.git.remckee0@gmail.com>
From:   David Hildenbrand <david@redhat.com>
Organization: Red Hat
In-Reply-To: <c73a6fd7fc3fa4529a6e444b9602d9c63ded91fd.1664753534.git.remckee0@gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 03.10.22 01:41, Rebecca Mckeever wrote:
> Add tests for memblock_alloc_exact_nid_raw() that are very similar to
> the range tests for memblock_alloc_try_nid_raw().
> 
> Signed-off-by: Rebecca Mckeever <remckee0@gmail.com>
> ---
>   tools/testing/memblock/Makefile               |    2 +-
>   tools/testing/memblock/main.c                 |    2 +
>   .../memblock/tests/alloc_exact_nid_api.c      | 1208 +++++++++++++++++
>   .../memblock/tests/alloc_exact_nid_api.h      |    9 +
>   4 files changed, 1220 insertions(+), 1 deletion(-)
>   create mode 100644 tools/testing/memblock/tests/alloc_exact_nid_api.c
>   create mode 100644 tools/testing/memblock/tests/alloc_exact_nid_api.h
> 
> diff --git a/tools/testing/memblock/Makefile b/tools/testing/memblock/Makefile
> index 246f7ac8489b..2310ac4d080e 100644
> --- a/tools/testing/memblock/Makefile
> +++ b/tools/testing/memblock/Makefile
> @@ -7,7 +7,7 @@ CFLAGS += -I. -I../../include -Wall -O2 -fsanitize=address \
>   LDFLAGS += -fsanitize=address -fsanitize=undefined
>   TARGETS = main
>   TEST_OFILES = tests/alloc_nid_api.o tests/alloc_helpers_api.o tests/alloc_api.o \
> -		  tests/basic_api.o tests/common.o
> +		  tests/basic_api.o tests/common.o tests/alloc_exact_nid_api.o
>   DEP_OFILES = memblock.o lib/slab.o mmzone.o slab.o
>   OFILES = main.o $(DEP_OFILES) $(TEST_OFILES)
>   EXTR_SRC = ../../../mm/memblock.c
> diff --git a/tools/testing/memblock/main.c b/tools/testing/memblock/main.c
> index 4ca1024342b1..278f9dec5008 100644
> --- a/tools/testing/memblock/main.c
> +++ b/tools/testing/memblock/main.c
> @@ -3,6 +3,7 @@
>   #include "tests/alloc_api.h"
>   #include "tests/alloc_helpers_api.h"
>   #include "tests/alloc_nid_api.h"
> +#include "tests/alloc_exact_nid_api.h"
>   #include "tests/common.h"
>   
>   int main(int argc, char **argv)
> @@ -12,6 +13,7 @@ int main(int argc, char **argv)
>   	memblock_alloc_checks();
>   	memblock_alloc_helpers_checks();
>   	memblock_alloc_nid_checks();
> +	memblock_alloc_exact_nid_checks();
>   
>   	return 0;
>   }


memblock_alloc_exact_nid_raw(NUMA_NO_NODE) behaves exactly the way 
memblock_alloc_try_nid_raw(NUMA_NO_NODE) behaves -- which is essentially 
memblock_alloc_raw().

So do we really need a separate set of tests for these?

-- 
Thanks,

David / dhildenb