Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <d6765e12-715a-066e-c6c3-63e0962ee3af@linaro.org>
Date:   Mon, 10 Oct 2022 07:31:31 -0400
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.1
Subject: Re: [PATCH v2 34/40] arm64: dts: qcom: sm6125: align TLMM pin
 configuration with DT schema
Content-Language: en-US
From:   Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To:     Marijn Suijten <marijn.suijten@somainline.org>
Cc:     Andy Gross <agross@kernel.org>,
        Bjorn Andersson <andersson@kernel.org>,
        Konrad Dybcio <konrad.dybcio@somainline.org>,
        Linus Walleij <linus.walleij@linaro.org>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Iskren Chernev <iskren.chernev@gmail.com>,
        Martin Botka <martin.botka@somainline.org>,
        Vinod Koul <vkoul@kernel.org>, linux-arm-msm@vger.kernel.org,
        linux-gpio@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <20220912061746.6311-1-krzysztof.kozlowski@linaro.org>
 <20220912061746.6311-35-krzysztof.kozlowski@linaro.org>
 <20221009174621.ecamh76faoibuykv@SoMainline.org>
 <d97b7d32-6e27-5a04-336b-0af6bd92c83c@linaro.org>
In-Reply-To: <d97b7d32-6e27-5a04-336b-0af6bd92c83c@linaro.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 10/10/2022 06:26, Krzysztof Kozlowski wrote:
> On 09/10/2022 13:46, Marijn Suijten wrote:
>>> diff --git a/arch/arm64/boot/dts/qcom/sm6125.dtsi b/arch/arm64/boot/dts/qcom/sm6125.dtsi
>>> index 8c582a9e4ada..1fe3fa3ad877 100644
>>> --- a/arch/arm64/boot/dts/qcom/sm6125.dtsi
>>> +++ b/arch/arm64/boot/dts/qcom/sm6125.dtsi
>>> @@ -387,19 +387,19 @@ tlmm: pinctrl@500000 {
>>>  			#interrupt-cells = <2>;
>>>  
>>>  			sdc2_off_state: sdc2-off-state {
>>> -				clk {
>>> +				clk-pins {
>>>  					pins = "sdc2_clk";
>>>  					drive-strength = <2>;
>>>  					bias-disable;
>>>  				};
>>>  
>>> -				cmd {
>>> +				cmd-pins {
>>>  					pins = "sdc2_cmd";
>>>  					drive-strength = <2>;
>>>  					bias-pull-up;
>>>  				};
>>>  
>>> -				data {
>>> +				data-pins {
>>>  					pins = "sdc2_data";
>>>  					drive-strength = <2>;
>>>  					bias-pull-up;
>>> @@ -413,13 +413,13 @@ clk {
>>>  					bias-disable;
>>>  				};
>>>  
>>> -				cmd {
>>> +				cmd-pins-pins {
>>
>> Is this double -pins-pins suffix intended?
>>
> 
> No, thanks for noticing it.

Wait, you commented on patch which was already merged. Fix is here already:
https://lore.kernel.org/linux-devicetree/20220930192954.242546-11-krzysztof.kozlowski@linaro.org/

Best regards,
Krzysztof