Received: by 2002:a05:6358:1087:b0:cb:c9d3:cd90 with SMTP id j7csp617389rwi; Mon, 10 Oct 2022 05:12:22 -0700 (PDT) X-Google-Smtp-Source: AMsMyM5Spah5yv5p6PpzNZZPEKHhFSbCeCI0DDEGgYAUkXVJ/BhcbZQUV6ubHoVUGoMHeNcQEAv4 X-Received: by 2002:a17:907:25c7:b0:77b:c193:9230 with SMTP id ae7-20020a17090725c700b0077bc1939230mr14036781ejc.316.1665403942543; Mon, 10 Oct 2022 05:12:22 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1665403942; cv=none; d=google.com; s=arc-20160816; b=DsB1hKRQAXDYu0D3yH2LQ5NWzslHiczJucYIKGjFrX6o4ZtPpklGlAmJMwmnJIUyWS RiY/H15/KMEjPNQWK92fjM65OV53J/9Ak927qzSiMPdmy671WMqlCSPQYkyN7/DNZ43i Qn9Fa9qaePboMy9t4RkHIEhs258uGJ8dc5RucNpBzIySsG3Rw39c+UCn5RfKgevi38rr EIs9SPiwLhYvnYMBvGM8nk2AJIMenvTD/hN5aRRQi5ZdvNbgadoaZUx3BxYLcAIpdI2B k6aUY0WHubdMcD7CQW9oBb26J7vgZx9OqCO2VeP0KA+WCDM8yH4dJgbOVh04Otd4y/ei hQVA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=LMsGQSLVOfha54XWPGcyWm87AvpehY1oczebVc/PKW0=; b=jIAZtPHxW//xlrjE+lMKOp2vWlTiCInFDn1goRFuS2vrdUdUq1UCEcq6/XGQ9PtxbI BHjfahs9PwASC8Uyo3Tp6n5lLS86p7u2Lv51Vd+UZxkeAyasAbYuRSLN9M1COiMmYeUf NHMqf2GR71Z+iA+A2XDEmE0b3Fr5pq656bYq+1mznzsEYmWoBcHSKmEyx7RhRMYt007J iPmVylrOG9ahLLs4AuoHpZi6X3KSUr05vkoBjcHClnU3VxyNGyatgCTmuc/RGyxC4LxA 0nv5AUubwp1RKZd3BAc1V70iKskHkBIkgSYJLCJUlipxLStxtuvtH0TX2eTaT09dxphi pHtg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@mediatek.com header.s=dk header.b=b8f9ZDhC; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=mediatek.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id go12-20020a1709070d8c00b0078c65d3a2a9si11893450ejc.859.2022.10.10.05.11.45; Mon, 10 Oct 2022 05:12:22 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@mediatek.com header.s=dk header.b=b8f9ZDhC; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=mediatek.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232093AbiJJLcO (ORCPT + 99 others); Mon, 10 Oct 2022 07:32:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39282 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231849AbiJJLcM (ORCPT ); Mon, 10 Oct 2022 07:32:12 -0400 Received: from mailgw02.mediatek.com (unknown [210.61.82.184]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8D4456E882 for ; Mon, 10 Oct 2022 04:32:07 -0700 (PDT) X-UUID: ce8144eed0a94323bd8abe3f64e3e9b6-20221010 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Type:Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:CC:To:From; bh=LMsGQSLVOfha54XWPGcyWm87AvpehY1oczebVc/PKW0=; b=b8f9ZDhCKPH6UNkrNBwW30QBVDCw8pm9ou++nVytBgPw6XIgjOOutKXXUcqkXlq9OQRWzTeRagAeySXcjTbf/Fw8BUvrdmvxDxfnPU2xsBi3JO6WbBxwKEYoclRLKPYvkD2Pl0XdGPbT3FloGgk7pIux2nZZfxunM3Uln/pd+nA=; X-CID-P-RULE: Release_Ham X-CID-O-INFO: VERSION:1.1.11,REQID:78a007d7-9cb8-46e6-a9dc-b6d58525fb93,IP:0,U RL:0,TC:0,Content:55,EDM:0,RT:0,SF:0,FILE:0,BULK:0,RULE:Release_Ham,ACTION :release,TS:55 X-CID-META: VersionHash:39a5ff1,CLOUDID:ab550bb9-daef-48a8-8c50-40026d6a74c2,B ulkID:nil,BulkQuantity:0,Recheck:0,SF:801|102,TC:nil,Content:3,EDM:-3,IP:n il,URL:0,File:nil,Bulk:nil,QS:nil,BEC:nil,COL:0 X-UUID: ce8144eed0a94323bd8abe3f64e3e9b6-20221010 Received: from mtkmbs10n2.mediatek.inc [(172.21.101.183)] by mailgw02.mediatek.com (envelope-from ) (Generic MTA with TLSv1.2 ECDHE-RSA-AES256-GCM-SHA384 256/256) with ESMTP id 2033671038; Mon, 10 Oct 2022 19:32:02 +0800 Received: from mtkmbs13n1.mediatek.inc (172.21.101.193) by mtkmbs13n1.mediatek.inc (172.21.101.193) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.792.15; Mon, 10 Oct 2022 19:32:00 +0800 Received: from localhost.localdomain (10.17.3.154) by mtkmbs13n1.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.2.792.15 via Frontend Transport; Mon, 10 Oct 2022 19:31:59 +0800 From: Yongqiang Niu To: CK Hu , Chun-Kuang Hu CC: Jassi Brar , Matthias Brugger , , , , , Hsin-Yi Wang , Yongqiang Niu , AngeloGioacchino Del Regno Subject: [PATCH v10, 1/4] mailbox: mtk-cmdq: Use GCE_CTRL_BY_SW definition instead of number Date: Mon, 10 Oct 2022 16:50:20 +0800 Message-ID: <20221010085023.7621-2-yongqiang.niu@mediatek.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20221010085023.7621-1-yongqiang.niu@mediatek.com> References: <20221010085023.7621-1-yongqiang.niu@mediatek.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-MTK: N X-Spam-Status: No, score=-1.2 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_MSPIKE_H2,RDNS_NONE, SPF_HELO_PASS,T_SPF_TEMPERROR,UNPARSEABLE_RELAY,URIBL_CSS autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Use GCE_CTRL_BY_SW definition instead of number Signed-off-by: Yongqiang Niu Reviewed-by: AngeloGioacchino Del Regno --- drivers/mailbox/mtk-cmdq-mailbox.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/mailbox/mtk-cmdq-mailbox.c b/drivers/mailbox/mtk-cmdq-mailbox.c index 9465f9081515..c3cb24f51699 100644 --- a/drivers/mailbox/mtk-cmdq-mailbox.c +++ b/drivers/mailbox/mtk-cmdq-mailbox.c @@ -38,6 +38,7 @@ #define CMDQ_THR_PRIORITY 0x40 #define GCE_GCTL_VALUE 0x48 +#define GCE_CTRL_BY_SW GENMASK(2, 0) #define CMDQ_THR_ACTIVE_SLOT_CYCLES 0x3200 #define CMDQ_THR_ENABLED 0x1 @@ -129,7 +130,8 @@ static void cmdq_init(struct cmdq *cmdq) WARN_ON(clk_bulk_enable(cmdq->gce_num, cmdq->clocks)); if (cmdq->control_by_sw) - writel(0x7, cmdq->base + GCE_GCTL_VALUE); + writel(GCE_CTRL_BY_SW, cmdq->base + GCE_GCTL_VALUE); + writel(CMDQ_THR_ACTIVE_SLOT_CYCLES, cmdq->base + CMDQ_THR_SLOT_CYCLES); for (i = 0; i <= CMDQ_MAX_EVENT; i++) writel(i, cmdq->base + CMDQ_SYNC_TOKEN_UPDATE); -- 2.25.1