Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <aa2484ea-03b1-f3fd-339e-145e3fb79c78@amd.com>
Date:   Mon, 10 Oct 2022 16:29:45 +0530
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.9.1
Subject: Re: [PATCH] perf: Rewrite core context handling
Content-Language: en-US
To:     Peter Zijlstra <peterz@infradead.org>
Cc:     acme@kernel.org, alexander.shishkin@linux.intel.com,
        jolsa@redhat.com, namhyung@kernel.org, songliubraving@fb.com,
        eranian@google.com, ak@linux.intel.com, mark.rutland@arm.com,
        frederic@kernel.org, maddy@linux.ibm.com, irogers@google.com,
        will@kernel.org, robh@kernel.org, mingo@redhat.com,
        catalin.marinas@arm.com, linux-arm-kernel@lists.infradead.org,
        linux-perf-users@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
        linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org,
        sandipan.das@amd.com, ananth.narayan@amd.com, kim.phillips@amd.com,
        santosh.shukla@amd.com, Ravi Bangoria <ravi.bangoria@amd.com>
References: <20220829113347.295-1-ravi.bangoria@amd.com>
 <e1d933d1-4772-1357-9cf1-6e5b842508c8@amd.com>
 <Y0PwgBz6asJOHSan@hirez.programming.kicks-ass.net>
From:   Ravi Bangoria <ravi.bangoria@amd.com>
In-Reply-To: <Y0PwgBz6asJOHSan@hirez.programming.kicks-ass.net>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ekV4TVlPMW5iNEIySmNVczlsUWc5clY3NDgwQVZ4dEVOVkI2d29mRUhqbjRw?=
 =?utf-8?B?RzUxamt5TVlPb3JqSzJaK3dhck9sSGZicnZCOUM0ZWhEYmpwc0VXZDJLQzN3?=
 =?utf-8?B?MTh1dGN3QitKNXpKU0JPazZLWVpVQTFaV3loMGFlUWFwUXc4S2xZZm5NclRs?=
 =?utf-8?B?ODBGN2tCeWpsZDdjM0dxekFsVG5CV1ZzNVlJTytla1ZtYjJFdUJIcDR3dkZw?=
 =?utf-8?B?TENhRWR5WktyMUVEN2Nid1JFUW00UENtODhSOW93NjYvdVYwNXMzcnpRUlR3?=
 =?utf-8?B?RHd3UHlzN0dVNjVqeHh2L0l3c1lkUHhOUjZnVk16RHJyL2RpWnp3TzFOVFQ5?=
 =?utf-8?B?OTZ2Q1JLalhQRlVrUmg3VW1IM0ZIc2UrZmxPeW1HSzNXRjU1bHV3dGV2WnhX?=
 =?utf-8?B?eHpobnIzZ3lMTG9PcnVPYzdnMk9wVlpBL29jU3c1VW9WQ1NESEZ4amRhcWth?=
 =?utf-8?B?NzFSUG9YS1dlREc5cXhXV0xVMVFPNWlwTnVRbWFFLzJCTkhZcDl4MkNaUTcw?=
 =?utf-8?B?WmczZGp1NG4yZ2cwb01tSGx0R2wyZ2o0TjAyd3J0TWtXWEtRc2dLbTVFekxE?=
 =?utf-8?B?RWtHZmdWUWZsTUY2Ty9wZlhNYnFISmx6dGoyd09oeEd3c1ljOU5HUHNyZVlH?=
 =?utf-8?B?V2gzcnZZcHZCdmRwVExENS9idENjRlNpTDQzUUNvdlV0b1VhaFZ0dXdhYzIx?=
 =?utf-8?B?VUhWSStxZXVOb253SHNJSG1tTCsrdm9xdWhKcmVXb0VnbnJha3dIc2FNSi9o?=
 =?utf-8?B?SHBpQmJ2STlIZlhqN0ZKTHdHUmMzeW9uRktkZ2RwdEVVVTZ2YW9YT0FkV25l?=
 =?utf-8?B?QTFYWWMzN29nU3o1VUFjZEd3a3NYcmxmVDZZTTYvc202V3ZiSm9QNS9xcFgy?=
 =?utf-8?B?WkVQN1pLeldQN0RldFNjeXJnVDh6NmpzR3BsbVowRzFiaGg5WTFyS2ZveTgv?=
 =?utf-8?B?RjkxQ2RxSXE5ZmJFSXpQZjlKb3ZrRnc3SDYzV2pKS05PSGNISWdsRW8zZW9r?=
 =?utf-8?B?S3lUQW9abXdPYUN4TVFBWGtyQUkwWk9HcWtENmthMEJLMkFVL0VBTjZFdHYz?=
 =?utf-8?B?ZU5LTFdRa29jUms3UEgxMkdhMlhvLzRGZzhPNWNqaTREZDR2ZHJ2eUdvZGJW?=
 =?utf-8?B?V2ltSWJObFJpSTZLd3RIeDVtZGFBMVhDVFlWTmVMd2xoYXRCWWRDWGtKbVo2?=
 =?utf-8?B?bnI5MkcrN3pmY2doNDU1V1lScTQzMEFPTFA0RGdtNGhmalg5dU9iZi9zTjJm?=
 =?utf-8?B?ZXlRb2d2ekRnd2JyeEhLbXpSZmw2TzNtTVJiRG9TU0NiTExSVXAxZ2lWN2pE?=
 =?utf-8?B?bVBRQVBsS0pIaGRWa3NqU0NhZTA2aC9QT0RWZW13MjJITlhzem9YRUNiNU1m?=
 =?utf-8?B?R1Vna2U2SzZ6RHR3dzJ3TmEvOEZYWkhZbFoxZExpZ0k3eGVYVFFwOVFMbnRX?=
 =?utf-8?B?SHpNc21SUnBmUU9LSGFUdXgvc2pCMnRqQzM2aVdJSTZiR3luUnAwM2FoSkpN?=
 =?utf-8?B?UkcyQkwwQ1dXMVlCV004aDA0TzdlMHczMDFRV3Vjd3pqTkVDMTk2Q3JlVFpk?=
 =?utf-8?B?eEtsQ0kvL1F0MUVFK3ZRUXExV3lRTzdsaGM0eFArUXhaMi91Y2FCbFNva09L?=
 =?utf-8?B?Nk13TFdQeEtWY0JZdWx6M0hLcFBnM0ROL3FwUGFXOWN3blFWSC9seDVRMndL?=
 =?utf-8?B?R091NHhiK00yM0E1MDFxUDRNdFFEb0RIK09aK0ZHUzN0RTdBbmtLR2J6NzR2?=
 =?utf-8?B?WEYwK0FjcmZZOHhma1JlRUdmRmp3Y3NvY0MzbDdlZ1ZSck1DZ3I0Y29vQzNL?=
 =?utf-8?B?aDhwdjl6cHQ4c2xFdnh0MWhvN05Ud2ZFcGxhMk43VVhUeEVFNTNiNzZsWFVo?=
 =?utf-8?B?N2NHdmUvY2RvK1VNSHUyaStMTTN4TjZZd2hJdTNqWmlOdE1iTW9VU3ZFcnd4?=
 =?utf-8?B?UE1SS25iV2tlMnJkYUNwVUZCb2RHdEx4NHhHTkZ2WWpPNktvaVMyUDVvUkR0?=
 =?utf-8?B?bGZjSnRhUFpwZVpCMnpvY0cyV1ZnOGpMZk5zaGZRSS9WeHYzcVFsQlZRQThx?=
 =?utf-8?B?a3NMWUVQcVB6RWVRV0kyUCtvRjI4SDQ2Zk1PY3pudlpmNS9uVWFNcjRmV1Bu?=
 =?utf-8?Q?e284L3iuPVLyzM+kk5+7N40kD?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a6859159-301d-46cf-88ce-08daaaae9451
X-MS-Exchange-CrossTenant-AuthSource: PH7PR12MB6588.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Oct 2022 11:00:01.9810
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 59EthyghzGF0rpskTNtgzOLp8wME86RGWyjIzFbJanziGi5mtpKGfqjSIqR93WvEXg1p4j4n66SwLXUtmsj44g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB4284
X-Spam-Status: No, score=-4.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 10-Oct-22 3:44 PM, Peter Zijlstra wrote:
> On Wed, Sep 07, 2022 at 04:58:49PM +0530, Ravi Bangoria wrote:
>>> -static void
>>> -ctx_flexible_sched_in(struct perf_event_context *ctx,
>>> -		      struct perf_cpu_context *cpuctx)
>>> +/* XXX .busy thingy from Peter's patch */
>>> +static void ctx_flexible_sched_in(struct perf_event_context *ctx, struct pmu *pmu)
>>
>> This one turned out to be very easy. Given that, we iterate over each
>> pmu, we can just return error if we fail to schedule any flexible event.
>> (It wouldn't be straight forward like this if we needed to implement
>> pmu=NULL optimization.)
>>
>> ---
>> diff --git a/kernel/events/core.c b/kernel/events/core.c
>> index e0232e0bb74e..923656af73fe 100644
>> --- a/kernel/events/core.c
>> +++ b/kernel/events/core.c
>> @@ -3751,6 +3751,7 @@ static int merge_sched_in(struct perf_event *event, void *data)
>>  			cpc = this_cpu_ptr(event->pmu_ctx->pmu->cpu_pmu_context);
>>  			perf_mux_hrtimer_restart(cpc);
>>  			group_update_userpage(event);
>> +			return -EBUSY;
>>  		}
>>  	}
>>  
> 
> I'm afraid this breaks things; consider:
> 
>   f79256532682 ("perf/core: fix userpage->time_enabled of inactive events")
> 
> I totally hate this -- because it means we *HAVE* to iterate the
> inactive events, but alas.

Sure. Will drop this.

Thanks,
Ravi